Skip to contentSkip to conversation

CONFIG_VM_EVENT_COUNTER comment decrustify

PATCH In review Paul Jackson 2 participants 2 messages Dec 13, 2006 MM core

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 CONFIG_VM_EVENT_COUNTER comment decrustify

From: Paul Jackson <[email protected]>

The VM event counters, enabled by CONFIG_VM_EVENT_COUNTERS, which provides VM event counters in /proc/vmstat, has become more essential to non-EMBEDDED kernel configurations than they were in the past. Comments in the code and the Kconfig configuration explanation were stale, downplaying their role excessively.

Refresh those comments to correctly reflect the current role of VM event counters.

---

Christoph and Andrew (I sure hope) understand what's the truth here better than I. I trust they won't hesitate to refine, hack, mutilate, ignore or extend this patch, as appropriate.
- pj

 include/linux/vmstat.h |    5 +++--
 init/Kconfig           |    8 ++++----
 2 files changed, 7 insertions(+), 6 deletions(-)
include/linux/vmstat.h +3 -2
@@ -10,8 +10,9 @@
 /*
  * Light weight per cpu counter implementation.
  *
- * Counters should only be incremented and no critical kernel component
- * should rely on the counter values.
+ * Counters should only be incremented.  You need to set EMBEDDED
+ * to disable VM_EVENT_COUNTERS.  Things like procps (vmstat,
+ * top, etc) use /proc/vmstat and depend on these counters.
  *
  * Counters are handled completely inline. On many platforms the code
  * generated will simply be the increment of a global address.
init/Kconfig +4 -4
@@ -483,10 +483,10 @@ config VM_EVENT_COUNTERS
 	default y
 	bool "Enable VM event counters for /proc/vmstat" if EMBEDDED
 	help
-	  VM event counters are only needed to for event counts to be
-	  shown. They have no function for the kernel itself. This
-	  option allows the disabling of the VM event counters.
-	  /proc/vmstat will only show page counts.
+	  VM event counters are needed for event counts to be shown.
+	  This option allows the disabling of the VM event counters
+	  on EMBEDDED systems.  /proc/vmstat will only show page counts
+	  if VM event counters are disabled.
 
 endmenu		# General setup
 
Signature · 3 lines
                          I won't rest till it's the best ...
                          Programmer, Linux Scalability
                          Paul Jackson <[email protected]> 1.650.933.1373
Acked-by on v1 1/1
#1 lore raw
Quoted 8 lines · Paul Jackson

From: Paul Jackson <[email protected]>

The VM event counters, enabled by CONFIG_VM_EVENT_COUNTERS, which provides VM event counters in /proc/vmstat, has become more essential to non-EMBEDDED kernel configurations than they were in the past. Comments in the code and the Kconfig configuration explanation were stale, downplaying their role excessively.

Quoted 4 lines

Refresh those comments to correctly reflect the current role of VM event counters.