he: tiny space savings
Subsystems (4)
PATCH 1/1 he: tiny space savings
From: Andi Drebes <[email protected]>
text data bss dec hex filename
20015 480 28 20523 502b drivers/atm/he.o 19997 480 28 20505 5019 drivers/atm/he.o
---
drivers/atm/he.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/atm/he.c +1 -1
@@ -101,7 +101,7 @@ #endif /* HE_DEBUG *//* version definition */ -static char *version ="$Id: he.c,v 1.18 2003/05/06 22:57:15 chas Exp $" ; +static const char version[] ="$Id: he.c,v 1.18 2003/05/06 22:57:15 chas Exp $" ;/* declarations */
_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.osdl.org/mailman/listinfo/kernel-janitors
Quoted 16 lines · Alexey Dobriyan
From: Andi Drebes <[email protected]>
text data bss dec hex filename
20015 480 28 20523 502b drivers/atm/he.o 19997 480 28 20505 5019 drivers/atm/he.oSigned-off-by Andi Drebes <[email protected]>Signed-off-by Alexey Dobriyan <[email protected]>---
drivers/atm/he.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/atm/he.c #endif /* HE_DEBUG */ · line 104
Quoted 6 lines
drivers/atm/he.c +1
-1@@ -101,7 +101,7 @@ #endif /* HE_DEBUG *//* version definition */ -static char *version ="$Id: he.c,v 1.18 2003/05/06 22:57:15 chas Exp $" ; +static const char version[] ="$Id: he.c,v 1.18 2003/05/06 22:57:15 chas Exp $" ;
Can't we kill this ancient and outdated version string instead?
cu
Adrian
Signature · 9 lines
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.osdl.org/mailman/listinfo/kernel-janitorsQuoted 17 lines · Adrian Bunk
Quoted 16 lines · Alexey Dobriyan
From: Andi Drebes <[email protected]>
text data bss dec hex filename20015 480 28 20523 502b drivers/atm/he.o 19997 480 28 20505 5019 drivers/atm/he.oSigned-off-by Andi Drebes <[email protected]>Signed-off-by Alexey Dobriyan <[email protected]>---
drivers/atm/he.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/atm/he.c +0
-0@@ -101,7 +101,7 @@ #endif /* HE_DEBUG */
Quoted 7 lines
drivers/atm/he.c #endif /* HE_DEBUG */ · line 104
Quoted 5 lines
drivers/atm/he.c +1
-1/* version definition */ -static char *version ="$Id: he.c,v 1.18 2003/05/06 22:57:15 chas Exp $" ; +static const char version[] ="$Id: he.c,v 1.18 2003/05/06 22:57:15 chas Exp $" ;Can't we kill this ancient and outdated version string instead?
"version" is involved in he_proc_read(). I think, no.
_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.osdl.org/mailman/listinfo/kernel-janitors
Quoted 20 lines · Alexey Dobriyan
Quoted 19 lines · Adrian Bunk
Quoted 18 lines · Alexey Dobriyan
From: Andi Drebes <[email protected]>
text data bss dec hex filename20015 480 28 20523 502b drivers/atm/he.o 19997 480 28 20505 5019 drivers/atm/he.oSigned-off-by Andi Drebes <[email protected]>Signed-off-by Alexey Dobriyan <[email protected]>---
drivers/atm/he.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/atm/he.c +0
-0@@ -101,7 +101,7 @@ #endif /* HE_DEBUG *//* version definition */
Quoted 7 lines
Quoted 5 lines
drivers/atm/he.c #endif /* HE_DEBUG */ · line 104
Quoted 3 lines
drivers/atm/he.c +1
-1-static char *version ="$Id: he.c,v 1.18 2003/05/06 22:57:15 chas Exp $" ; +static const char version[] ="$Id: he.c,v 1.18 2003/05/06 22:57:15 chas Exp $" ;Can't we kill this ancient and outdated version string instead?
"version" is involved in
he_proc_read(). I think, no.
You don;t have to omit this line, but printing a more than 3 years old CVS tag is silly (I can't believe anyone is parsing the CVS version).
cu
Adrian
Signature · 9 lines
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.osdl.org/mailman/listinfo/kernel-janitorsDavid Miller
maintainerFrom: Alexey Dobriyan <[email protected]>
Date: Sun, 17 Dec 2006 15:56:22 +0300
Quoted 8 lines
From: Andi Drebes <[email protected]>
text data bss dec hex filename
20015 480 28 20523 502b drivers/atm/he.o 19997 480 28 20505 5019 drivers/atm/he.oSigned-off-by Andi Drebes <[email protected]>Signed-off-by Alexey Dobriyan <[email protected]>
As Adrian said, this CVS string is totally useless.
That being said, it should be replaced with an appropriate piece of versioning information, like the ones we use via MODULE_VERSION() in other drivers.
I'll be happy to apply a patch which gets rid of the CVS references, and replaces it with something useful.
Thanks.
_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.osdl.org/mailman/listinfo/kernel-janitors
PATCH 1/1 drivers/atm/he.c: remove ancient version string
Quoted 9 lines · David Miller
From: Alexey Dobriyan <[email protected]>
Date: Sun, 17 Dec 2006 15:56:22 +0300Quoted 6 lines
From: Andi Drebes <[email protected]>
text data bss dec hex filename
20015 480 28 20523 502b drivers/atm/he.o 19997 480 28 20505 5019 drivers/atm/he.o
Quoted 8 lines
Quoted 2 lines
Signed-off-by Andi Drebes <[email protected]>Signed-off-by Alexey Dobriyan <[email protected]>As Adrian said, this CVS string is totally useless.
That being said, it should be replaced with an appropriate piece of versioning information, like the ones we use via
MODULE_VERSION()in other drivers.
Which versioning information?
There does not seem to be any versioning information that is getting updated.
There are some truly exceptional cases where maintainers are using and updating version strings, but in all other cases there's simply nothing that's worth being printed.
Quoted 2 lines
I'll be happy to apply a patch which gets rid of the CVS references, and replaces it with something useful.
Patch below.
Quoted 1 line
Thanks.
cu
Adrian
<-- snip -->
This patch removes the ancient version string.
---
drivers/atm/he.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-)
drivers/atm/he.c renamed from drivers/atm/he.c.old +2 -8
@@ -1,5 +1,3 @@ -/* $Id: he.c,v 1.18 2003/05/06 22:57:15 chas Exp $ */ -/* he.c
@@ -99,10 +97,6 @@ #define HPRINTK(fmt,args...) do { } while (0)#endif /* HE_DEBUG */ -/* version definition */ - -static char *version ="$Id: he.c,v 1.18 2003/05/06 22:57:15 chas Exp $" ; -/* declarations */ static int he_open (struct atm_vcc *vcc);
@@ -366,7 +360,7 @@ he_init_one(struct pci_dev *pci_dev, construct he_dev *he_dev =NULL ;int err =0 ; -printk (KERN_INFO "he: %s\n" , version); +printk (KERN_INFO "ATM he driver\n" );if (pci_enable_device (pci_dev))return -EIO ;
@@ -2933,7 +2927,7 @@ he_proc_read(struct atm_dev *dev, loff_t left = *pos;if (!left--) -return sprintf (page,"%s\n" , version); +return sprintf (page,"ATM he driver\n" );if (!left--) return sprintf(page, "%s%s\n\n",
_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.osdl.org/mailman/listinfo/kernel-janitors