Skip to contentSkip to conversation

ieee80211: WLAN_GET_SEQ_SEQ fix

PATCH In review Zhu Yi 1 participant 2 messages Dec 18, 2006 – Dec 19, 2006 1 message not in the archive

Subsystems (2)
lore
Share & tools
lore

Zhu Yi

author
#0 lore raw

PATCH 1/1 ieee80211: WLAN_GET_SEQ_SEQ fix

include/net/ieee80211.h +1 -1
index e6af381..e02d85f 100644
@@ -218,7 +218,7 @@ struct ieee80211_snap_hdr {
 #define WLAN_FC_GET_STYPE(fc) ((fc) & IEEE80211_FCTL_STYPE)
 
 #define WLAN_GET_SEQ_FRAG(seq) ((seq) & IEEE80211_SCTL_FRAG)
-#define WLAN_GET_SEQ_SEQ(seq)  ((seq) & IEEE80211_SCTL_SEQ)
+#define WLAN_GET_SEQ_SEQ(seq)  (((seq) & IEEE80211_SCTL_SEQ) >> 4)
 
 /* Authentication algorithms */
 #define WLAN_AUTH_OPEN 0

A message that is not in the archive (sent off-list or not yet received): [email protected]

author
#2 lore raw
Quoted 7 lines · Larry Finger

Shouldn't this fix have some commit message like "The WLAN_GET_SEQ_SEQ(seq) macro in ieee80211 is
selecting the wrong region."? That said, the fix conforms with the IEEE802.11 specs.

OK. I thought it was obvious.

Thanks,
-yi