New way to handle unsupported models
PATCH 11/22 New way to handle unsupported models
Now, if a model is unsupported, the module will not be loaded. But, the user can force it to load, and use default values with :
modprobe asus_acpi unsupported=1
This will avoid bugs like
<http://lists.kde.org/?l=kde-bugs-dist&m=114846987006116&w=2>.
--- asus_acpi.c | 28 +++++++++++++++++++++++++--- 1 file changed, 25 insertions(+), 3 deletions(-)
drivers/acpi/asus_acpi.c 2006-12-15 13:39:36.000000000 +0100 renamed from drivers/acpi/asus_acpi.c 2006-12-15 13:37:13.000000000 +0100 +3 -0
@@ -88,6 +88,10 @@ MODULE_DESCRIPTION(ACPI_HOTK_NAME); MODULE_LICENSE("GPL"); +static uint unsupported; +module_param(unsupported, uint, 0); +MODULE_PARM_DESC(unsupported, "Allow the use of default values for an
unsupported model.\n");
+
/* For each model, all features implemented,
* those marked with R are relative to HOTK, A for absolute */
@@ -159,6 +163,7 @@
W3V, //W3030V
xxN, //M2400N, M3700N, M5200N, M6800N, S1300N,
S5200N
//(Centrino)+ DEF, //Default values
END_MODEL
} model; //Models currently supported
u16 event_count[128]; //count for each event TODO make this better
@@ -414,7 +419,15 @@
.brightness_set = "SPLV",
.brightness_get = "GPLV",
.display_set = "SDSP",
- .display_get = "\\ADVG"}
+ .display_get = "\\ADVG"},
+
+ {
+ .name = "???", + .mled_set = "MLED", + .wled_set = "WLED", + .brightness_set = "SPLV", + .brightness_get = "GPLV", + .display_set = "SDSP"}
};
/* procdir we use */
@@ -1293,12 +1306,21 @@
hotk->model = P30;
printk(KERN_NOTICE
" Samsung P30 detected, supported\n");
- } else {
- hotk->model = M2E;
+ } else if(unsupported) {
printk(KERN_NOTICE " unsupported model %s, trying "
"default values\n", string);
printk(KERN_NOTICE
" send /proc/acpi/dsdt to the developers\n");+ hotk->model = DEF;
+
+ } else {
+ printk(KERN_NOTICE " unsupported model %s\n",
string);
+ printk(KERN_NOTICE
+ " send /proc/acpi/dsdt to the developers\n");
+ printk(KERN_NOTICE
+ " you can use the \"unsupported=1\" "
+ "parameter to have a minimal support\n");
+ return -ENODEV;
}
hotk->methods = &model_conf[hotk->model];
return AE_OK;Signature · 2 lines
CHARY 'Iksaif' Corentin http://xf.iksaif.net