Skip to contentSkip to conversation

high-res timers: fix APIC event-broadcasting code

PATCH New Ingo Molnar 1 participant 1 message Dec 21, 2006

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 high-res timers: fix APIC event-broadcasting code

Subject: [patch] high-res timers: fix APIC event-broadcasting code
From: Ingo Molnar <[email protected]>

this patch fixes a bug in the APCI-C3-turns-off-lapic related event-broadcasting code: it accidentally reactivated the global tick, instead of the global event emulation layer.

The effect of this bug was a rare bootup hang on one of my test-laptops
- but it could also result in other types of timer related problems (but not hangs in an already running system), such as imprecise high-res timeouts.

Debugged via SysRq-Q.

---
 arch/i386/kernel/apic.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/i386/kernel/apic.c +2 -2
Index: linux-hres-timers.q/arch/i386/kernel/apic.c
===================================================================
@@ -506,7 +506,7 @@ void switch_APIC_timer_to_ipi(void *cpum
 	int cpu = smp_processor_id();
 
 	if (cpu_isset(cpu, mask) && levt->event_handler)
-		clockevents_set_global_broadcast(levt, 1);
+		clockevents_set_broadcast(levt, 1);
 }
 EXPORT_SYMBOL_GPL(switch_APIC_timer_to_ipi);
 
@@ -517,7 +517,7 @@ void switch_ipi_to_APIC_timer(void *cpum
 	int cpu = smp_processor_id();
 
 	if (cpu_isset(cpu, mask) && levt->event_handler)
-		clockevents_set_global_broadcast(levt, 0);
+		clockevents_set_broadcast(levt, 0);
 }
 EXPORT_SYMBOL_GPL(switch_ipi_to_APIC_timer);