Skip to contentSkip to conversation

module: fix mod_sysfs_setup() return value

PATCH New Akinobu Mita 1 participant 1 message Dec 25, 2006

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 module: fix mod_sysfs_setup() return value

mod_sysfs_setup() doesn't return error when kobject_add_dir() failed.

---
 kernel/module.c |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
kernel/module.c +3 -1
Index: 2.6-mm/kernel/module.c
===================================================================
@@ -1132,8 +1132,10 @@ static int mod_sysfs_setup(struct module
 		goto out;
 
 	mod->drivers_dir = kobject_add_dir(&mod->mkobj.kobj, "drivers");
-	if (!mod->drivers_dir)
+	if (!mod->drivers_dir) {
+		err = -ENOMEM;
 		goto out_unreg;
+	}
 
 	err = module_param_sysfs_setup(mod, kparam, num_params);
 	if (err)