Skip to contentSkip to conversation

xfrm: Algorithm lookup using .compat name

PATCH Applied Martin Willi 3 participants 4 messages Dec 22, 2006 – Dec 29, 2006

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 xfrm: Algorithm lookup using .compat name

Installing an IPsec SA using old algorithm names (.compat) does not work if the algorithm is not already loaded. When not using the PF_KEY interface, algorithms are not preloaded in xfrm_probe_algs() and installing a IPsec SA fails.

net/xfrm/xfrm_algo.c 2006-12-22 16:58:19.000000000 +0100 renamed from net/xfrm/xfrm_algo.c 2006-12-22 16:43:31.000000000 +0100 +0 -1
@@ -399,7 +399,8 @@ static struct xfrm_algo_desc *xfrm_get_b
                if (!probe)
                    break;
 
-               status = crypto_has_alg(name, type, mask |

CRYPTO_ALG_ASYNC);
+ status = crypto_has_alg(list[i].name, type,

+                               mask | CRYPTO_ALG_ASYNC);
                if (!status)
                    break;
maintainer
#1 lore raw
Quoted 4 lines · Martin Willi

Installing an IPsec SA using old algorithm names (.compat) does not work if the algorithm is not already loaded. When not using the PF_KEY interface, algorithms are not preloaded in xfrm_probe_algs() and installing a IPsec SA fails.

Good catch. Thanks Martin!

Signature · 4 lines
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
maintainer Applied
#2 lore raw

From: Herbert Xu <[email protected]>
Date: Sat, 23 Dec 2006 08:04:46 +1100

Quoted 7 lines · Martin Willi
Quoted 4 lines

Installing an IPsec SA using old algorithm names (.compat) does not work if the algorithm is not already loaded. When not using the PF_KEY interface, algorithms are not preloaded in xfrm_probe_algs() and installing a IPsec SA fails.

Good catch. Thanks Martin!

Applied.

Martin, please be careful with future patch submissions, your email client corrupted up the patch by adding newlines and changing tab characters into spaces, so I had to add the patch by hand.

Herbert, this fix is only needed for 2.6.20 correct? I assume it was added by the 2.6.20 crypto layer merge, right?

Thanks.

maintainer
#3 lore raw
Quoted 3 lines · David Miller

Herbert, this fix is only needed for 2.6.20 correct? I assume it was added by the 2.6.20 crypto layer merge, right?

Yes that's correct.

Cheers,

Signature · 4 lines
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt