Skip to contentSkip to conversation

OpenAFS gatekeepers request addition of AFS_SUPER_MAGIC to magic.h

PATCH Adam Megacz 3 participants 4 messages Dec 30, 2006

lore
Share & tools
lore
#0 lore raw

Hello,

Jeffrey Altman, one of the gatekeepers of OpenAFS (the open source project which inherited the Transarc/IBM AFS codebase) has requested that the magic number 0x5346414F (little endian 'OAFS') be allocated for the f_type field of the fsinfo structure on Linux:

https://lists.openafs.org/pipermail/openafs-info/2006-December/024829.html

I would like to offer the patch below for inclusion in the source tree, if possible. The patch adds it to include/linux/magic.h, mostly as a way of publishing this number and ensuring that no other filesystem accidentally uses it.

- a

linux/magic.h 2006-11-29 13:57:37.000000000 -0800 renamed from linux/magic.h 2006-12-29 15:48:50.000000000 -0800 +0 -1
@@ -3,7 +3,6 @@
 
 #define ADFS_SUPER_MAGIC       0xadf5
 #define AFFS_SUPER_MAGIC       0xadff
-#define AFS_SUPER_MAGIC                0x5346414F
 #define AUTOFS_SUPER_MAGIC     0x0187
 #define CODA_SUPER_MAGIC       0x73757245
 #define EFS_SUPER_MAGIC                0x414A53
#1 lore raw

linux/magic.h 2006-11-29 13:57:37.000000000 -0800 line 8

Quoted 10 lines · * Adam Megacz ([email protected]) wrote:
linux/magic.h 2006-11-29 13:57:37.000000000 -0800 renamed from linux/magic.h 2006-12-29 15:48:50.000000000 -0800 +0 -1
@@ -3,7 +3,6 @@
 
 #define ADFS_SUPER_MAGIC       0xadf5
 #define AFFS_SUPER_MAGIC       0xadff
-#define AFS_SUPER_MAGIC                0x5346414F
 #define AUTOFS_SUPER_MAGIC     0x0187
 #define CODA_SUPER_MAGIC       0x73757245
 #define EFS_SUPER_MAGIC                0x414A53

Wouldn't you want a patch which *adds* it, rather than one which *removes* it...?

Thanks,

Stephen

#2 lore raw

Drat. Diffed in the wrong direction. Yes, you're right.

- a

Quoted 18 lines · Stephen Frost

linux/magic.h 2006-11-29 13:57:37.000000000 -0800 line 8

Quoted 10 lines · * Adam Megacz ([email protected]) wrote:
linux/magic.h 2006-11-29 13:57:37.000000000 -0800 renamed from linux/magic.h 2006-12-29 15:48:50.000000000 -0800 +0 -1
@@ -3,7 +3,6 @@
 
 #define ADFS_SUPER_MAGIC       0xadf5
 #define AFFS_SUPER_MAGIC       0xadff
-#define AFS_SUPER_MAGIC                0x5346414F
 #define AUTOFS_SUPER_MAGIC     0x0187
 #define CODA_SUPER_MAGIC       0x73757245
 #define EFS_SUPER_MAGIC                0x414A53

Wouldn't you want a patch which *adds* it, rather than one which *removes* it...?

Thanks,

Stephen

Signature · 1 line
PGP/GPG: 5C9F F366 C9CF 2145 E770  B1B8 EFB1 462D A146 C380
#3 lore raw
In reply to Adam Megacz
Quoted 8 lines · Adam Megacz

Hello,

Jeffrey Altman, one of the gatekeepers of OpenAFS (the open source project which inherited the Transarc/IBM AFS codebase) has requested that the magic number 0x5346414F (little endian 'OAFS') be allocated for the f_type field of the fsinfo structure on Linux:

Quoted 6 lines

https://lists.openafs.org/pipermail/openafs-info/2006-December/024829.html

I would like to offer the patch below for inclusion in the source tree, if possible. The patch adds it to include/linux/magic.h, mostly as a way of publishing this number and ensuring that no other filesystem accidentally uses it.

We're not allocating these number for any other out of teee junk like vxfs or gpfs either. So I'd say stay away.

p.s. and please stop that namedropping - beeing a 'gatekeeper' doesn't
make you any more important than just beeing yourself