Skip to contentSkip to conversation

fix for crash in adummy_init()

PATCH New Daniel Walker 1 participant 1 message Dec 30, 2006

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fix for crash in adummy_init()

This was reported by Ingo Molnar here,

http://lkml.org/lkml/2006/12/18/119

The problem is that adummy_init() depends on atm_init() , but adummy_init() is called first.

So I put atm_init() into subsys_initcall which seems appropriate, and it will still get module_init() if it becomes a module.

Interesting to note that you could crash your system here if you just load the modules in the wrong order.

---
 net/atm/common.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletion(-)
net/atm/common.c +2 -1
Index: linux-2.6.19/net/atm/common.c
===================================================================
@@ -816,7 +816,8 @@ static void __exit atm_exit(void)
 	proto_unregister(&vcc_proto);
 }
 
-module_init(atm_init);
+subsys_initcall(atm_init);
+
 module_exit(atm_exit);
 
 MODULE_LICENSE("GPL");

--