Skip to contentSkip to conversation

Use PATH_MAX constant for --bare.

PATCH In review Shawn O. Pearce 1 participant 1 message Jun 15, 2016

lore
Share & tools
lore
#0 lore raw

PATCH 1/4 Use PATH_MAX constant for --bare.

For easier portability we prefer PATH_MAX over seemingly random constants like 1024. Make it so.

---
 git.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
git.c +2 -2
index 50ebd86..ec897dc 100644
@@ -69,8 +69,8 @@ static int handle_options(const char*** argv, int* argc)
 		} else if (!strncmp(cmd, "--git-dir=", 10)) {
 			setenv("GIT_DIR", cmd + 10, 1);
 		} else if (!strcmp(cmd, "--bare")) {
-			static char git_dir[1024];
-			setenv("GIT_DIR", getcwd(git_dir, 1024), 1);
+			static char git_dir[PATH_MAX+1];
+			setenv("GIT_DIR", getcwd(git_dir, sizeof(git_dir)), 1);
 		} else {
 			fprintf(stderr, "Unknown option: %s\n", cmd);
 			usage(git_usage_string);
Signature · 1 line
1.5.0.rc0.g6bb1