Allow blktap to build as a module

PATCH In review John Byrne 4 participants 6 messages Jan 3, 2007

lore

Share & tools

lore

John Byrne

author

2007-01-03 00:58 UTC #0 lore raw

PATCH 1/1 Allow blktap to build as a module

The patch is against xen-unstable 13205:886f7312257e, but should also apply to 3.0.4.

Signed-off-by John Byrne <[email protected]>

linux-2.6-xen-sparse/drivers/xen/blktap/Makefile +4 -1

diff -r f80f1cc7f85e linux-2.6-xen-sparse/drivers/xen/blktap/Makefile
@@ -1,3 +1,6 @@ LINUXINCLUDE += -I../xen/include/public/
 LINUXINCLUDE += -I../xen/include/public/io
-obj-y	:= xenbus.o interface.o blktap.o 
 
+obj-$(CONFIG_XEN_BLKDEV_TAP) := blktp.o
+
+blktp-y	:= xenbus.o interface.o blktap.o 
+

_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xensource.com/xen-devel

Jan Beulich

2007-01-03 08:12 UTC #1 lore raw

I had posted a patch for this quite a while back (no clue why it wasn't picked up), though allowing the module to be more logically named blktap.ko. I'd really dislike to now have a blktp.ko. Jan

Quoted 1 line

Quoted 1 line
Quoted 1 line
John Byrne <[email protected]> 03.01.07 01:58 >>>

The patch is against xen-unstable 13205:886f7312257e, but should also apply to 3.0.4.

Signed-off-by John Byrne <[email protected]>

IIRC blktap doesn't straightforwardly build and work as a module. Some code cleanup is required (getting rid of zap_page_range()?). There's no point in taking the trivial Makefile fragment until that is fixed satisfactorily.

-- Keir

Quoted 19 lines · Jan Beulich

I had posted a patch for this quite a while back (no clue why it wasn't picked up),
though allowing the module to be more logically named blktap.ko. I'd really dislike to
now have a blktp.ko. Jan
Quoted 1 line
Quoted 1 line
Quoted 1 line
John Byrne <[email protected]> 03.01.07 01:58 >>>
The patch is against xen-unstable 13205:886f7312257e, but should also apply to 3.0.4.
Signed-off-by John Byrne <[email protected]>
_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xensource.com/xen-devel

Jan Beulich

2007-01-03 08:41 UTC #3 lore raw

Quoted 4 lines

Quoted 1 line
Quoted 1 line
Keir Fraser <[email protected]> 03.01.07 09:20 >>>
IIRC blktap doesn't straightforwardly build and work as a module. Some code cleanup is required (getting rid of zap_page_range()?). There's no point in taking the trivial Makefile fragment until that is fixed satisfactorily.

For the moment, we just leveraged the fact that in the SLE10 kernels zap_page_range() is being exported for other reasons. In 10.2, we added the export.

Jan

Daniel P. Berrange

2007-01-03 12:45 UTC #4 lore raw

Quoted 8 lines · Jan Beulich

Quoted 4 lines
Quoted 1 line
Quoted 1 line
Keir Fraser <[email protected]> 03.01.07 09:20 >>>
IIRC blktap doesn't straightforwardly build and work as a module. Some code cleanup is required (getting rid of zap_page_range()?). There's no point in taking the trivial Makefile fragment until that is fixed satisfactorily.
For the moment, we just leveraged the fact that in the SLE10 kernels zap_page_range() is being exported for other reasons. In 10.2, we added the export.

We did likewise for Fedora & RHEL - it was pretty trivial really to make it work as a module.

Regards,
Dan.

Signature · 4 lines

|=- Red Hat, Engineering, Emerging Technologies, Boston.  +1 978 392 2496 -=|
|=-           Perl modules: http://search.cpan.org/~danberr/              -=|
|=-               Projects: http://freshmeat.net/~danielpb/               -=|
|=-  GnuPG: 7D3B9505   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505  -=|

John Byrne

author

2007-01-03 18:15 UTC #5 lore raw

In reply to Keir Fraser

Quoted 5 lines · Keir Fraser

IIRC blktap doesn't straightforwardly build and work as a module. Some code cleanup is required (getting rid of zap_page_range()?). There's no point in taking the trivial Makefile fragment until that is fixed satisfactorily.
-- Keir

I thought I'd tested it. (You had me worried) zap_page_range() got exported in 12678:260426e3924f as part of the virtual frame buffer patch.

If Jan has a patch that doesn't change the name, that would be better. I didn't much like the name change, but I was being lazy.

John

Quoted 24 lines · Jan Beulich

Quoted 19 lines
I had posted a patch for this quite a while back (no clue why it wasn't picked up),
though allowing the module to be more logically named blktap.ko. I'd really dislike to
now have a blktp.ko. Jan
Quoted 1 line
Quoted 1 line
Quoted 1 line
John Byrne <[email protected]> 03.01.07 01:58 >>>
The patch is against xen-unstable 13205:886f7312257e, but should also apply to 3.0.4.
Signed-off-by John Byrne <[email protected]>
_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xensource.com/xen-devel