Skip to contentSkip to conversation

KVM: simplify mmu_alloc_roots()

PATCH Applied Ingo Molnar 2 participants 2 messages Jan 4, 2007 1 message not in the archive KVM

lore
Share & tools
lore

Ingo Molnar

author
#0 lore raw

PATCH 1/1 KVM: simplify mmu_alloc_roots()

Subject: [patch] KVM: simplify mmu_alloc_roots()
From: Ingo Molnar <[email protected]>

small optimization/cleanup:

page == page_header(page->page_hpa)

Signed-off-by Ingo Molnar <[email protected]>
---
 drivers/kvm/mmu.c |   12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)
drivers/kvm/mmu.c +6 -6
Index: linux/drivers/kvm/mmu.c
===================================================================
@@ -818,9 +818,9 @@ static void mmu_alloc_roots(struct kvm_v
 		hpa_t root = vcpu->mmu.root_hpa;
 
 		ASSERT(!VALID_PAGE(root));
-		root = kvm_mmu_get_page(vcpu, root_gfn, 0,
-					PT64_ROOT_LEVEL, 0, NULL)->page_hpa;
-		page = page_header(root);
+		page = kvm_mmu_get_page(vcpu, root_gfn, 0,
+					PT64_ROOT_LEVEL, 0, NULL);
+		root = page->page_hpa;
 		++page->root_count;
 		vcpu->mmu.root_hpa = root;
 		return;

@@ -834,10 +834,10 @@ static void mmu_alloc_roots(struct kvm_v
 			root_gfn = vcpu->pdptrs[i] >> PAGE_SHIFT;
 		else if (vcpu->mmu.root_level == 0)
 			root_gfn = 0;
-		root = kvm_mmu_get_page(vcpu, root_gfn, i << 30,
+		page = kvm_mmu_get_page(vcpu, root_gfn, i << 30,
 					PT32_ROOT_LEVEL, !is_paging(vcpu),
-					NULL)->page_hpa;
-		page = page_header(root);
+					NULL);
+		root = page->page_hpa;
 		++page->root_count;
 		vcpu->mmu.pae_root[i] = root | PT_PRESENT_MASK;
 	}

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV

A message that is not in the archive (sent off-list or not yet received): [email protected]

Applied
#2 lore raw
Quoted 8 lines · Ingo Molnar

Subject: [patch] KVM: simplify mmu_alloc_roots()
From: Ingo Molnar <[email protected]>

small optimization/cleanup:

page == page_header(page->page_hpa)

Applied, thanks.

Signature · 8 lines
error compiling committee.c: too many arguments to function


-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV