Skip to contentSkip to conversation

fix rpc.gssd -d

PATCH In review Steinar H. Gunderson 3 participants 6 messages Jan 4, 2007 – Feb 4, 2007

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fix rpc.gssd -d

Fix an off-by-one in the handling of the -d option to rpc.gssd; this makes the option usable again (it would complain that the string was too long). This patch is originally by Liam Bedford, and extracted from

https://bugs.launchpad.net/ubuntu/+source/nfs-utils/+bug/76409

utils/gssd/gssd.c +1 -1
@@ -118,7 +118,7 @@ main(int argc, char *argv[])
                                break;
                        case 'd':
                                strncpy(ccachedir, optarg, sizeof(ccachedir));
-                               if (ccachedir[sizeof(ccachedir-1)] != '\0')
+                               if (ccachedir[sizeof(ccachedir)-1] != '\0')
                                        errx(1, "ccachedir path name too long");
                                break;
                        default:

/* Steinar */

Signature · 10 lines
Homepage: http://www.sesse.net/

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
NFS maillist  -  [email protected]
https://lists.sourceforge.net/lists/listinfo/nfs
#1 lore raw

Thanks Steinar. I'll get to this and the AM_MAINTAINER_MODE patch soon and resend them to Neil. (Your other recent patches are out of my arena.)

K.C.

Quoted 22 lines · Steinar H. Gunderson

Fix an off-by-one in the handling of the -d option to rpc.gssd; this makes the option usable again (it would complain that the string was too long). This patch is originally by Liam Bedford, and extracted from

https://bugs.launchpad.net/ubuntu/+source/nfs-utils/+bug/76409

utils/gssd/gssd.c +1 -1
@@ -118,7 +118,7 @@ main(int argc, char *argv[])
                                break;
                        case 'd':
                                strncpy(ccachedir, optarg, sizeof(ccachedir));
-                               if (ccachedir[sizeof(ccachedir-1)] != '\0')
+                               if (ccachedir[sizeof(ccachedir)-1] != '\0')
                                        errx(1, "ccachedir path name too long");
                                break;
                        default:

/* Steinar */
--
Homepage: http://www.sesse.net/

Quoted 10 lines

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
NFS maillist - [email protected]
https://lists.sourceforge.net/lists/listinfo/nfs

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
NFS maillist - [email protected]
https://lists.sourceforge.net/lists/listinfo/nfs

#2 lore raw
Quoted 3 lines · Kevin Coffman

Thanks Steinar. I'll get to this and the AM_MAINTAINER_MODE patch soon and resend them to Neil. (Your other recent patches are out of my arena.)

Thanks.

By the way, I checked out the git repository (finding out the URL was non-trivial, though!) and discovered that the bzero patch was not applied (I believe it was sent in quite a while ago). Neil, did you forget, is it in a queue somewhere, or did I just check out the wrong one? (I used
git://git.linux-nfs.org/pub/linux/nfs-utils/.)

/* Steinar */

Signature · 10 lines
Homepage: http://www.sesse.net/

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
NFS maillist  -  [email protected]
https://lists.sourceforge.net/lists/listinfo/nfs
#3 lore raw
Quoted 5 lines · On Friday January 5, [email protected] wrote:
Quoted 3 lines · Kevin Coffman

Thanks Steinar. I'll get to this and the AM_MAINTAINER_MODE patch soon and resend them to Neil. (Your other recent patches are out of my arena.)

Quoted 7 lines

Thanks.

By the way, I checked out the git repository (finding out the URL was non-trivial, though!) and discovered that the bzero patch was not applied (I believe it was sent in quite a while ago). Neil, did you forget, is it in a queue somewhere, or did I just check out the wrong one? (I used
git://git.linux-nfs.org/pub/linux/nfs-utils/.)

git://linux-nfs.org/nfs-utils
should be enough

I don't remember a bzero patch. Is it just replacing the bzero in support/nfs/svc_socket.c with a memset ??

NeilBrown

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier. Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
NFS maillist - [email protected]
https://lists.sourceforge.net/lists/listinfo/nfs

#4 lore raw
Quoted 14 lines · On Monday February 5, [email protected] wrote:
Quoted 5 lines · On Friday January 5, [email protected] wrote:
Quoted 3 lines · Kevin Coffman

Thanks Steinar. I'll get to this and the AM_MAINTAINER_MODE patch soon and resend them to Neil. (Your other recent patches are out of my arena.)

Quoted 7 lines

Thanks.

By the way, I checked out the git repository (finding out the URL was non-trivial, though!) and discovered that the bzero patch was not applied (I believe it was sent in quite a while ago). Neil, did you forget, is it in a queue somewhere, or did I just check out the wrong one? (I used
git://git.linux-nfs.org/pub/linux/nfs-utils/.)

Quoted 5 lines

git://linux-nfs.org/nfs-utils
should be enough

I don't remember a bzero patch. Is it just replacing the bzero in support/nfs/svc_socket.c with a memset ??

It's OK, I found the patch in my mail and have applied it, thanks.

NeilBrown

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier. Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
NFS maillist - [email protected]
https://lists.sourceforge.net/lists/listinfo/nfs

#5 lore raw
In reply to Kevin Coffman
Quoted 3 lines · On Thursday January 4, [email protected] wrote:

Thanks Steinar. I'll get to this and the AM_MAINTAINER_MODE patch soon and resend them to Neil. (Your other recent patches are out of my arena.)

I've applied this patch as it is trivially correct. Thanks.
NeilBrown

Quoted 37 lines

K.C.

Quoted 22 lines · Steinar H. Gunderson

Fix an off-by-one in the handling of the -d option to rpc.gssd; this makes the option usable again (it would complain that the string was too long). This patch is originally by Liam Bedford, and extracted from

https://bugs.launchpad.net/ubuntu/+source/nfs-utils/+bug/76409

utils/gssd/gssd.c +1 -1
@@ -118,7 +118,7 @@ main(int argc, char *argv[])
                                break;
                        case 'd':
                                strncpy(ccachedir, optarg, sizeof(ccachedir));
-                               if (ccachedir[sizeof(ccachedir-1)] != '\0')
+                               if (ccachedir[sizeof(ccachedir)-1] != '\0')
                                        errx(1, "ccachedir path name too long");
                                break;
                        default:

/* Steinar */
--
Homepage: http://www.sesse.net/

Quoted 10 lines

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
NFS maillist - [email protected]
https://lists.sourceforge.net/lists/listinfo/nfs

Quoted 8 lines

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
NFS maillist - [email protected]
https://lists.sourceforge.net/lists/listinfo/nfs

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier. Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
NFS maillist - [email protected]
https://lists.sourceforge.net/lists/listinfo/nfs