Skip to contentSkip to conversation

SCSI seagate.c: remove SEAGATE_USE_ASM

PATCH New Adrian Bunk 1 participant 1 message Jan 6, 2007 SCSI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 SCSI seagate.c: remove SEAGATE_USE_ASM

Using assembler code for performance in drivers might have been a good idea 15 years ago when this code was written, but with today's compilers that's unlikely to be an advantage.

Besides this, it also hurts the readability.

Simply use the C code that was already there as an alternative.

---

 drivers/scsi/Makefile  |    2 
 drivers/scsi/seagate.c |  148 -----------------------------------------
 2 files changed, 1 insertion(+), 149 deletions(-)
drivers/scsi/Makefile renamed from drivers/scsi/Makefile.old +1 -1
@@ -16,7 +16,7 @@
 
 CFLAGS_aha152x.o =   -DAHA152X_STAT -DAUTOCONF
 CFLAGS_gdth.o    = # -DDEBUG_GDTH=2 -D__SERIAL__ -D__COM2__ -DGDTH_STATISTICS
-CFLAGS_seagate.o =   -DARBITRATE -DPARITY -DSEAGATE_USE_ASM
+CFLAGS_seagate.o =   -DARBITRATE -DPARITY
 
 subdir-$(CONFIG_PCMCIA)		+= pcmcia
 
drivers/scsi/seagate.c renamed from drivers/scsi/seagate.c.old +0 -148

204 lines not on this page · raw message