drop special case for ppc hosts
PATCH 1/1 drop special case for ppc hosts
for some reason there's a special case for ppc HOSTARCH's when setting up the default CROSS_COMPILE value ... this messes up my default env builds when going between my x86/amd64/ppc dev hosts ;)
attached patch simply drops this special case handling
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 827 bytes
Desc: not available
Url : http://lists.denx.de/pipermail/u-boot/attachments/20070108/aeeca40f/attachment.pgp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: u-boot-no-host-ppc-check.patch
Type: text/x-diff
Size: 426 bytes
Desc: not available
Url : http://lists.denx.de/pipermail/u-boot/attachments/20070108/aeeca40f/attachment.patch
PATCH 1/1 drop special case for ppc hosts
Dear Mike,
Quoted 4 lines · in message <[email protected]> you wrote:
for some reason there's a special case for ppc HOSTARCH's when setting up the default
CROSS_COMPILEvalue ... this messes up my default env builds when going between my x86/amd64/ppc dev hosts ;)
What exactly happens?
Quoted 1 line
ifndef
CROSS_COMPILE
... if CROSS_COMPILE is *NOT* set ...
Quoted 1 line
-ifeq ($(HOSTARCH),ppc)
... and you are on a PPC host ...
Quoted 1 line
-CROSS_COMPILE =
... then define CROSS_COMPILE as empty string,
i. e. use the native PPC compiler.
This looks ok to me.
Quoted 3 lines
-else
ifeq ($(ARCH),ppc)
CROSS_COMPILE= powerpc-linux-
With your patch applies, we would use powerpc-linux-gcc even if we are on a PPC host; this may be wanted (in which case you should have CROSS_COMPILE set when running make, and the "ifndef CROSS_COMPILE" will not apply), but usually you want to run the native tools.
So what is your problem?
Best regards,
Wolfgang Denk
Signature · 4 lines
Software Engineering: Embedded and Realtime Systems, Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Anyone who doesn't believe in miracles is not a realist.
- David Ben GurionPATCH 1/1 drop special case for ppc hosts
Quoted 6 lines · Wolfgang Denk
Quoted 3 lines · in message <[email protected]> you wrote:
for some reason there's a special case for ppc HOSTARCH's when setting up the default
CROSS_COMPILEvalue ... this messes up my default env builds when going between my x86/amd64/ppc dev hosts ;)What exactly happens?
on my ppc host, CROSS_COMPILE is set to "" by default
on my x86/amd64 host, CROSS_COMPILE is set to my target by default (bfin-uclinux- in my case)
Quoted 2 lines
... then define
CROSS_COMPILEas empty string,
i. e. use the native PPC compiler.
how does that make sense ? the logic is "if you are on a ppc host, then regardless of your target, use the native ppc compiler"
the logic on x86/amd64 is "if you are on a x86 host, then set the default CROSS_COMPILE based upon your target"
why should these two be different ?
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 827 bytes
Desc: not available
Url : http://lists.denx.de/pipermail/u-boot/attachments/20070108/984ee442/attachment.pgp
PATCH 1/1 drop special case for ppc hosts
Quoted 6 lines · In message <[email protected]> you wrote:
Quoted 3 lines
... then define
CROSS_COMPILEas empty string,
i. e. use the native PPC compiler.how does that make sense ? the logic is "if you are on a ppc host, then regardless of your target, use the native ppc compiler"
Argh.. of course you are right.
This is a remnant from the time when this was still called PPCBoot, i. e. when PPC was the only supported target architecture.
I think the test should be changed into
ifndef CROSS_COMPILE ifeq ($(HOSTARCH),$(ARCH)) CROSS_COMPILE = else ...
Then we can also drop the other special case, i. e. get rid of this:
ifeq ($(HOSTARCH),i386) CROSS_COMPILE = else
Does this work for you?
Best regards,
Wolfgang Denk
Signature · 3 lines
Software Engineering: Embedded and Realtime Systems, Embedded Linux Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Use C++ to confuse your enemies; use C to produce stable code.
PATCH 1/1 drop special case for ppc hosts
Quoted 8 lines · Wolfgang Denk
I think the test should be changed into
ifndef CROSS_COMPILE ifeq ($(HOSTARCH),$(ARCH)) CROSS_COMPILE = else ...Does this work for you?
yeah, that sounds great actually ... better than what i had in mind :) -mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 827 bytes
Desc: not available
Url : http://lists.denx.de/pipermail/u-boot/attachments/20070108/30d45aa6/attachment.pgp
PATCH 1/1 drop special case for ppc hosts
In reply to Wolfgang DenkQuoted 7 lines · Wolfgang Denk
I think the test should be changed into
ifndef CROSS_COMPILE ifeq ($(HOSTARCH),$(ARCH)) CROSS_COMPILE = else ...
patch attached to do this
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 827 bytes
Desc: not available
Url : http://lists.denx.de/pipermail/u-boot/attachments/20070306/27674c11/attachment.pgp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: u-boot-no-host-ppc-check.patch
Type: text/x-diff
Size: 545 bytes
Desc: not available
Url : http://lists.denx.de/pipermail/u-boot/attachments/20070306/27674c11/attachment.patch
Wolfgang Denk
AppliedPATCH 1/1 drop special case for ppc hosts
Quoted 10 lines · In message <[email protected]> you wrote:
Quoted 8 lines
I think the test should be changed into
ifndef CROSS_COMPILE ifeq ($(HOSTARCH),$(ARCH)) CROSS_COMPILE = else ...patch attached to do this
Thanks, applied.
Best regards,
Wolfgang Denk
Signature · 5 lines
DENX Software Engineering GmbH, HRB 165235 Munich, CEO: Wolfgang Denk Office: Kirchenstr. 5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Success in marriage is not so much finding the right person as it is being the right person.