Skip to contentSkip to conversation

Make noirqdebug_setup function non init to fix modpost warning

PATCH In review Vivek Goyal 1 participant 1 message Jan 8, 2007 IRQ

lore
Share & tools
lore
#0 lore raw

PATCH 4/4 Make noirqdebug_setup function non init to fix modpost warning

o noirqdebug_setup() is __init but it is being called by quirk_intel_irqbalance() which if of type __devinit. If CONFIG_HOTPLUG=y, quirk_intel_irqbalance() is put into text section and it is wrong to call a function in __init section.

o MODPOST flags this on i386 if CONFIG_RELOCATABLE=y

WARNING: vmlinux - Section mismatch: reference to .init.text:noirqdebug_setup from .text between 'quirk_intel_irqbalance' (at offset 0xc010969e) and 'i8237A_suspend'

o Make noirqdebug_setup() non-init.

---

 kernel/irq/spurious.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/irq/spurious.c renamed from kernel/irq/spurious.c~make-noirqdebug_setup-function-non-init +1 -1
diff -puN kernel/irq/spurious.c~make-noirqdebug_setup-function-non-init kernel/irq/spurious.c
@@ -176,7 +176,7 @@ void note_interrupt(unsigned int irq, st
 
 int noirqdebug __read_mostly;
 
-int __init noirqdebug_setup(char *str)
+int noirqdebug_setup(char *str)
 {
 	noirqdebug = 1;
 	printk(KERN_INFO "IRQ lockup detection disabled\n");

_