Skip to contentSkip to conversation

sata_sis: Support for PATA supports

PATCH Applied Alan 2 participants 4 messages Jan 8, 2007 – Jan 25, 2007 libata

lore
Share & tools
lore

Alan

author
#0 lore raw

PATCH 1/1 sata_sis: Support for PATA supports

This is quick rework of the patch Uwe proposed but using Kconfig not ifdefs and user selection to sort out PATA support. Instead of ifdefs and requiring the user to select both drivers the SATA driver selects the PATA one.

For neatness I've also moved the extern into the function that uses it.

Two questions really
1. Do you want the extern in a header file
2. Is this now neat enough to keep you happy Jeff or shall I do
the library split anyway ?

Please let me know so I can fire off new versions and try and get this one submitted for good today.

Signed-off-by Alan Cox
drivers/ata/Kconfig +6 -3
diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.20-rc3-mm1/drivers/ata/Kconfig linux-2.6.20-rc3-mm1/drivers/ata/Kconfig
@@ -112,11 +112,14 @@
 	  If unsure, say N.
 
 config SATA_SIS
-	tristate "SiS 964/180 SATA support"
+	tristate "SiS 964/965/966/180 SATA support"
 	depends on PCI
+	select PATA_SIS
 	help
-	  This option enables support for SiS Serial ATA 964/180.
-
+	  This option enables support for SiS Serial ATA on 
+	  SiS 964/965/966/180 and Parallel ATA on SiS 180.
+	  The PATA support for SiS 180 requires additionally to
+	  enable the PATA_SIS driver in the config.
 	  If unsure, say N.
 
 config SATA_ULI
drivers/ata/pata_sis.c +2 -0
diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.20-rc3-mm1/drivers/ata/pata_sis.c linux-2.6.20-rc3-mm1/drivers/ata/pata_sis.c
@@ -768,6 +768,8 @@
 	.port_ops	= &sis_133_early_ops,
 };
 
+/* Privately shared with the SiS180 SATA driver, not for use elsewhere */
+EXPORT_SYMBOL_GPL(sis_info133);
 
 static void sis_fixup(struct pci_dev *pdev, struct sis_chipset *sis)
 {
drivers/ata/sata_sis.c +25 -9
diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.20-rc3-mm1/drivers/ata/sata_sis.c linux-2.6.20-rc3-mm1/drivers/ata/sata_sis.c
@@ -138,22 +138,25 @@
 	.port_ops	= &sis_ops,
 };
 
-
 MODULE_AUTHOR("Uwe Koziolek");
 MODULE_DESCRIPTION("low-level driver for Silicon Integratad Systems SATA controller");
 MODULE_LICENSE("GPL");
 MODULE_DEVICE_TABLE(pci, sis_pci_tbl);
 MODULE_VERSION(DRV_VERSION);
 
-static unsigned int get_scr_cfg_addr(unsigned int port_no, unsigned int sc_reg, struct pci_dev *pdev)
+static unsigned int get_scr_cfg_addr(struct ata_port *ap, unsigned int sc_reg)
 {
+	struct pci_dev *pdev = to_pci_dev(ap->host->dev);
 	unsigned int addr = SIS_SCR_BASE + (4 * sc_reg);
+	u8 pmr;
 
-	if (port_no)  {
+	if (ap->port_no)  {
 		switch (pdev->device) {
 			case 0x0180:
 			case 0x0181:
-				addr += SIS180_SATA1_OFS;
+				pci_read_config_byte(pdev, SIS_PMR, &pmr);
+				if ((pmr & SIS_PMR_COMBINED) == 0)
+					addr += SIS180_SATA1_OFS;
 				break;
 
 			case 0x0182:

@@ -170,7 +173,7 @@
 static u32 sis_scr_cfg_read (struct ata_port *ap, unsigned int sc_reg)
 {
 	struct pci_dev *pdev = to_pci_dev(ap->host->dev);
-	unsigned int cfg_addr = get_scr_cfg_addr(ap->port_no, sc_reg, pdev);
+	unsigned int cfg_addr = get_scr_cfg_addr(ap, sc_reg);
 	u32 val, val2 = 0;
 	u8 pmr;
 

@@ -188,13 +191,13 @@
 	return (val|val2) &  0xfffffffb; /* avoid problems with powerdowned ports */
 }
 
-static void sis_scr_cfg_write (struct ata_port *ap, unsigned int scr, u32 val)
+static void sis_scr_cfg_write (struct ata_port *ap, unsigned int sc_reg, u32 val)
 {
 	struct pci_dev *pdev = to_pci_dev(ap->host->dev);
-	unsigned int cfg_addr = get_scr_cfg_addr(ap->port_no, scr, pdev);
+	unsigned int cfg_addr = get_scr_cfg_addr(ap, sc_reg);
 	u8 pmr;
 
-	if (scr == SCR_ERROR) /* doesn't exist in PCI cfg space */
+	if (sc_reg == SCR_ERROR) /* doesn't exist in PCI cfg space */
 		return;
 
 	pci_read_config_byte(pdev, SIS_PMR, &pmr);

@@ -251,6 +254,9 @@
 
 static int sis_init_one (struct pci_dev *pdev, const struct pci_device_id *ent)
 {
+	/* Provided by the PATA driver */
+	extern struct ata_port_info sis_info133;
+
 	static int printed_version;
 	struct ata_probe_ent *probe_ent = NULL;
 	int rc;

@@ -300,6 +306,17 @@
 	switch (ent->device) {
 	case 0x0180:
 	case 0x0181:
+
+		/* The PATA-handling is provided by pata_sis */
+		switch (pmr & 0x30) {
+		case 0x10:
+			ppi[1] = &sis_info133;
+			break;
+			
+		case 0x30:
+			ppi[0] = &sis_info133;
+			break;
+		}
 		if ((pmr & SIS_PMR_COMBINED) == 0) {
 			dev_printk(KERN_INFO, &pdev->dev,
 				   "Detected SiS 180/181/964 chipset in SATA mode\n");

@@ -379,4 +396,3 @@
 
 module_init(sis_init);
 module_exit(sis_exit);
-
#1 lore raw
Quoted 9 lines · Alan

This is quick rework of the patch Uwe proposed but using Kconfig not ifdefs and user selection to sort out PATA support. Instead of ifdefs and requiring the user to select both drivers the SATA driver selects the PATA one.

For neatness I've also moved the extern into the function that uses it.

Two questions really
1. Do you want the extern in a header file

not for an atom so small.

When I mentioned header files (if this was the genesis of your question), I intentionally referred to sata_promise.h as an example of sharing /code/ between two drivers.

Quoted 2 lines

2. Is this now neat enough to keep you happy Jeff or shall I do
the library split anyway ?

It's still ugly relying on an unused driver like this, but this [current] revision is clean enough that I'll go ahead and apply this patch.

Jeff

#2 lore raw
In reply to Alan
Quoted 12 lines · Alan

This is quick rework of the patch Uwe proposed but using Kconfig not ifdefs and user selection to sort out PATA support. Instead of ifdefs and requiring the user to select both drivers the SATA driver selects the PATA one.

For neatness I've also moved the extern into the function that uses it.

Two questions really
1. Do you want the extern in a header file
2. Is this now neat enough to keep you happy Jeff or shall I do
the library split anyway ?

Quoted 4 lines

Please let me know so I can fire off new versions and try and get this one submitted for good today.

Signed-off-by Alan Cox

I ACK this patch, as mentioned earlier, but the description and sign-off leave something to be desired.

Would you rather resend this patch without all the commentary, so that it may be automatically snarfed, or just resend a proper description and sign-off?

Note that (as stated in Documentation/SubmittingPatches) the standard way to include commentary is to include it after the patch description and "---" separator. Anything after "---" is automatically snipped.

This applies to patches sent to Linus, me, and anyone else who uses git to import patches. (as well as being the patch format standard)

Jeff

Applied
#3 lore raw
In reply to Alan
Quoted 12 lines · Alan

This is quick rework of the patch Uwe proposed but using Kconfig not ifdefs and user selection to sort out PATA support. Instead of ifdefs and requiring the user to select both drivers the SATA driver selects the PATA one.

For neatness I've also moved the extern into the function that uses it.

Two questions really
1. Do you want the extern in a header file
2. Is this now neat enough to keep you happy Jeff or shall I do
the library split anyway ?

Quoted 4 lines

Please let me know so I can fire off new versions and try and get this one submitted for good today.

Signed-off-by Alan Cox

applied