Skip to contentSkip to conversation

let BLK_DEV_AMD74XX depend on X86

PATCH NAK Adrian Bunk 4 participants 4 messages Jan 11, 2007 libata

lore
Share & tools
lore

Adrian Bunk

author
#0 lore raw

PATCH 1/1 let BLK_DEV_AMD74XX depend on X86

It's unlikely that this driver will ever be of any use on other architectures.

This fixes the following compile error on ia64:

<-- snip -->

...
CC drivers/ide/pci/amd74xx.o
/home/bunk/linux/kernel-2.6/linux-2.6.20-rc3-mm1/drivers/ide/pci/amd74xx.c: In function 'init_hwif_amd74xx':
/home/bunk/linux/kernel-2.6/linux-2.6.20-rc3-mm1/drivers/ide/pci/amd74xx.c:421: warning: implicit declaration of function 'pci_get_legacy_ide_irq'
CC drivers/ide/pci/cmd64x.o
...
LD .tmp_vmlinux1
drivers/built-in.o: In function `init_hwif_amd74xx':
/home/bunk/linux/kernel-2.6/linux-2.6.20-rc3-mm1/drivers/ide/pci/amd74xx.c:421: undefined reference to `pci_get_legacy_ide_irq' make[1]: *** [.tmp_vmlinux1] Error 1

<-- snip -->

This fixes kernel Bugzilla #6644.

Signed-off-by Adrian Bunk <[email protected]>
drivers/ide/Kconfig renamed from drivers/ide/Kconfig.old +1 -0
@@ -478,6 +478,7 @@
 
 config BLK_DEV_AMD74XX
 	tristate "AMD and nVidia IDE support"
+	depends on X86
 	help
 	  This driver adds explicit support for AMD-7xx and AMD-8111 chips
 	  and also for the nVidia nForce chip.  This allows the kernel to
NAK
#1 lore raw
Quoted 4 lines · On Thu, 11 Jan 2007 14:49:17 +0100 Adrian Bunk <[email protected]> wrote:

It's unlikely that this driver will ever be of any use on other architectures.

This fixes the following compile error on ia64:

NAK

pci_get_legacy_ide_irq() is a required method for all platforms and is usually filled in by asm-generic/pci.h

Please fix the IA64 tree to do the right thing.

Alan

#2 lore raw
Quoted 6 lines · Alan
Quoted 3 lines · On Thu, 11 Jan 2007 14:49:17 +0100 Adrian Bunk <[email protected]> wrote:

It's unlikely that this driver will ever be of any use on other architectures.

Quoted 8 lines
Quoted 1 line

This fixes the following compile error on ia64:

NAK

pci_get_legacy_ide_irq() is a required method for all platforms and is usually filled in by asm-generic/pci.h

Please fix the IA64 tree to do the right thing.

I've already sent a patch do do this...

http://lkml.org/lkml/2007/1/11/118

#3 lore raw
In reply to Adrian Bunk
Quoted 2 lines

It's unlikely that this driver will ever be of any use on other architectures.

It's already being used, for example, the AMD8111 is used one some PowerPC systems (some with IDE connected even).

Segher