audit: fix audit_filter_user_rules() initialization bug
PATCH 1/1 audit: fix audit_filter_user_rules() initialization bug
From: Ingo Molnar <[email protected]>
Subject: [patch] audit: fix audit_filter_user_rules() initialization bug
gcc emits this warning:
kernel/auditfilter.c: In function 'audit_filter_user':
kernel/auditfilter.c:1611: warning: 'state' is used uninitialized in this function
i tend to agree with gcc - there are a couple of plausible exit paths from audit_filter_user_rules() where it does not set 'state', keeping the variable uninitialized. For example if a filter rule has an AUDIT_POSSIBLE action. Initialize to 'wont audit'. Fix whitespace damage too.
Signed-off-by Ingo Molnar <[email protected]>
kernel/auditfilter.c +1 -1
@@ -1601,8 +1601,8 @@ static int audit_filter_user_rules(strucint audit_filter_user (struct netlink_skb_parms *cb,int type) { +enum audit_state state =AUDIT_DISABLED ;struct audit_entry *e; -enum audit_state state;int ret =1 ;rcu_read_lock ();