Skip to contentSkip to conversation

Removed incorrect IRDA_ASSERT()

PATCH Applied Samuel Ortiz 2 participants 2 messages Jan 15, 2007 – Jan 16, 2007 1 message not in the archive

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 2/2 Removed incorrect IRDA_ASSERT()

With USB2.0 bulk out MTU can be 512 bytes, so checking it only for 64 bytes is incorrect.

---
 drivers/net/irda/irda-usb.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
drivers/net/irda/irda-usb.c +0 -2
index 8381c04..a66aacf 100644
@@ -1515,8 +1515,6 @@ static inline int irda_usb_parse_endpoints(struct irda_usb_cb *self, struct usb_
 
 	IRDA_DEBUG(0, "%s(), And our endpoints are : in=%02X, out=%02X (%d), int=%02X\n",
 		__FUNCTION__, self->bulk_in_ep, self->bulk_out_ep, self->bulk_out_mtu, self->bulk_int_ep);
-	/* Should be 8, 16, 32 or 64 bytes */
-	IRDA_ASSERT(self->bulk_out_mtu == 64, ;);
 
 	return((self->bulk_in_ep != 0) && (self->bulk_out_ep != 0));
 }
Signature · 1 line
1.4.4.4

A message that is not in the archive (sent off-list or not yet received): [email protected]

Applied
#2 lore raw

From: Samuel Ortiz <[email protected]>
Date: Mon, 15 Jan 2007 11:15:42 +0200

Quoted 4 lines

With USB2.0 bulk out MTU can be 512 bytes, so checking it only for 64 bytes is incorrect.

Applied, thanks a lot.

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV