SCSI seagate.c: remove SEAGATE_USE_ASM
PATCH 1/1 SCSI seagate.c: remove SEAGATE_USE_ASM
Using assembler code for performance in drivers might have been a good idea 15 years ago when this code was written, but with today's compilers that's unlikely to be an advantage.
Besides this, it also hurts the readability.
Simply use the C code that was already there as an alternative.
---
This patch was already sent on:
- 6 Jan 2007
drivers/scsi/Makefile | 2 drivers/scsi/seagate.c | 148 ----------------------------------------- 2 files changed, 1 insertion(+), 149 deletions(-)
drivers/scsi/Makefile renamed from drivers/scsi/Makefile.old +1 -1
@@ -16,7 +16,7 @@ CFLAGS_aha152x.o = -DAHA152X_STAT -DAUTOCONF CFLAGS_gdth.o = # -DDEBUG_GDTH=2 -D__SERIAL__ -D__COM2__ -DGDTH_STATISTICS -CFLAGS_seagate.o = -DARBITRATE -DPARITY -DSEAGATE_USE_ASM +CFLAGS_seagate.o = -DARBITRATE -DPARITY subdir-$(CONFIG_PCMCIA) += pcmcia
drivers/scsi/seagate.c renamed from drivers/scsi/seagate.c.old +0 -148
204 lines not on this page · raw message
Alan
NAKQuoted 9 lines · On Sun, 21 Jan 2007 20:13:00 +0100 Adrian Bunk <[email protected]> wrote:
Using assembler code for performance in drivers might have been a good idea 15 years ago when this code was written, but with today's compilers that's unlikely to be an advantage.
Besides this, it also hurts the readability.
Simply use the C code that was already there as an alternative.
Signed-off-by Adrian Bunk <[email protected]>
"stosb\n\t"
NAK
The C codepaths are essentially untested on this driver.
Alan
Quoted 9 lines · Alan
Quoted 6 lines · On Sun, 21 Jan 2007 20:13:00 +0100 Adrian Bunk <[email protected]> wrote:
Using assembler code for performance in drivers might have been a good idea 15 years ago when this code was written, but with today's compilers that's unlikely to be an advantage.
Besides this, it also hurts the readability.
Quoted 8 lines
Quoted 3 lines
Simply use the C code that was already there as an alternative.
Signed-off-by Adrian Bunk <[email protected]>"stosb\n\t"NAK
The C codepaths are essentially untested on this driver.
Has any part of this driver ever be tested with kernel 2.6? Or compiled with gcc 4?
Quoted 1 line
Alan
cu
Adrian
Signature · 4 lines
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon SeedQuoted 4 lines
Quoted 1 line
The C codepaths are essentially untested on this driver.
Has any part of this driver ever be tested with kernel 2.6? Or compiled with gcc 4?
The C code paths have never been tested at all, the asm ones certainly worked in late 2.4, but I don't; have an ISA box any more.