Skip to contentSkip to conversation

echo3g_dsp.c shouldn't include #include <linux/irq.h>

PATCH In review Adrian Bunk 2 participants 3 messages Jan 23, 2007 Sound

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 echo3g_dsp.c shouldn't include #include <linux/irq.h>

Despite being under linux/, linux/irq.h shouldn't be #include'd by arch independent code.

sound/pci/echoaudio/echo3g_dsp.c renamed from sound/pci/echoaudio/echo3g_dsp.c.old +1 -1
@@ -39,7 +39,7 @@
 static int write_control_reg(struct echoaudio *chip, u32 ctl, u32 frq,
 			     char force);
 
-#include <linux/irq.h>
+#include <linux/interrupt.h>
 
 static int init_hw(struct echoaudio *chip, u16 device_id, u16 subdevice_id)
 {

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV

#1 lore raw

At Tue, 23 Jan 2007 16:17:56 +0100,

Quoted 5 lines · Adrian Bunk

Despite being under linux/, linux/irq.h shouldn't be #include'd by arch independent code.

Thanks, I applied to ALSA tree now.

Takashi

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV