UNIX reference time of 1970-01-01 00:00 is UTC timezone, not local time zone
PATCH 1/2 UNIX reference time of 1970-01-01 00:00 is UTC timezone, not local time zone
I got bitten because in the UK (where one would expect 1970-01-01 00:00 to be UTC 0) some politicians decided to mess around with daylight savings time from 1968 to 1971; it was permanently BST (+0100). That means that on my computer the following is true:
$ date --date="1970-01-01 00:00" +"%F %T %z (%Z)" 1970-01-01 00:00:00 +0100 (BST)
This of course means that the --date argument to date is specified in local time, not UTC. So when the hooks--update script does this:
date=$(date --date="1970-01-01 00:00:00 +0000 $ts seconds")
It's actually saying (in my timezone) "1970-01-01 01:00:00 UTC" + $ts. Clearly this is wrong. The UNIX epoch started at midnight UTC not 1am UTC.
This leads to the tagged time in hooks--update being shown as one hour earlier than the true tagged time (in my timezone). The problem would be worse for other timezones. For a +1300 timezone on 1970-01-01, the tagged time would be 13 hours earlier. Oops.
The solution is to force the reference time to UTC, which is what this patch does. In my timezone:
$ date --date="1970-01-01 00:00 +0000" +"%F %T %z (%Z)" 1970-01-01 01:00:00 +0100 (BST)
Much better.
--- templates/hooks--update | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
templates/hooks--update +1 -1
@@ -46,7 +46,7 @@ then if [ "$ref_type" = tag ]; then eval $(git cat-file tag $3 | \ sed -n '4s/tagger \([^>]*>\)[^0-9]*\([0-9]*\).*/tagger="\1" ts="\2"/p') - date=$(date --date="1970-01-01 00:00:00 $ts seconds" +"$date_format") + date=$(date --date="1970-01-01 00:00:00 +0000 $ts seconds" +"$date_format") echo "Tag '$tag' created by $tagger at $date" git cat-file tag $3 | sed -n '5,$p' echo
Signature · 1 line
1.5.0.rc2.g017f3
Quoted 4 lines · Andy Parkins
This of course means that the --date argument to date is specified in local time, not UTC. So when the hooks--update script does this:
date=$(date --date="1970-01-01 00:00:00 +0000 $ts seconds")
Bugger. This description is wrong. I've shown the fixed version not the original. This line should have read
date=$(date --date="1970-01-01 00:00:00 $ts seconds")
Sorry - patch was fine, message needs that change to make sense though.
Andy
Signature · 2 lines
Dr Andy Parkins, M Eng (hons), MIEE [email protected]
Quoted 2 lines · Andy Parkins
$ date --date="1970-01-01 00:00" +"%F %T %z (%Z)" 1970-01-01 00:00:00 +0100 (BST)
nice observation. yet, my system doesn't even have date --date=. regarding the idea to provide a generic nice hook, it should be considered to convert this usage to a standards-conforming way.
cheers
simon
Signature · 4 lines
Serve - BSD +++ RENT this banner advert +++ ASCII Ribbon /"\ Work - Mac +++ space for low €€€ NOW!1 +++ Campaign \ / Party Enjoy Relax | http://dragonflybsd.org Against HTML \ Dude 2c 2 the max ! http://golden-apple.biz Mail + News / \