Skip to contentSkip to conversation

use __u32 rather than u32 in userspace ioctls in usbdevice_fs.h

PATCH In review Mike Frysinger 2 participants 3 messages Jan 28, 2007

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 use __u32 rather than u32 in userspace ioctls in usbdevice_fs.h

the trivial attached patch fixes ioctl defines in usbdevice_fs.h that are exported to userspace to use __u32 rather than u32
-mike

Use __u32 rather than u32 in userspace ioctl defines.

include/linux/usbdevice_fs.h +2 -2
@@ -159,9 +159,9 @@ struct usbdevfs_ioctl32 {
 #define USBDEVFS_SUBMITURB32       _IOR('U', 10, struct usbdevfs_urb32)
 #define USBDEVFS_DISCARDURB        _IO('U', 11)
 #define USBDEVFS_REAPURB           _IOW('U', 12, void *)
-#define USBDEVFS_REAPURB32         _IOW('U', 12, u32)
+#define USBDEVFS_REAPURB32         _IOW('U', 12, __u32)
 #define USBDEVFS_REAPURBNDELAY     _IOW('U', 13, void *)
-#define USBDEVFS_REAPURBNDELAY32   _IOW('U', 13, u32)
+#define USBDEVFS_REAPURBNDELAY32   _IOW('U', 13, __u32)
 #define USBDEVFS_DISCSIGNAL        _IOR('U', 14, struct usbdevfs_disconnectsignal)
 #define USBDEVFS_CLAIMINTERFACE    _IOR('U', 15, unsigned int)
 #define USBDEVFS_RELEASEINTERFACE  _IOR('U', 16, unsigned int)
#1 lore raw
Quoted 2 lines · On Sun, 28 Jan 2007 07:23:57 -0500 Mike Frysinger wrote:

the trivial attached patch fixes ioctl defines in usbdevice_fs.h that are exported to userspace to use __u32 rather than u32

Hi Mike,

Have you now audited all ioctls (and sent patches) for this misbehavior?

---
~Randy

#2 lore raw
Quoted 1 line · Randy Dunlap

Have you now audited all ioctls (and sent patches) for this misbehavior?

my audit involved grepping the headers for '\<[us](8|16|32|64)\>' and sending patches for the headers that came up

ive sent patches for all except for asm-parisc/statfs.h ... but i'll do that shortly once i finish pulling the parisc git tree
-mike