Skip to contentSkip to conversation

cxgb3 - Remove BUG_ON from t3b_intr_napi

PATCH In review Divy Le Ray 1 participant 1 message Jan 31, 2007

Subsystems (2)
Networking Network drivers
lore
Share & tools
lore

Divy Le Ray

author
#0 lore raw

PATCH 7/10 cxgb3 - Remove BUG_ON from t3b_intr_napi

From: Divy Le Ray <[email protected]>

In some cases, SG_DATA_INTR won't clear on read and the following interrupt may cause us to assert because NAPI is already scheduled. Remove the assertion, NAPI can handle attempts to rearm it while it's already scheduled.

Signed-off-by Divy Le Ray <[email protected]>

---

 drivers/net/cxgb3/sge.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
drivers/net/cxgb3/sge.c +0 -2
index 8b3c824..daef7fd 100644
@@ -2199,14 +2199,12 @@ static irqreturn_t t3b_intr_napi(int irq
 	if (likely(map & 1)) {
 		dev = adap->sge.qs[0].netdev;
 
-		BUG_ON(napi_is_scheduled(dev));
 		if (likely(__netif_rx_schedule_prep(dev)))
 			__netif_rx_schedule(dev);
 	}
 	if (map & 2) {
 		dev = adap->sge.qs[1].netdev;
 
-		BUG_ON(napi_is_scheduled(dev));
 		if (likely(__netif_rx_schedule_prep(dev)))
 			__netif_rx_schedule(dev);
 	}