Skip to contentSkip to conversation

gpio-switch.c: use right flags for interrupts

PATCH In review Arnaud Patard (Rtp) 2 participants 2 messages Feb 1, 2007

Subsystems (2)
Arm (32-bit) Arm sub-architectures
lore
Share & tools
lore

Arnaud Patard (Rtp)

author
#0 lore raw

PATCH 1/1 gpio-switch.c: use right flags for interrupts

Hi,

The recent switch from SA_ to IRQF_ constants for interrupt flags introduced a typo in the gpio_switch driver (IRQF_SHIRQ doesn't exist but IRQF_SHARED does).

Signed-off-by Arnaud Patard <[email protected]>

---

---
arch/arm/plat-omap/gpio-switch.c | 2 1 + 1 - 0 !

 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/plat-omap/gpio-switch.c +1 -1
Index: linux-omap-2.6/arch/arm/plat-omap/gpio-switch.c
===================================================================
@@ -310,7 +310,7 @@ static int __init new_switch(struct gpio
 			trigger = IRQF_TRIGGER_RISING;
 	}
 	r = request_irq(OMAP_GPIO_IRQ(sw->gpio), gpio_sw_irq_handler,
-			IRQF_SHIRQ | trigger, sw->name, sw);
+			IRQF_SHARED | trigger, sw->name, sw);
 	if (r < 0) {
 		printk(KERN_ERR "gpio-switch: request_irq() failed "
 		       "for GPIO %d\n", sw->gpio);
#1 lore raw
Quoted 21 lines · Arnaud Patard

Hi,

The recent switch from SA_ to IRQF_ constants for interrupt flags introduced a typo in the gpio_switch driver (IRQF_SHIRQ doesn't exist but IRQF_SHARED does).

Signed-off-by Arnaud Patard <[email protected]>

---

---
arch/arm/plat-omap/gpio-switch.c | 2 1 + 1 - 0 !

 1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux-omap-2.6/arch/arm/plat-omap/gpio-switch.c
===================================================================

arch/arm/plat-omap/gpio-switch.c static int __init new_switch(struct gpio · line 316

Quoted 8 lines
arch/arm/plat-omap/gpio-switch.c +1 -1
@@ -310,7 +310,7 @@ static int __init new_switch(struct gpio
 			trigger = IRQF_TRIGGER_RISING;
 	}
 	r = request_irq(OMAP_GPIO_IRQ(sw->gpio), gpio_sw_irq_handler,
-			IRQF_SHIRQ | trigger, sw->name, sw);
+			IRQF_SHARED | trigger, sw->name, sw);
 	if (r < 0) {
 		printk(KERN_ERR "gpio-switch: request_irq() failed "
 		       "for GPIO %d\n", sw->gpio);

Pushing today, also adding to upstream queue.

Regards,

Tony