Skip to contentSkip to conversation

fix to documentation for kexec

PATCH In review Judith Lebzelter 6 participants 11 messages Feb 1, 2007 – Feb 7, 2007 Documentation

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fix to documentation for kexec

Hello,

I've noticed that the boot options are not correct for in the documentation for kdump. The "init" keyword is not necessary, and causes a kernel panic when booting with an initrd on Fedora 5.

Thanks;
Judith Lebzelter

---

---

Documentation/kdump/kdump.txt +3 -3
Index: linux/Documentation/kdump/kdump.txt
===================================================================
@@ -207,7 +207,7 @@ the following command:
 
    kexec -p <dump-capture-kernel> \
    --initrd=<initrd-for-dump-capture-kernel> --args-linux \
-   --append="root=<root-dev> init 1 irqpoll"
+   --append="root=<root-dev> 1 irqpoll"
 
 
 Notes on loading the dump-capture kernel:
@@ -228,8 +228,8 @@ Notes on loading the dump-capture kernel
 * You must specify <root-dev> in the format corresponding to the root
   device name in the output of mount command.
 
-* "init 1" boots the dump-capture kernel into single-user mode without
-  networking. If you want networking, use "init 3."
+* Boot parameter "1" boots the dump-capture kernel into single-user mode 
+  without networking. If you want networking, use "3".
 
 
 Kernel Panic
#1 lore raw
Quoted 29 lines · Judith Lebzelter

Hello,

I've noticed that the boot options are not correct for in the documentation for kdump. The "init" keyword is not necessary, and causes a kernel panic when booting with an initrd on Fedora 5.

Thanks;
Judith Lebzelter

---

---

Index: linux/Documentation/kdump/kdump.txt
===================================================================

Documentation/kdump/kdump.txt +1 -1
@@ -207,7 +207,7 @@ the following command:
 
    kexec -p <dump-capture-kernel> \
    --initrd=<initrd-for-dump-capture-kernel> --args-linux \
-   --append="root=<root-dev> init 1 irqpoll"
+   --append="root=<root-dev> 1 irqpoll"
 
 
 Notes on loading the dump-capture kernel:

Documentation/kdump/kdump.txt Notes on loading the dump-capture kernel · line 232

Quoted 7 lines
Documentation/kdump/kdump.txt +2 -2
@@ -228,8 +228,8 @@ Notes on loading the dump-capture kernel
 * You must specify <root-dev> in the format corresponding to the root
   device name in the output of mount command.
 
-* "init 1" boots the dump-capture kernel into single-user mode without
-  networking. If you want networking, use "init 3."
+* Boot parameter "1" boots the dump-capture kernel into single-user mode
+  without networking. If you want networking, use "3".

i'm not sure you want to totally remove those first two lines, they appear to talk about getting to run level 1 *from a running system*.

rday

Signature · 7 lines
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA

http://www.fsdev.dreamhosters.com/wiki/index.php?title=Main_Page
========================================================================
#2 lore raw
Quoted 34 lines · Robert P. J. Day
Quoted 32 lines · Judith Lebzelter

Hello,

I've noticed that the boot options are not correct for in the documentation for kdump. The "init" keyword is not necessary, and causes a kernel panic when booting with an initrd on Fedora 5.

Thanks;
Judith Lebzelter

---

---

Index: linux/Documentation/kdump/kdump.txt
===================================================================

Documentation/kdump/kdump.txt +1 -1
@@ -207,7 +207,7 @@ the following command:
 
    kexec -p <dump-capture-kernel> \
    --initrd=<initrd-for-dump-capture-kernel> --args-linux \
-   --append="root=<root-dev> init 1 irqpoll"
+   --append="root=<root-dev> 1 irqpoll"
 
 
 Notes on loading the dump-capture kernel:
@@ -228,8 +228,8 @@ Notes on loading the dump-capture kernel
 * You must specify <root-dev> in the format corresponding to the root
   device name in the output of mount command.
 
Quoted 7 lines

Documentation/kdump/kdump.txt Notes on loading the dump-capture kernel · line 232

Quoted 4 lines
Documentation/kdump/kdump.txt +2 -2
-* "init 1" boots the dump-capture kernel into single-user mode without
-  networking. If you want networking, use "init 3."
+* Boot parameter "1" boots the dump-capture kernel into single-user mode
+  without networking. If you want networking, use "3".

i'm not sure you want to totally remove those first two lines, they appear to talk about getting to run level 1 *from a running system*.

I think that it is refering to a kernel command line parameter, not a shell command executed on a running system, so I think the patch is correct in that respect.

Signature · 3 lines
Horms
  H: http://www.vergenet.net/~horms/
  W: http://www.valinux.co.jp/en/
#3 lore raw
Quoted 11 lines · Horms
Quoted 9 lines · Robert P. J. Day

Documentation/kdump/kdump.txt Notes on loading the dump-capture kernel · line 232

Quoted 5 lines · Judith Lebzelter
Documentation/kdump/kdump.txt +2 -2
-* "init 1" boots the dump-capture kernel into single-user mode without
-  networking. If you want networking, use "init 3."
+* Boot parameter "1" boots the dump-capture kernel into single-user mode
+  without networking. If you want networking, use "3".

i'm not sure you want to totally remove those first two lines, they appear to talk about getting to run level 1 *from a running system*.

Quoted 3 lines

I think that it is refering to a kernel command line parameter, not a shell command executed on a running system, so I think the patch is correct in that respect.

Agree with removing the "init" word. A single digit is assumed by the kernel to be the run level.

Also, given the variability of those values, leave the current documentation at levels 1 and 3.

BTW, the "init" keyword, *with* a value, specifies an alternate init process binary, e.g,, the default is "init=/sbin/init"

Signature · 2 lines
David N. Lombard, Intel, Irvine, CA
I do not speak for Intel Corporation; all comments are strictly my own.
#4 lore raw
In reply to Judith Lebzelter

Documentation/kdump/kdump.txt Notes on loading the dump-capture kernel · line 232

Quoted 9 lines
Documentation/kdump/kdump.txt +2 -2
@@ -228,8 +228,8 @@ Notes on loading the dump-capture kernel
 * You must specify <root-dev> in the format corresponding to the root
  device name in the output of mount command.
 
-* "init 1" boots the dump-capture kernel into single-user mode without
-  networking. If you want networking, use "init 3."
+* Boot parameter "1" boots the dump-capture kernel into single-user mode 
+  without networking. If you want networking, use "3".

Yup. More precisely, any arguments that could not be parsed (because the kernel does not know them) are handed down to the init program as arguments and/or environment variables.

Jan

Signature · 1 line
ft: http://freshmeat.net/p/chaostables/
#5 lore raw
Quoted 5 lines · Jan Engelhardt
Quoted 5 lines
Documentation/kdump/kdump.txt +0 -0
@@ -228,8 +228,8 @@ Notes on loading the dump-capture kernel
 * You must specify <root-dev> in the format corresponding to the root
  device name in the output of mount command.
 
Quoted 8 lines

Documentation/kdump/kdump.txt Notes on loading the dump-capture kernel · line 232

Quoted 4 lines
Documentation/kdump/kdump.txt +2 -2
-* "init 1" boots the dump-capture kernel into single-user mode without
-  networking. If you want networking, use "init 3."
+* Boot parameter "1" boots the dump-capture kernel into single-user mode
+  without networking. If you want networking, use "3".

Yup. More precisely, any arguments that could not be parsed (because the kernel does not know them) are handed down to the init program as arguments and/or environment variables.

whoops, ignore my last post, i misread the critical words.

rday

Signature · 7 lines
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA

http://www.fsdev.dreamhosters.com/wiki/index.php?title=Main_Page
========================================================================
#6 lore raw
Quoted 13 lines · Robert P. J. Day
Quoted 4 lines
Quoted 4 lines
Documentation/kdump/kdump.txt +0 -0
@@ -228,8 +228,8 @@ Notes on loading the dump-capture kernel
 * You must specify <root-dev> in the format corresponding to the root
  device name in the output of mount command.
 
Quoted 8 lines

Documentation/kdump/kdump.txt Notes on loading the dump-capture kernel · line 232

Quoted 4 lines
Documentation/kdump/kdump.txt +2 -2
-* "init 1" boots the dump-capture kernel into single-user mode without
-  networking. If you want networking, use "init 3."
+* Boot parameter "1" boots the dump-capture kernel into single-user mode
+  without networking. If you want networking, use "3".

Yup. More precisely, any arguments that could not be parsed (because the kernel does not know them) are handed down to the init program as arguments and/or environment variables.

Quoted 1 line

whoops, ignore my last post, i misread the critical words.

However, I am not sure how the kernel will handle this. Especially since:

* if you boot with no initramfs, init= is handled by your script (otherwise: kernel)

* does "init" qualify as a kernel param already? I don't think so, since the code indicates to be wanting "init=" at least.

Either way, the word "init" in the above doc is either (1) wrong or (2) superfluous [unless something strange happens to interpret it later, which I don't think]

Jan

Signature · 1 line
ft: http://freshmeat.net/p/chaostables/
#7 lore raw
Quoted 22 lines · Jan Engelhardt
Quoted 13 lines · Robert P. J. Day
Quoted 4 lines
Quoted 4 lines
Documentation/kdump/kdump.txt +0 -0
@@ -228,8 +228,8 @@ Notes on loading the dump-capture kernel
 * You must specify <root-dev> in the format corresponding to the root
  device name in the output of mount command.
 
Quoted 8 lines

Documentation/kdump/kdump.txt Notes on loading the dump-capture kernel · line 232

Quoted 4 lines
Documentation/kdump/kdump.txt +2 -2
-* "init 1" boots the dump-capture kernel into single-user mode without
-  networking. If you want networking, use "init 3."
+* Boot parameter "1" boots the dump-capture kernel into single-user mode
+  without networking. If you want networking, use "3".

Yup. More precisely, any arguments that could not be parsed (because the kernel does not know them) are handed down to the init program as arguments and/or environment variables.

Quoted 1 line

whoops, ignore my last post, i misread the critical words.

However, I am not sure how the kernel will handle this. Especially since:

* if you boot with no initramfs, init= is handled by your script (otherwise: kernel)

Quoted 6 lines

* does "init" qualify as a kernel param already? I don't think so, since the code indicates to be wanting "init=" at least.

Either way, the word "init" in the above doc is either (1) wrong or (2) superfluous [unless something strange happens to interpret it later, which I don't think]

Yes, it looks like "init=" is right, "init" is wrong.

I did notice that my patch is out of date for the latest kernel, however. I can send an up to date one.

Judith

Quoted 5 lines

Jan

Signature · 1 line
ft: http://freshmeat.net/p/chaostables/
#8 lore raw
Quoted 4 lines

I did notice that my patch is out of date for the latest kernel, however. I can send an up to date one.

This applies to 2.6.20-rc7

---

Stop recommending incorrect/superfluous "init" boot parameter.

Documentation/kdump/kdump.txt +4 -4
Index: linux-2.6.20-rc7/Documentation/kdump/kdump.txt
===================================================================
@@ -311,10 +311,10 @@ Following are the arch specific command 
 loading dump-capture kernel.
 
 For i386, x86_64 and ia64:
-	"init 1 irqpoll maxcpus=1"
+	"1 irqpoll maxcpus=1"
 
 For ppc64:
-	"init 1 maxcpus=1 noirqdistrib"
+	"1 maxcpus=1 noirqdistrib"
 
 
 Notes on loading the dump-capture kernel:
@@ -332,8 +332,8 @@ Notes on loading the dump-capture kernel
 * You must specify <root-dev> in the format corresponding to the root
   device name in the output of mount command.
 
-* "init 1" boots the dump-capture kernel into single-user mode without
-  networking. If you want networking, use "init 3."
+* Boot parameter "1" boots the dump-capture kernel into single-user 
+  mode without networking. If you want networking, use "3".
 
 * We generally don' have to bring up a SMP kernel just to capture the
   dump. Hence generally it is useful either to build a UP dump-capture
#9 lore raw
Quoted 11 lines · Judith Lebzelter
Quoted 4 lines

I did notice that my patch is out of date for the latest kernel, however. I can send an up to date one.

This applies to 2.6.20-rc7

---

Stop recommending incorrect/superfluous "init" boot parameter.

This looks good. The intention here is just to boot into run level 1, so that minimum scripts run in user space and probability of capturing the dump increases.

Fedora doc does say that appending "1" on command line will boot it into runlevel 1. I hope same is true for other distributions too.

Thanks
Vivek

Quoted 32 lines

Index: linux-2.6.20-rc7/Documentation/kdump/kdump.txt
===================================================================

Documentation/kdump/kdump.txt +4 -4
@@ -311,10 +311,10 @@ Following are the arch specific command 
 loading dump-capture kernel.
 
 For i386, x86_64 and ia64:
-	"init 1 irqpoll maxcpus=1"
+	"1 irqpoll maxcpus=1"
 
 For ppc64:
-	"init 1 maxcpus=1 noirqdistrib"
+	"1 maxcpus=1 noirqdistrib"
 
 
 Notes on loading the dump-capture kernel:
@@ -332,8 +332,8 @@ Notes on loading the dump-capture kernel
 * You must specify <root-dev> in the format corresponding to the root
   device name in the output of mount command.
 
-* "init 1" boots the dump-capture kernel into single-user mode without
-  networking. If you want networking, use "init 3."
+* Boot parameter "1" boots the dump-capture kernel into single-user 
+  mode without networking. If you want networking, use "3".
 
 * We generally don' have to bring up a SMP kernel just to capture the
   dump. Hence generally it is useful either to build a UP dump-capture

_______________________________________________
fastboot mailing list
[email protected]
https://lists.osdl.org/mailman/listinfo/fastboot

#10 lore raw

PATCH 1/1 kexec: fix references to init in documentation for kexe

Quoted 17 lines · Vivek Goyal
Quoted 11 lines · Judith Lebzelter
Quoted 4 lines

I did notice that my patch is out of date for the latest kernel, however. I can send an up to date one.

This applies to 2.6.20-rc7

---

Stop recommending incorrect/superfluous "init" boot parameter.

This looks good. The intention here is just to boot into run level 1, so that minimum scripts run in user space and probability of capturing the dump increases.

Quoted 5 lines

Fedora doc does say that appending "1" on command line will boot it into runlevel 1. I hope same is true for other distributions too.

Thanks
Vivek

This seems fine to me. Lets see if we can get it included.

Signature · 46 lines
Simon Horman (Horms)
  [email protected]
  http://verge.net.au/~horms/

kexec: fix references to init in documentation for kexec

I've noticed that the boot options are not correct for in
the documentation for kdump. The "init" keyword is not
necessary, and causes a kernel panic when booting with an
initrd on Fedora 5.

Signed-off-by: Judith Lebzeelter <[email protected]>
Acked-by: Vivek Goyal <[email protected]>

Put original comment with the latest version of the patch

Signed-off-by: Simon Horman <[email protected]>

Index: linux-2.6.20-rc7/Documentation/kdump/kdump.txt
===================================================================
--- linux-2.6.20-rc7.orig/Documentation/kdump/kdump.txt
+++ linux-2.6.20-rc7/Documentation/kdump/kdump.txt
@@ -311,10 +311,10 @@ Following are the arch specific command 
 loading dump-capture kernel.
 
 For i386, x86_64 and ia64:
-	"init 1 irqpoll maxcpus=1"
+	"1 irqpoll maxcpus=1"
 
 For ppc64:
-	"init 1 maxcpus=1 noirqdistrib"
+	"1 maxcpus=1 noirqdistrib"
 
 
 Notes on loading the dump-capture kernel:
@@ -332,8 +332,8 @@ Notes on loading the dump-capture kernel
 * You must specify <root-dev> in the format corresponding to the root
   device name in the output of mount command.
 
-* "init 1" boots the dump-capture kernel into single-user mode without
-  networking. If you want networking, use "init 3."
+* Boot parameter "1" boots the dump-capture kernel into single-user 
+  mode without networking. If you want networking, use "3".
 
 * We generally don' have to bring up a SMP kernel just to capture the
   dump. Hence generally it is useful either to build a UP dump-capture