Skip to contentSkip to conversation

mtd/cmdlinepart.c: remove static declaration of mtdpart_setup

PATCH In review Arnaud Patard (Rtp) 2 participants 2 messages Feb 1, 2007 Memory technology devices (MTD)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mtd/cmdlinepart.c: remove static declaration of mtdpart_setup

Hi,

The n770 (and maybe the n800 too) are using a tag for setting the mtd partition layout and not the command line. The commit in linus tree ddacff1f20fc5c96cc73e2975258e05d298c97cc is setting mtdpart_setup as static, preventing its use in the omap-hw driver and thus, is breaking the build.
So, here's a patch to revert it. imho we'll have to carry it in the omap tree until the omap-hw driver is merged.

---

Revert the following commit :

commit ddacff1f20fc5c96cc73e2975258e05d298c97cc

Author: Adrian Bunk <[email protected]>
Date:   Sat Nov 25 20:15:41 2006 +0100

[MTD] make drivers/mtd/cmdlinepart.c:mtdpart_setup() static

This patch makes the needlessly global mtdpart_setup() static.

Otherwise, the omap-hw can't work when the partition layout is in a TAG.
---
drivers/mtd/cmdlinepart.c | 2 1 + 1 - 0 !

 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mtd/cmdlinepart.c +1 -1
Index: linux-omap-2.6/drivers/mtd/cmdlinepart.c
===================================================================
@@ -345,7 +345,7 @@ static int parse_cmdline_partitions(stru
  *
  * This function needs to be visible for bootloaders.
  */
-static int mtdpart_setup(char *s)
+int mtdpart_setup(char *s)
 {
 	cmdline = s;
 	return 1;
#1 lore raw
Quoted 9 lines · Arnaud Patard

Hi,

The n770 (and maybe the n800 too) are using a tag for setting the mtd partition layout and not the command line. The commit in linus tree ddacff1f20fc5c96cc73e2975258e05d298c97cc is setting mtdpart_setup as static, preventing its use in the omap-hw driver and thus, is breaking the build.
So, here's a patch to revert it. imho we'll have to carry it in the omap tree until the omap-hw driver is merged.

Pushing today.

Regards,

Tony