v9fs_vfs_mkdir(): fix a double free
PATCH 1/1 v9fs_vfs_mkdir(): fix a double free
This patch fixes a double free of "dfid" introduced by commit da977b2c7eb4d6312f063a7b486f2aad99809710 and spotted by the Coverity checker.
Signed-off-by Adrian Bunk <[email protected]>
fs/9p/vfs_inode.c renamed from fs/9p/vfs_inode.c.old +2 -5
@@ -583,21 +583,18 @@ static int v9fs_vfs_mkdir(struct inode *v9fs_fid_clunk (v9ses, dfid); inode =v9fs_inode_from_fid (v9ses, vfid->fid, dir->i_sb);if (IS_ERR (inode)) { err =PTR_ERR (inode); inode =NULL ; - goto clean_up_fids; +v9fs_fid_destroy (vfid); + goto error; } dentry->d_op = &v9fs_dentry_operations;d_instantiate (dentry, inode);return 0 ; -clean_up_fids: -if (vfid) -v9fs_fid_destroy (vfid); - clean_up_dfid:v9fs_fid_clunk (v9ses, dfid); error:return err;