Skip to contentSkip to conversation

Three if-clauses of constant logic value; char drivers for kernel 2.4.33.3

DISCUSSION Mats Erik Andersson 2 participants 3 messages Dec 19, 2006 – Feb 3, 2007

lore
Share & tools
lore
#0 lore raw

Hi there, all masters of kernel code,

I just discovered that the kernel code for 2.4.33.3 contains three if-statements that never can change their values, whence they should be repaired or eliminated. In source directory linux/drivers/char the files vt.c and keyboard.c produce these warning upon compilation:

vt.c:166: varning: comparison is always false due to limited range
of data type
vt.c:289: varning: comparison is always false due to limited range
of data type
keyboard.c:640: varning: comparison is always true due to limited
range of data type

I did the compilation with gcc 3.3.5 on Debian Sarge. This behaviour appeared first for kernel 2.2.19, since I wanted to revive the old minirtl edition, but to my surprise the same warnings appear also with the brand new kernel 2.4.33.3.

Best regards
Mats Erik Andersson, PhD
[email protected]
[email protected]

#1 lore raw
Quoted 1 line · Mats Erik Andersson

Hi there, all masters of kernel code,

Hi !

Quoted 12 lines

I just discovered that the kernel code for 2.4.33.3 contains three if-statements that never can change their values, whence they should be repaired or eliminated. In source directory linux/drivers/char the files vt.c and keyboard.c produce these warning upon compilation:

vt.c:166: varning: comparison is always false due to limited range
of data type
vt.c:289: varning: comparison is always false due to limited range
of data type
keyboard.c:640: varning: comparison is always true due to limited
range of data type

Quoted 4 lines

I did the compilation with gcc 3.3.5 on Debian Sarge. This behaviour appeared first for kernel 2.2.19, since I wanted to revive the old minirtl edition, but to my surprise the same warnings appear also with the brand new kernel 2.4.33.3.

OK thanks for reporting this. I'll take a look at those before next release.

BTW, sorry, I missed your post. When posting 2.4-related mails, please try to put the "2.4" word close to the beginning of the subject so that my eyes can notice it in the middle of the 10000 other montly messages on LKML.

Quoted 4 lines

Best regards
Mats Erik Andersson, PhD
[email protected]
[email protected]

best regards,
Willy

#2 lore raw
In reply to Mats Erik Andersson

Hi Mats,

Quoted 14 lines · Mats Erik Andersson

Hi there, all masters of kernel code,

I just discovered that the kernel code for 2.4.33.3 contains three if-statements that never can change their values, whence they should be repaired or eliminated. In source directory linux/drivers/char the files vt.c and keyboard.c produce these warning upon compilation:

vt.c:166: varning: comparison is always false due to limited range
of data type
vt.c:289: varning: comparison is always false due to limited range
of data type
keyboard.c:640: varning: comparison is always true due to limited
range of data type

Quoted 4 lines

I did the compilation with gcc 3.3.5 on Debian Sarge. This behaviour appeared first for kernel 2.2.19, since I wanted to revive the old minirtl edition, but to my surprise the same warnings appear also with the brand new kernel 2.4.33.3.

I've looked at your warnings. They're all totally harmless, and caused by safety checks against some defines in those functions. While in 2.6, the two checks in vt.c have been removed, I can't be sure that nobody in 2.4 changes the defines (eg: embedded systems) in which case the checks would be totally valid.

So I will leave them. It may look annoying but it's a safe measure IMHO.

Best regards,
Willy