Pack the vfsmount and dentry in nameidata into a struct path
Subsystems (18)
RFC 1/1 Pack the vfsmount and dentry in nameidata into a struct path
While we store the (dentry, nameidata) in struct file as a struct path, we do not do so in struct nameidata at the moment. Here is a patch that changes that. The changes are syntactic only; gcc should generate identical code.
So what is this good for?
Well, we currently pass around (dentry, vfsmount) pairs in a number of places. With this change, these pairs of objects are embedded in a struct path for all file lookup oprations or open files. We could start passing around struct paths instead of (dentry, vfsmount) pairs, without having to construct temporary struct path objects. This could lead to nice code cleanups. The struct paths could be passed by value or by reference.
Opinions?
Thanks,
Andreas
include/linux/namei.h +6 -7
@@ -6,6 +6,11 @@struct vfsmount ; +struct path { +struct vfsmount *mnt; +struct dentry *dentry; +}; +struct open_intent {int flags;int create_mode;
@@ -15,8 +20,7 @@ struct open_intent {enum {MAX_NESTED_LINKS =8 };struct nameidata { -struct dentry *dentry; -struct vfsmount *mnt; +struct path path;struct qstr last;unsigned int flags;int last_type;
@@ -29,11 +33,6 @@ struct nameidata { } intent; }; -struct path { -struct vfsmount *mnt; -struct dentry *dentry; -}; -/* * Type of the last component on LOOKUP_PARENT */
drivers/md/dm-table.c +1 -1
@@ -356,7 +356,7 @@ static int lookup_device(const char *patif ((r =path_lookup (path,LOOKUP_FOLLOW , &nd)))return r; - inode = nd.dentry->d_inode; + inode = nd.path.dentry->d_inode;if (!inode) { r = -ENOENT ; goto out;
fs/afs/mntpt.c +7 -7
@@ -235,9 +235,9 @@ static void *afs_mntpt_follow_link(struckenter ("%p{%s},{%s:%p{%s}}" , dentry, dentry->d_name.name, - nd->mnt->mnt_devname, + nd->path.mnt->mnt_devname, dentry, - nd->dentry->d_name.name); + nd->path.dentry->d_name.name); newmnt =afs_mntpt_do_automount (dentry);if (IS_ERR (newmnt)) {
@@ -245,18 +245,18 @@ static void *afs_mntpt_follow_link(strucreturn (void *)newmnt; } - old_dentry = nd->dentry; - nd->dentry = dentry; + old_dentry = nd->path.dentry; + nd->path.dentry = dentry; err =do_add_mount (newmnt, nd,0 , &afs_vfsmounts); - nd->dentry = old_dentry; + nd->path.dentry = old_dentry;path_release (nd);if (!err) {mntget (newmnt); - nd->mnt = newmnt; + nd->path.mnt = newmnt;dget (newmnt->mnt_root); - nd->dentry = newmnt->mnt_root; + nd->path.dentry = newmnt->mnt_root; }kleave (" = %d" , err);
fs/autofs4/root.c +2 -1
@@ -369,7 +369,8 @@ static void *autofs4_follow_link(struct* so we don't need to follow the mount. */ if (d_mountpoint (dentry)) { -if (!autofs4_follow_mount (&nd->mnt, &nd->dentry)) { +if (!autofs4_follow_mount (&nd->path.mnt, + &nd->path.dentry)) { status = -ENOENT ; goto out_error; }
fs/block_dev.c +2 -2
@@ -1339,12 +1339,12 @@ struct block_device *lookup_bdev(const cif (error)return ERR_PTR (error); - inode = nd.dentry->d_inode; + inode = nd.path.dentry->d_inode; error = -ENOTBLK ;if (!S_ISBLK (inode->i_mode)) goto fail; error = -EACCES ; -if (nd.mnt->mnt_flags &MNT_NODEV ) +if (nd.path.mnt->mnt_flags &MNT_NODEV ) goto fail; error = -ENOMEM ; bdev =bd_acquire (inode);
fs/coda/pioctl.c +1 -1
@@ -75,7 +75,7 @@ static int coda_pioctl(struct inode * inif ( error ) {return error; }else { - target_inode = nd.dentry->d_inode; + target_inode = nd.path.dentry->d_inode; }/* return if it is not a Coda inode */
fs/configfs/symlink.c +2 -2
@@ -99,8 +99,8 @@ static int get_target(const char *symnam ret =path_lookup (symname,LOOKUP_FOLLOW |LOOKUP_DIRECTORY , nd);if (!ret) { -if (nd->dentry->d_sb == configfs_sb) { - *target =configfs_get_config_item (nd->dentry); +if (nd->path.dentry->d_sb == configfs_sb) { + *target =configfs_get_config_item (nd->path.dentry);if (!*target) { ret = -ENOENT ;path_release (nd);
fs/dquot.c +4 -3
@@ -1519,14 +1519,15 @@ int vfs_quota_on(struct super_block *sb, error =path_lookup (path,LOOKUP_FOLLOW , &nd);if (error <0 )return error; - error =security_quota_on (nd.dentry); + error =security_quota_on (nd.path.dentry);if (error) goto out_path;/* Quota file not on the same filesystem? */ -if (nd.mnt->mnt_sb != sb) +if (nd.path.mnt->mnt_sb != sb) error = -EXDEV ;else - error =vfs_quota_on_inode (nd.dentry->d_inode, type, format_id); + error =vfs_quota_on_inode (nd.path.dentry->d_inode, type, + format_id); out_path:path_release (&nd);return error;
fs/ecryptfs/dentry.c +6 -6
@@ -51,13 +51,13 @@ static int ecryptfs_d_revalidate(structif (!lower_dentry->d_op || !lower_dentry->d_op->d_revalidate) goto out; - dentry_save = nd->dentry; - vfsmount_save = nd->mnt; - nd->dentry = lower_dentry; - nd->mnt = lower_mnt; + dentry_save = nd->path.dentry; + vfsmount_save = nd->path.mnt; + nd->path.dentry = lower_dentry; + nd->path.mnt = lower_mnt; rc = lower_dentry->d_op->d_revalidate (lower_dentry, nd); - nd->dentry = dentry_save; - nd->mnt = vfsmount_save; + nd->path.dentry = dentry_save; + nd->path.mnt = vfsmount_save;if (dentry->d_inode) {struct inode *lower_inode =ecryptfs_inode_to_lower (dentry->d_inode);
fs/ecryptfs/inode.c +13 -13
@@ -77,13 +77,13 @@ ecryptfs_create_underlying_file(struct istruct vfsmount *vfsmount_save;int rc; - dentry_save = nd->dentry; - vfsmount_save = nd->mnt; - nd->dentry = lower_dentry; - nd->mnt = lower_mnt; + dentry_save = nd->path.dentry; + vfsmount_save = nd->path.mnt; + nd->path.dentry = lower_dentry; + nd->path.mnt = lower_mnt; rc =vfs_create (lower_dir_inode, lower_dentry, mode, nd); - nd->dentry = dentry_save; - nd->mnt = vfsmount_save; + nd->path.dentry = dentry_save; + nd->path.mnt = vfsmount_save;return rc; }
@@ -371,7 +371,7 @@ static struct dentry *ecryptfs_lookup(st goto out_dput; }memset (page_virt,0 ,PAGE_CACHE_SIZE ); - rc =ecryptfs_read_header_region (page_virt, lower_dentry, nd->mnt); + rc =ecryptfs_read_header_region (page_virt, lower_dentry, nd->path.mnt); crypt_stat = &ecryptfs_inode_to_private (dentry->d_inode)->crypt_stat;if (!ECRYPTFS_CHECK_FLAG (crypt_stat->flags,ECRYPTFS_POLICY_APPLIED ))ecryptfs_set_default_sizes (crypt_stat);
@@ -827,14 +827,14 @@ ecryptfs_permission(struct inode *inode,int rc;if (nd) { -struct vfsmount *vfsmnt_save = nd->mnt; -struct dentry *dentry_save = nd->dentry; +struct vfsmount *vfsmnt_save = nd->path.mnt; +struct dentry *dentry_save = nd->path.dentry; - nd->mnt =ecryptfs_dentry_to_lower_mnt (nd->dentry); - nd->dentry =ecryptfs_dentry_to_lower (nd->dentry); + nd->path.mnt =ecryptfs_dentry_to_lower_mnt (nd->path.dentry); + nd->path.dentry =ecryptfs_dentry_to_lower (nd->path.dentry); rc =permission (ecryptfs_inode_to_lower (inode), mask, nd); - nd->mnt = vfsmnt_save; - nd->dentry = dentry_save; + nd->path.mnt = vfsmnt_save; + nd->path.dentry = dentry_save; }else rc =permission (ecryptfs_inode_to_lower (inode), mask,NULL );return rc;
fs/ecryptfs/main.c +2 -2
@@ -441,14 +441,14 @@ static int ecryptfs_read_super(struct suecryptfs_printk (KERN_WARNING ,"path_lookup() failed\n" ); goto out_free; } - lower_root = nd.dentry; + lower_root = nd.path.dentry;if (!lower_root->d_inode) {ecryptfs_printk (KERN_WARNING ,"No directory to interpose on\n" ); rc = -ENOENT ; goto out_free; } - lower_mnt = nd.mnt; + lower_mnt = nd.path.mnt;ecryptfs_set_superblock_lower (sb, lower_root->d_sb); sb->s_maxbytes = lower_root->d_sb->s_maxbytes;ecryptfs_set_dentry_lower (sb->s_root, lower_root);
fs/exec.c +3 -3
@@ -133,7 +133,7 @@ asmlinkage long sys_uselib(const char __ goto out; error = -EINVAL ; -if (!S_ISREG (nd.dentry->d_inode->i_mode)) +if (!S_ISREG (nd.path.dentry->d_inode->i_mode)) goto exit; error =vfs_permission (&nd,MAY_READ |MAY_EXEC );
@@ -482,9 +482,9 @@ struct file *open_exec(const char *name) file =ERR_PTR (err);if (!err) { -struct inode *inode = nd.dentry->d_inode; +struct inode *inode = nd.path.dentry->d_inode; file =ERR_PTR (-EACCES ); -if (!(nd.mnt->mnt_flags &MNT_NOEXEC ) && +if (!(nd.path.mnt->mnt_flags &MNT_NOEXEC ) &&S_ISREG (inode->i_mode)) {int err =vfs_permission (&nd,MAY_EXEC ); file =ERR_PTR (err);
fs/ext3/super.c +2 -2
@@ -2601,12 +2601,12 @@ static int ext3_quota_on(struct super_blif (err)return err;/* Quotafile not on the same filesystem? */ -if (nd.mnt->mnt_sb != sb) { +if (nd.path.mnt->mnt_sb != sb) {path_release (&nd);return -EXDEV ; }/* Quotafile not of fs root? */ -if (nd.dentry->d_parent->d_inode != sb->s_root->d_inode) +if (nd.path.dentry->d_parent->d_inode != sb->s_root->d_inode)printk (KERN_WARNING "EXT3-fs: Quota file not on filesystem root. " "Journalled quota will not work.\n" );
fs/ext4/super.c +2 -2
@@ -2676,12 +2676,12 @@ static int ext4_quota_on(struct super_blif (err)return err;/* Quotafile not on the same filesystem? */ -if (nd.mnt->mnt_sb != sb) { +if (nd.path.mnt->mnt_sb != sb) {path_release (&nd);return -EXDEV ; }/* Quotafile not of fs root? */ -if (nd.dentry->d_parent->d_inode != sb->s_root->d_inode) +if (nd.path.dentry->d_parent->d_inode != sb->s_root->d_inode)printk (KERN_WARNING "EXT4-fs: Quota file not on filesystem root. " "Journalled quota will not work.\n" );
fs/gfs2/ops_fstype.c +2 -2
@@ -827,13 +827,13 @@ static struct super_block* get_gfs2_sb(c dev_name); goto out; } - error =vfs_getattr (nd.mnt, nd.dentry, &stat); + error =vfs_getattr (nd.path.mnt, nd.path.dentry, &stat); fstype =get_fs_type ("gfs2" );list_for_each (l, &fstype->fs_supers) { s = list_entry(l, struct super_block, s_instances);if ((S_ISBLK (stat.mode) && s->s_dev == stat.rdev) || - (S_ISDIR (stat.mode) && s == nd.dentry->d_inode->i_sb)) { + (S_ISDIR (stat.mode) && s == nd.path.dentry->d_inode->i_sb)) { sb = s; goto free_nd; }
fs/inotify_user.c +1 -1
@@ -631,7 +631,7 @@ asmlinkage long sys_inotify_add_watch(in goto fput_and_out;/* inode held in place by reference to nd; dev by fget on fd */ - inode = nd.dentry->d_inode; + inode = nd.path.dentry->d_inode; dev = filp->private_data;mutex_lock (&dev->up_mutex);
fs/jffs2/super.c +5 -5
@@ -248,29 +248,29 @@ static int jffs2_get_sb(struct file_syst err =path_lookup (dev_name,LOOKUP_FOLLOW , &nd);D1 (printk (KERN_DEBUG "jffs2_get_sb(): path_lookup() returned %d, inode %p\n" , - err, nd.dentry->d_inode)); + err, nd.path.dentry->d_inode));if (err)return err; err = -EINVAL ; -if (!S_ISBLK (nd.dentry->d_inode->i_mode)) +if (!S_ISBLK (nd.path.dentry->d_inode->i_mode)) goto out; -if (nd.mnt->mnt_flags &MNT_NODEV ) { +if (nd.path.mnt->mnt_flags &MNT_NODEV ) { err = -EACCES ; goto out; } -if (imajor (nd.dentry->d_inode) !=MTD_BLOCK_MAJOR ) { +if (imajor (nd.path.dentry->d_inode) !=MTD_BLOCK_MAJOR ) {if (!(flags &MS_SILENT ))printk (KERN_NOTICE "Attempt to mount non-MTD device \"%s\" as JFFS2\n" , dev_name); goto out; } - mtdnr =iminor (nd.dentry->d_inode); + mtdnr =iminor (nd.path.dentry->d_inode);path_release (&nd);return jffs2_get_sb_mtdnr (fs_type, flags, dev_name, data, mtdnr, mnt);
fs/namei.c +113 -105
568 lines not on this page · raw message
fs/namespace.c +91 -84
384 lines not on this page · raw message
fs/nfs/dir.c +1 -1
@@ -923,7 +923,7 @@ static struct dentry *nfs_lookup(struct res =ERR_PTR (error); goto out_unlock; } - error =nfs_reval_fsid (nd->mnt, dir, &fhandle, &fattr); + error =nfs_reval_fsid (nd->path.mnt, dir, &fhandle, &fattr);if (error <0 ) { res =ERR_PTR (error); goto out_unlock;
fs/nfs/namespace.c +15 -12
@@ -107,38 +107,40 @@ static void * nfs_follow_mountpoint(struBUG_ON (IS_ROOT (dentry));dprintk ("%s: enter\n" , __FUNCTION__); -dput (nd->dentry); - nd->dentry =dget (dentry); +dput (nd->path.dentry); + nd->path.dentry =dget (dentry);/* Look it up again */ - parent =dget_parent (nd->dentry); + parent =dget_parent (nd->path.dentry); err = server->nfs_client->rpc_ops->lookup (parent->d_inode, - &nd->dentry->d_name, + &nd->path.dentry->d_name, &fh, &fattr);dput (parent);if (err !=0 ) goto out_err;if (fattr.valid &NFS_ATTR_FATTR_V4_REFERRAL ) - mnt =nfs_do_refmount (nd->mnt, nd->dentry); + mnt =nfs_do_refmount (nd->path.mnt, nd->path.dentry);else - mnt =nfs_do_submount (nd->mnt, nd->dentry, &fh, &fattr); + mnt =nfs_do_submount (nd->path.mnt, nd->path.dentry, &fh, + &fattr); err =PTR_ERR (mnt);if (IS_ERR (mnt)) goto out_err;mntget (mnt); - err =do_add_mount (mnt, nd, nd->mnt->mnt_flags|MNT_SHRINKABLE , &nfs_automount_list); + err =do_add_mount (mnt, nd, nd->path.mnt->mnt_flags|MNT_SHRINKABLE , + &nfs_automount_list);if (err <0 ) {mntput (mnt);if (err == -EBUSY ) goto out_follow; goto out_err; } -mntput (nd->mnt); -dput (nd->dentry); - nd->mnt = mnt; - nd->dentry =dget (mnt->mnt_root); +mntput (nd->path.mnt); +dput (nd->path.dentry); + nd->path.mnt = mnt; + nd->path.dentry =dget (mnt->mnt_root);schedule_delayed_work (&nfs_automount_task, nfs_mountpoint_expiry_timeout); out:dprintk ("%s: done, returned %d\n" , __FUNCTION__, err);
@@ -149,7 +151,8 @@ out_err:path_release (nd); goto out; out_follow: -while (d_mountpoint (nd->dentry) &&follow_down (&nd->mnt, &nd->dentry)) +while (d_mountpoint (nd->path.dentry) && +follow_down (&nd->path.mnt, &nd->path.dentry)) ; err =0 ; goto out;
fs/nfsctl.c +5 -5
@@ -25,12 +25,12 @@ static struct file *do_open(char *name,struct nameidata nd;int error; - nd.mnt =do_kern_mount ("nfsd" ,0 ,"nfsd" ,NULL ); + nd.path.mnt =do_kern_mount ("nfsd" ,0 ,"nfsd" ,NULL ); -if (IS_ERR (nd.mnt)) -return (struct file *)nd.mnt; +if (IS_ERR (nd.path.mnt)) +return (struct file *)nd.path.mnt; - nd.dentry =dget (nd.mnt->mnt_root); + nd.path.dentry =dget (nd.path.mnt->mnt_root); nd.last_type =LAST_ROOT ; nd.flags =0 ; nd.depth =0 ;
@@ -45,7 +45,7 @@ static struct file *do_open(char *name, error =may_open (&nd,MAY_WRITE ,FMODE_WRITE );if (!error) -return dentry_open (nd.dentry, nd.mnt, flags); +return dentry_open (nd.path.dentry, nd.path.mnt, flags);path_release (&nd);return ERR_PTR (error);
fs/nfsd/export.c +18 -17
@@ -167,8 +167,8 @@ static int expkey_parse(struct cache_det goto out;dprintk ("Found the path %s\n" , buf); - key.ek_mnt = nd.mnt; - key.ek_dentry = nd.dentry; + key.ek_mnt = nd.path.mnt; + key.ek_dentry = nd.path.dentry; ek =svc_expkey_update (&key, ek);if (ek)
@@ -472,7 +472,7 @@ static int svc_export_parse(struct cachestruct svc_export exp, *expp;int an_int; - nd.dentry =NULL ; + nd.path.dentry =NULL ; exp.ex_path =NULL ;if (mesg[mlen-1 ] !='\n' )
@@ -502,8 +502,8 @@ static int svc_export_parse(struct cache exp.h.flags =0 ; exp.ex_client = dom; - exp.ex_mnt = nd.mnt; - exp.ex_dentry = nd.dentry; + exp.ex_mnt = nd.path.mnt; + exp.ex_dentry = nd.path.dentry; exp.ex_path =kstrdup (buf,GFP_KERNEL ); err = -ENOMEM ;if (!exp.ex_path)
@@ -543,7 +543,7 @@ static int svc_export_parse(struct cacheif (err) goto out; exp.ex_fsid = an_int; - err =check_export (nd.dentry->d_inode, exp.ex_flags); + err =check_export (nd.path.dentry->d_inode, exp.ex_flags);if (err) goto out; err =fsloc_parse (&mesg, buf, &exp.ex_fslocs);
@@ -563,7 +563,7 @@ static int svc_export_parse(struct cacheexp_put (expp); out:kfree (exp.ex_path); -if (nd.dentry) +if (nd.path.dentry)path_release (&nd); out_no_path:if (dom)
@@ -952,7 +952,7 @@ exp_export(struct nfsctl_export *nxp) goto out_unlock; err = -EINVAL ; - exp =exp_get_by_name (clp, nd.mnt, nd.dentry,NULL ); + exp =exp_get_by_name (clp, nd.path.mnt, nd.path.dentry,NULL );memset (&new,0 ,sizeof (new));
@@ -961,7 +961,8 @@ exp_export(struct nfsctl_export *nxp) (fsid_key =exp_get_fsid_key (clp, nxp->ex_dev)) && !IS_ERR (fsid_key) && fsid_key->ek_mnt && - (fsid_key->ek_mnt != nd.mnt || fsid_key->ek_dentry != nd.dentry) ) + (fsid_key->ek_mnt != nd.path.mnt || + fsid_key->ek_dentry != nd.path.dentry) ) goto finish;if (exp) {
@@ -977,7 +978,7 @@ exp_export(struct nfsctl_export *nxp) goto finish; } - err =check_export (nd.dentry->d_inode, nxp->ex_flags); + err =check_export (nd.path.dentry->d_inode, nxp->ex_flags);if (err) goto finish; err = -ENOMEM ;
@@ -990,8 +991,8 @@ exp_export(struct nfsctl_export *nxp)if (!new.ex_path) goto finish; new.ex_client = clp; - new.ex_mnt = nd.mnt; - new.ex_dentry = nd.dentry; + new.ex_mnt = nd.path.mnt; + new.ex_dentry = nd.path.dentry; new.ex_flags = nxp->ex_flags; new.ex_anon_uid = nxp->ex_anon_uid; new.ex_anon_gid = nxp->ex_anon_gid;
@@ -1071,7 +1072,7 @@ exp_unexport(struct nfsctl_export *nxp) goto out_domain; err = -EINVAL ; - exp =exp_get_by_name (dom, nd.mnt, nd.dentry,NULL ); + exp =exp_get_by_name (dom, nd.path.mnt, nd.path.dentry,NULL );path_release (&nd);if (!exp) goto out_domain;
@@ -1108,12 +1109,12 @@ exp_rootfh(svc_client *clp, char *path,printk ("nfsd: exp_rootfh path not found %s" , path);return err; } - inode = nd.dentry->d_inode; + inode = nd.path.dentry->d_inode;dprintk ("nfsd: exp_rootfh(%s [%p] %s:%s/%ld)\n" , - path, nd.dentry, clp->name, + path, nd.path.dentry, clp->name, inode->i_sb->s_id, inode->i_ino); - exp =exp_parent (clp, nd.mnt, nd.dentry,NULL ); + exp =exp_parent (clp, nd.path.mnt, nd.path.dentry,NULL );if (IS_ERR (exp)) { err =PTR_ERR (exp); goto out;
@@ -1127,7 +1128,7 @@ exp_rootfh(svc_client *clp, char *path,* fh must be initialized before calling fh_compose */ fh_init (&fh, maxsize); -if (fh_compose (&fh, exp, nd.dentry,NULL )) +if (fh_compose (&fh, exp, nd.path.dentry,NULL )) err = -EINVAL ;else err =0 ;
fs/nfsd/nfs4recover.c +16 -16
@@ -122,9 +122,9 @@ out_no_tfm:static void nfsd4_sync_rec_dir (void ) { -mutex_lock (&rec_dir.dentry->d_inode->i_mutex); -nfsd_sync_dir (rec_dir.dentry); -mutex_unlock (&rec_dir.dentry->d_inode->i_mutex); +mutex_lock (&rec_dir.path.dentry->d_inode->i_mutex); +nfsd_sync_dir (rec_dir.path.dentry); +mutex_unlock (&rec_dir.path.dentry->d_inode->i_mutex); }int
@@ -144,9 +144,9 @@ nfsd4_create_clid_dir(struct nfs4_clientnfs4_save_user (&uid, &gid);/* lock the parent */ -mutex_lock (&rec_dir.dentry->d_inode->i_mutex); +mutex_lock (&rec_dir.path.dentry->d_inode->i_mutex); - dentry =lookup_one_len (dname, rec_dir.dentry,HEXDIR_LEN -1 ); + dentry =lookup_one_len (dname, rec_dir.path.dentry,HEXDIR_LEN -1 );if (IS_ERR (dentry)) { status =PTR_ERR (dentry); goto out_unlock;
@@ -156,11 +156,11 @@ nfsd4_create_clid_dir(struct nfs4_clientdprintk ("NFSD: nfsd4_create_clid_dir: DIRECTORY EXISTS\n" ); goto out_put; } - status =vfs_mkdir (rec_dir.dentry->d_inode, dentry,S_IRWXU ); + status =vfs_mkdir (rec_dir.path.dentry->d_inode, dentry,S_IRWXU ); out_put:dput (dentry); out_unlock: -mutex_unlock (&rec_dir.dentry->d_inode->i_mutex); +mutex_unlock (&rec_dir.path.dentry->d_inode->i_mutex);if (status ==0 ) { clp->cl_firststate =1 ;nfsd4_sync_rec_dir ();
@@ -223,7 +223,7 @@ nfsd4_list_rec_dir(struct dentry *dir, rnfs4_save_user (&uid, &gid); - filp =dentry_open (dget (dir),mntget (rec_dir.mnt),O_RDONLY ); + filp =dentry_open (dget (dir),mntget (rec_dir.path.mnt),O_RDONLY ); status =PTR_ERR (filp);if (IS_ERR (filp)) goto out;
@@ -288,9 +288,9 @@ nfsd4_unlink_clid_dir(char *name, int nadprintk ("NFSD: nfsd4_unlink_clid_dir. name %.*s\n" , namlen, name); -mutex_lock (&rec_dir.dentry->d_inode->i_mutex); - dentry =lookup_one_len (name, rec_dir.dentry, namlen); -mutex_unlock (&rec_dir.dentry->d_inode->i_mutex); +mutex_lock (&rec_dir.path.dentry->d_inode->i_mutex); + dentry =lookup_one_len (name, rec_dir.path.dentry, namlen); +mutex_unlock (&rec_dir.path.dentry->d_inode->i_mutex);if (IS_ERR (dentry)) { status =PTR_ERR (dentry);return status;
@@ -299,7 +299,7 @@ nfsd4_unlink_clid_dir(char *name, int naif (!dentry->d_inode) goto out; - status =nfsd4_clear_clid_dir (rec_dir.dentry, dentry); + status =nfsd4_clear_clid_dir (rec_dir.path.dentry, dentry); out:dput (dentry);return status;
@@ -349,12 +349,12 @@ nfsd4_recdir_purge_old(void) {if (!rec_dir_init)return ; - status =nfsd4_list_rec_dir (rec_dir.dentry, purge_old); + status =nfsd4_list_rec_dir (rec_dir.path.dentry, purge_old);if (status ==0 )nfsd4_sync_rec_dir ();if (status)printk ("nfsd4: failed to purge old clients from recovery" -" directory %s\n" , rec_dir.dentry->d_name.name); +" directory %s\n" , rec_dir.path.dentry->d_name.name);return ; }
@@ -375,10 +375,10 @@ intnfsd4_recdir_load (void) {int status; - status =nfsd4_list_rec_dir (rec_dir.dentry, load_recdir); + status =nfsd4_list_rec_dir (rec_dir.path.dentry, load_recdir);if (status)printk ("nfsd4: failed loading clients from recovery" -" directory %s\n" , rec_dir.dentry->d_name.name); +" directory %s\n" , rec_dir.path.dentry->d_name.name);return status; }
fs/nfsd/nfs4state.c +1 -1
@@ -3299,7 +3299,7 @@ nfs4_reset_recoverydir(char *recdir)if (status)return status; status = -ENOTDIR ; -if (S_ISDIR (nd.dentry->d_inode->i_mode)) { +if (S_ISDIR (nd.path.dentry->d_inode->i_mode)) {nfs4_set_recdir (recdir); status =0 ; }
fs/open.c +16 -15
@@ -127,7 +127,7 @@ asmlinkage long sys_statfs(const char __ error =user_path_walk (path, &nd);if (!error) {struct statfs tmp; - error =vfs_statfs_native (nd.dentry, &tmp); + error =vfs_statfs_native (nd.path.dentry, &tmp);if (!error &©_to_user (buf, &tmp,sizeof (tmp))) error = -EFAULT ;path_release (&nd);
@@ -146,7 +146,7 @@ asmlinkage long sys_statfs64(const char error =user_path_walk (path, &nd);if (!error) {struct statfs64 tmp; - error =vfs_statfs64 (nd.dentry, &tmp); + error =vfs_statfs64 (nd.path.dentry, &tmp);if (!error &©_to_user (buf, &tmp,sizeof (tmp))) error = -EFAULT ;path_release (&nd);
@@ -230,7 +230,7 @@ static long do_sys_truncate(const char _ error =user_path_walk (path, &nd);if (error) goto out; - inode = nd.dentry->d_inode; + inode = nd.path.dentry->d_inode;/* For directories it's -EISDIR, for other non-regulars - -EINVAL */ error = -EISDIR ;
@@ -267,7 +267,7 @@ static long do_sys_truncate(const char _ error =locks_verify_truncate (inode,NULL , length);if (!error) {DQUOT_INIT (inode); - error =do_truncate (nd.dentry, length,0 ,NULL ); + error =do_truncate (nd.path.dentry, length,0 ,NULL ); }put_write_access (inode);
@@ -392,10 +392,10 @@ asmlinkage long sys_faccessat(int dfd, c res =vfs_permission (&nd, mode);/* SuS v2 requires we report a read only fs too */ if (res || !(mode &S_IWOTH ) || -special_file (nd.dentry->d_inode->i_mode)) +special_file (nd.path.dentry->d_inode->i_mode)) goto out_path_release; -if (IS_RDONLY (nd.dentry->d_inode)) +if (IS_RDONLY (nd.path.dentry->d_inode)) res = -EROFS ; out_path_release:
@@ -427,7 +427,7 @@ asmlinkage long sys_chdir(const char __uif (error) goto dput_and_out; -set_fs_pwd (current->fs, nd.mnt, nd.dentry); +set_fs_pwd (current->fs, nd.path.mnt, nd.path.dentry); dput_and_out:path_release (&nd);
@@ -482,7 +482,7 @@ asmlinkage long sys_chroot(const char __if (!capable (CAP_SYS_CHROOT )) goto dput_and_out; -set_fs_root (current->fs, nd.mnt, nd.dentry); +set_fs_root (current->fs, nd.path.mnt, nd.path.dentry);set_fs_altroot (); error =0 ; dput_and_out:
@@ -539,7 +539,7 @@ asmlinkage long sys_fchmodat(int dfd, co error =__user_walk_fd (dfd, filename,LOOKUP_FOLLOW , &nd);if (error) goto out; - inode = nd.dentry->d_inode; + inode = nd.path.dentry->d_inode; error = -EROFS ;if (IS_RDONLY (inode))
@@ -554,7 +554,7 @@ asmlinkage long sys_fchmodat(int dfd, co mode = inode->i_mode; newattrs.ia_mode = (mode &S_IALLUGO ) | (inode->i_mode & ~S_IALLUGO ); newattrs.ia_valid =ATTR_MODE |ATTR_CTIME ; - error =notify_change (nd.dentry, &newattrs); + error =notify_change (nd.path.dentry, &newattrs);mutex_unlock (&inode->i_mutex); dput_and_out:
@@ -611,7 +611,7 @@ asmlinkage long sys_chown(const char __u error =user_path_walk (filename, &nd);if (error) goto out; - error =chown_common (nd.dentry, user, group); + error =chown_common (nd.path.dentry, user, group);path_release (&nd); out:return error;
@@ -631,7 +631,7 @@ asmlinkage long sys_fchownat(int dfd, co error =__user_walk_fd (dfd, filename, follow, &nd);if (error) goto out; - error =chown_common (nd.dentry, user, group); + error =chown_common (nd.path.dentry, user, group);path_release (&nd); out:return error;
@@ -645,7 +645,7 @@ asmlinkage long sys_lchown(const char __ error =user_path_walk_link (filename, &nd);if (error) goto out; - error =chown_common (nd.dentry, user, group); + error =chown_common (nd.path.dentry, user, group);path_release (&nd); out:return error;
@@ -795,7 +795,7 @@ struct file *lookup_instantiate_filp(str goto out;if (IS_ERR (dentry)) goto out_err; - nd->intent.open.file =__dentry_open (dget (dentry),mntget (nd->mnt), + nd->intent.open.file =__dentry_open (dget (dentry),mntget (nd->path.mnt), nd->intent.open.flags -1 , nd->intent.open.file, open);
@@ -823,7 +823,8 @@ struct file *nameidata_to_filp(struct na filp = nd->intent.open.file;/* Has the filesystem initialised the file for us? */ if (filp->f_path.dentry ==NULL ) - filp =__dentry_open (nd->dentry, nd->mnt, flags, filp,NULL ); + filp =__dentry_open (nd->path.dentry, nd->path.mnt, flags, filp, +NULL );else path_release (nd);return filp;
fs/proc/base.c +2 -1
@@ -926,7 +926,8 @@ static void *proc_pid_follow_link(structif (!proc_fd_access_allowed (inode)) goto out; - error =PROC_I (inode)->op.proc_get_link (inode, &nd->dentry, &nd->mnt); + error =PROC_I (inode)->op.proc_get_link (inode, &nd->path.dentry, + &nd->path.mnt); nd->last_type =LAST_BIND ; out:return ERR_PTR (error);
fs/reiserfs/super.c +3 -3
@@ -1983,12 +1983,12 @@ static int reiserfs_quota_on(struct supeif (err)return err;/* Quotafile not on the same filesystem? */ -if (nd.mnt->mnt_sb != sb) { +if (nd.path.mnt->mnt_sb != sb) {path_release (&nd);return -EXDEV ; }/* We must not pack tails for quota files on reiserfs for quota IO to work */ -if (!REISERFS_I (nd.dentry->d_inode)->i_flags & i_nopack_mask) { +if (!REISERFS_I (nd.path.dentry->d_inode)->i_flags & i_nopack_mask) {reiserfs_warning (sb,"reiserfs: Quota file must have tail packing disabled." );path_release (&nd);
@@ -2001,7 +2001,7 @@ static int reiserfs_quota_on(struct supereturn vfs_quota_on (sb, type, format_id, path); }/* Quotafile not of fs root? */ -if (nd.dentry->d_parent->d_inode != sb->s_root->d_inode) +if (nd.path.dentry->d_parent->d_inode != sb->s_root->d_inode)reiserfs_warning (sb,"reiserfs: Quota file not on filesystem root. " "Journalled quota will not work." );
fs/stat.c +7 -6
@@ -63,7 +63,7 @@ int vfs_stat_fd(int dfd, char __user *na error =__user_walk_fd (dfd, name,LOOKUP_FOLLOW , &nd);if (!error) { - error =vfs_getattr (nd.mnt, nd.dentry, stat); + error =vfs_getattr (nd.path.mnt, nd.path.dentry, stat);path_release (&nd); }return error;
@@ -83,7 +83,7 @@ int vfs_lstat_fd(int dfd, char __user *n error =__user_walk_fd (dfd, name,0 , &nd);if (!error) { - error =vfs_getattr (nd.mnt, nd.dentry, stat); + error =vfs_getattr (nd.path.mnt, nd.path.dentry, stat);path_release (&nd); }return error;
@@ -303,14 +303,15 @@ asmlinkage long sys_readlinkat(int dfd, error =__user_walk_fd (dfd, path,0 , &nd);if (!error) { -struct inode * inode = nd.dentry->d_inode; +struct inode * inode = nd.path.dentry->d_inode; error = -EINVAL ;if (inode->i_op && inode->i_op->readlink) { - error =security_inode_readlink (nd.dentry); + error =security_inode_readlink (nd.path.dentry);if (!error) { -touch_atime (nd.mnt, nd.dentry); - error = inode->i_op->readlink (nd.dentry, buf, bufsiz); +touch_atime (nd.path.mnt, nd.path.dentry); + error = inode->i_op->readlink (nd.path.dentry, + buf, bufsiz); } }path_release (&nd);
fs/utimes.c +4 -4
@@ -30,7 +30,7 @@ asmlinkage long sys_utime(char __user * error =user_path_walk (filename, &nd);if (error) goto out; - inode = nd.dentry->d_inode; + inode = nd.path.dentry->d_inode; error = -EROFS ;if (IS_RDONLY (inode))
@@ -62,7 +62,7 @@ asmlinkage long sys_utime(char __user * goto dput_and_out; }mutex_lock (&inode->i_mutex); - error =notify_change (nd.dentry, &newattrs); + error =notify_change (nd.path.dentry, &newattrs);mutex_unlock (&inode->i_mutex); dput_and_out:path_release (&nd);
@@ -87,7 +87,7 @@ long do_utimes(int dfd, char __user *filif (error) goto out; - inode = nd.dentry->d_inode; + inode = nd.path.dentry->d_inode; error = -EROFS ;if (IS_RDONLY (inode))
@@ -115,7 +115,7 @@ long do_utimes(int dfd, char __user *fil goto dput_and_out; }mutex_lock (&inode->i_mutex); - error =notify_change (nd.dentry, &newattrs); + error =notify_change (nd.path.dentry, &newattrs);mutex_unlock (&inode->i_mutex); dput_and_out:path_release (&nd);
fs/xattr.c +8 -8
@@ -237,7 +237,7 @@ sys_setxattr(char __user *path, char __u error =user_path_walk (path, &nd);if (error)return error; - error =setxattr (nd.dentry, name, value, size, flags); + error =setxattr (nd.path.dentry, name, value, size, flags);path_release (&nd);return error; }
@@ -252,7 +252,7 @@ sys_lsetxattr(char __user *path, char __ error =user_path_walk_link (path, &nd);if (error)return error; - error =setxattr (nd.dentry, name, value, size, flags); + error =setxattr (nd.path.dentry, name, value, size, flags);path_release (&nd);return error; }
@@ -322,7 +322,7 @@ sys_getxattr(char __user *path, char __u error =user_path_walk (path, &nd);if (error)return error; - error =getxattr (nd.dentry, name, value, size); + error =getxattr (nd.path.dentry, name, value, size);path_release (&nd);return error; }
@@ -337,7 +337,7 @@ sys_lgetxattr(char __user *path, char __ error =user_path_walk_link (path, &nd);if (error)return error; - error =getxattr (nd.dentry, name, value, size); + error =getxattr (nd.path.dentry, name, value, size);path_release (&nd);return error; }
@@ -395,7 +395,7 @@ sys_listxattr(char __user *path, char __ error =user_path_walk (path, &nd);if (error)return error; - error =listxattr (nd.dentry, list, size); + error =listxattr (nd.path.dentry, list, size);path_release (&nd);return error; }
@@ -409,7 +409,7 @@ sys_llistxattr(char __user *path, char _ error =user_path_walk_link (path, &nd);if (error)return error; - error =listxattr (nd.dentry, list, size); + error =listxattr (nd.path.dentry, list, size);path_release (&nd);return error; }
@@ -455,7 +455,7 @@ sys_removexattr(char __user *path, char error =user_path_walk (path, &nd);if (error)return error; - error =removexattr (nd.dentry, name); + error =removexattr (nd.path.dentry, name);path_release (&nd);return error; }
@@ -469,7 +469,7 @@ sys_lremovexattr(char __user *path, char error =user_path_walk_link (path, &nd);if (error)return error; - error =removexattr (nd.dentry, name); + error =removexattr (nd.path.dentry, name);path_release (&nd);return error; }
fs/xfs/linux-2.6/xfs_ioctl.c +3 -3
@@ -93,9 +93,9 @@ xfs_find_handle(if (error)return error; -ASSERT (nd.dentry); -ASSERT (nd.dentry->d_inode); - inode =igrab (nd.dentry->d_inode); +ASSERT (nd.path.dentry); +ASSERT (nd.path.dentry->d_inode); + inode =igrab (nd.path.dentry->d_inode);path_release (&nd);break ; }
kernel/auditfilter.c +6 -5
@@ -167,8 +167,8 @@ static struct audit_parent *audit_init_pinotify_init_watch (&parent->wdata);/* grab a ref so inotify watch hangs around until we take audit_filter_mutex */ get_inotify_watch (&parent->wdata); - wd =inotify_add_watch (audit_ih, &parent->wdata, ndp->dentry->d_inode, -AUDIT_IN_WATCH ); + wd =inotify_add_watch (audit_ih, &parent->wdata, + ndp->path.dentry->d_inode,AUDIT_IN_WATCH );if (wd <0 ) {audit_free_parent (&parent->wdata);return ERR_PTR (wd);
@@ -1126,8 +1126,8 @@ static int audit_add_watch(struct audit_/* update watch filter fields */ if (ndw) { - watch->dev = ndw->dentry->d_inode->i_sb->s_dev; - watch->ino = ndw->dentry->d_inode->i_ino; + watch->dev = ndw->path.dentry->d_inode->i_sb->s_dev; + watch->ino = ndw->path.dentry->d_inode->i_ino; }/* The audit_filter_mutex must not be held during inotify calls because
@@ -1137,7 +1137,8 @@ static int audit_add_watch(struct audit_*/ mutex_unlock (&audit_filter_mutex); -if (inotify_find_watch (audit_ih, ndp->dentry->d_inode, &i_watch) <0 ) { +if (inotify_find_watch (audit_ih, ndp->path.dentry->d_inode, + &i_watch) <0 ) { parent =audit_init_parent (ndp);if (IS_ERR (parent)) {/* caller expects mutex locked */
net/sunrpc/rpc_pipe.c +8 -7
@@ -453,14 +453,14 @@ rpc_lookup_parent(char *path, struct nam {if (path[0 ] =='\0' )return -ENOENT ; - nd->mnt =rpc_get_mount (); -if (IS_ERR (nd->mnt)) { + nd->path.mnt =rpc_get_mount (); +if (IS_ERR (nd->path.mnt)) {printk (KERN_WARNING "%s: %s failed to mount " "pseudofilesystem \n" , __FILE__, __FUNCTION__); -return PTR_ERR (nd->mnt); +return PTR_ERR (nd->path.mnt); } -mntget (nd->mnt); - nd->dentry =dget (rpc_mount->mnt_root); +mntget (nd->path.mnt); + nd->path.dentry =dget (rpc_mount->mnt_root); nd->last_type =LAST_ROOT ; nd->flags =LOOKUP_PARENT ; nd->depth =0 ;
@@ -649,7 +649,8 @@ rpc_lookup_negative(char *path, struct nif ((error =rpc_lookup_parent (path, nd)) !=0 )return ERR_PTR (error); - dentry =rpc_lookup_create (nd->dentry, nd->last.name, nd->last.len); + dentry =rpc_lookup_create (nd->path.dentry, nd->last.name, + nd->last.len);if (IS_ERR (dentry))rpc_release_path (nd);return dentry;
@@ -667,7 +668,7 @@ rpc_mkdir(char *path, struct rpc_clnt *r dentry =rpc_lookup_negative (path, &nd);if (IS_ERR (dentry))return dentry; - dir = nd.dentry->d_inode; + dir = nd.path.dentry->d_inode;if ((error =__rpc_mkdir (dir, dentry)) !=0 ) goto err_dput;RPC_I (dentry->d_inode)->private = rpc_client;
net/unix/af_unix.c +10 -10
@@ -708,14 +708,14 @@ static struct sock *unix_find_other(stru goto put_fail; err = -ECONNREFUSED ; -if (!S_ISSOCK (nd.dentry->d_inode->i_mode)) +if (!S_ISSOCK (nd.path.dentry->d_inode->i_mode)) goto put_fail; - u=unix_find_socket_byinode (nd.dentry->d_inode); + u=unix_find_socket_byinode (nd.path.dentry->d_inode);if (!u) goto put_fail;if (u->sk_type == type) -touch_atime (nd.mnt, nd.dentry); +touch_atime (nd.path.mnt, nd.path.dentry);path_release (&nd);
@@ -808,12 +808,12 @@ static int unix_bind(struct socket *sock*/ mode =S_IFSOCK | (SOCK_INODE (sock)->i_mode & ~current->fs->umask); - err =vfs_mknod (nd.dentry->d_inode, dentry, mode,0 ); + err =vfs_mknod (nd.path.dentry->d_inode, dentry, mode,0 );if (err) goto out_mknod_dput; -mutex_unlock (&nd.dentry->d_inode->i_mutex); -dput (nd.dentry); - nd.dentry = dentry; +mutex_unlock (&nd.path.dentry->d_inode->i_mutex); +dput (nd.path.dentry); + nd.path.dentry = dentry; addr->hash =UNIX_HASH_SIZE ; }
@@ -831,8 +831,8 @@ static int unix_bind(struct socket *sock list = &unix_socket_table[addr->hash]; }else { list = &unix_socket_table[dentry->d_inode->i_ino & (UNIX_HASH_SIZE -1 )]; - u->dentry = nd.dentry; - u->mnt = nd.mnt; + u->dentry = nd.path.dentry; + u->mnt = nd.path.mnt; } err =0 ;
@@ -850,7 +850,7 @@ out: out_mknod_dput:dput (dentry); out_mknod_unlock: -mutex_unlock (&nd.dentry->d_inode->i_mutex); +mutex_unlock (&nd.path.dentry->d_inode->i_mutex);path_release (&nd); out_mknod_parent:if (err==-EEXIST )
security/selinux/hooks.c +2 -2
@@ -2042,10 +2042,10 @@ static int selinux_mount(char * dev_namereturn rc;if (flags &MS_REMOUNT ) -return superblock_has_perm (current, nd->mnt->mnt_sb, +return superblock_has_perm (current, nd->path.mnt->mnt_sb,FILESYSTEM__REMOUNT ,NULL );else -return dentry_has_perm (current, nd->mnt, nd->dentry, +return dentry_has_perm (current, nd->path.mnt, nd->path.dentry,FILE__MOUNTON ); }
Quoted 7 lines · Andreas Gruenbacher
While we store the (dentry, nameidata) in struct file as a struct path, we do not do so in struct nameidata at the moment. Here is a patch that changes that. The changes are syntactic only; gcc should generate identical code.
So what is this good for?
Quoted 8 lines
Well, we currently pass around (dentry, vfsmount) pairs in a number of places. With this change, these pairs of objects are embedded in a struct path for all file lookup oprations or open files. We could start passing around struct paths instead of (dentry, vfsmount) pairs, without having to construct temporary struct path objects. This could lead to nice code cleanups. The struct paths could be passed by value or by reference.
Opinions?
On its own, I don't like this patch too much. It is just a form of mental masturbation that complicates the source.
Review
Quoted 2 lines
(quoted diff) +1
-1- inode = nd.dentry->d_inode; + inode = nd.path.dentry->d_inode;
However, once we start passing struct path by reference, it should result in a smaller binary. So if this patch is followed by others, as you indicated, and the overall result is a measurably smaller binary, I'm all for it.
Jörn
Signature · 6 lines
Joern's library part 1: http://lwn.net/Articles/2.6-kernel-api/ - To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 2 lines · Jörn Engel
On its own, I don't like this patch too much. It is just a form of mental masturbation that complicates the source.
Thanks for pointing out the masturbation thing. I was actually polling for comments; this single patch in itself wasn't meant to be the ultimate hot stuff.
Quoted 5 lines
Review
Quoted 2 lines
(quoted diff) +1
-1- inode = nd.dentry->d_inode; + inode = nd.path.dentry->d_inode;However, once we start passing struct path by reference, it should result in a smaller binary.
There are several components to it. Storing the dentry and vfsmount in a struct path allows to pass them somewhere where a struct path is expected without having to construct a temporary struct path object. Also, two parameters would become one; I believe that this could lead to somewhat cleaner code in some places.
The other question is whether we would want to pass such struct paths by value or by reference: by value would lead to roughly the same code that we have right now. By reference would reduce the function call overhead, but would blow up the code that accesses the struct path elements by about the same
amount: getting to the dentry or vfsmount from a struct path pointer requires a pointer dereference.
It's hard to tell whether the code size would decrease overall with by-reference passing. The experiments I did didn't, but I also didn't try to optimize the by-reference code.
Thanks,
Andreas
-
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 7 lines · Andreas Gruenbacher
Quoted 2 lines · Jörn Engel
On its own, I don't like this patch too much. It is just a form of mental masturbation that complicates the source.
Thanks for pointing out the masturbation thing. I was actually polling for comments; this single patch in itself wasn't meant to be the ultimate hot stuff.
Yes, my wording wasn't too diplomatic - again. Some day I might learn. What I should have said is something like: The patch has no merits of its own. Its usefullness depends completely on the follow-up patches.
Quoted 11 lines
Quoted 5 lines
Review
Quoted 2 lines
(quoted diff) +1
-1- inode = nd.dentry->d_inode; + inode = nd.path.dentry->d_inode;However, once we start passing struct path by reference, it should result in a smaller binary.
There are several components to it. Storing the dentry and vfsmount in a struct path allows to pass them somewhere where a struct path is expected without having to construct a temporary struct path object. Also, two parameters would become one; I believe that this could lead to somewhat cleaner code in some places.
Some time ago I stopped believing in "cleaner" code. If any given patch has no merits besides being cleaner, in most cases it is just changing the code to the personal taste of whoever is sending the patch.
In this concrete case, your current patch is full of replacements that make the code longer and doesn't seem to add much else. In my personal opinion that makes the code less clean. The number of parameters for some functions could be reduced, if calling by value, but overall it is just a large amount of churn without any real benefit.
Call-by-reference may be a completely different story. If that turns out to reduce binary size, we are well beyond personal taste and masturbation.
Quoted 10 lines
The other question is whether we would want to pass such struct paths by value or by reference: by value would lead to roughly the same code that we have right now. By reference would reduce the function call overhead, but would blow up the code that accesses the struct path elements by about the same
amount: getting to the dentry or vfsmount from a struct path pointer requires a pointer dereference.It's hard to tell whether the code size would decrease overall with by-reference passing. The experiments I did didn't, but I also didn't try to optimize the by-reference code.
Hmm. This doesn't confirm my hope of size reduction. It was a nice idea and definitely worth investigating. Thank you for doing it and sorry for experiencing my unique charm.
Jörn
Signature · 7 lines
Unless something dramatically changes, by 2015 we'll be largely wondering what all the fuss surrounding Linux was really about. -- Rob Enderle - To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html