Skip to contentSkip to conversation

fix 32 bit guest freeze on second reboot

PATCH Applied Joerg Roedel 3 participants 4 messages Feb 5, 2007 – Feb 7, 2007 2 messages not in the archive KVM

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fix 32 bit guest freeze on second reboot

From: Joerg Roedel <[email protected]>

This patch fixes a bug detected with 32 bit Linux guests. There the second try to reboot hangs the guest machine. It seems to be necessary to fix all dataseg registers for 32 bit guests. This time with a patch attached.

Signature · 3 lines
Joerg Roedel
Operating System Research Center
AMD Saxony LLC & Co. KG
qemu-kvm.c +2 -0
Index: qemu/qemu-kvm.c
===================================================================
@@ -195,6 +195,8 @@
 	    if (!(env->cr[0] & CR0_PG_MASK)) {
 		    fix_realmode_dataseg(&sregs.ds);
 		    fix_realmode_dataseg(&sregs.es);
+		    fix_realmode_dataseg(&sregs.fs);
+		    fix_realmode_dataseg(&sregs.gs);
 		    fix_realmode_dataseg(&sregs.ss);
 	    }
     }

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier. Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642

_______________________________________________
kvm-devel mailing list [email protected]
https://lists.sourceforge.net/lists/listinfo/kvm-devel

A message that is not in the archive (sent off-list or not yet received): [email protected]

#2 lore raw
Quoted 7 lines

From: Joerg Roedel <[email protected]>

This patch fixes a bug detected with 32 bit Linux guests. There the second try to reboot hangs the guest machine. It seems to be necessary to fix all dataseg registers for 32 bit guests. This time with a patch attached.

Although it seems logical to apply the patch anyway, it does'nt fix the problem. On 80% of the times I tried rebooting debian 32bit guest, the second tried the guest did not manage to complete the reboot andwas stuck.

Quoted 7 lines

--
Joerg Roedel
Operating System Research Center
AMD Saxony LLC & Co. KG

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier. Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642

A message that is not in the archive (sent off-list or not yet received): 64F9B87B6B770947A9F8391472E032160A4D1F22-yEcIvxbTEBqsx+V+t5oei8rau4O3wl8o3fe8/T/[email protected]

#4 lore raw
Quoted 8 lines · Dor Laor
Quoted 7 lines

From: Joerg Roedel <[email protected]>

This patch fixes a bug detected with 32 bit Linux guests. There the second try to reboot hangs the guest machine. It seems to be necessary to fix all dataseg registers for 32 bit guests. This time with a patch attached.

Quoted 4 lines

Although it seems logical to apply the patch anyway, it does'nt fix the problem. On 80% of the times I tried rebooting debian 32bit guest, the second tried the guest did not manage to complete the reboot andwas stuck.

Ok. Right. Seems I should have did more tests with the patch before submission. I will further debug it next time.

Joerg

Signature · 11 lines
Joerg Roedel
Operating System Research Center
AMD Saxony LLC & Co. KG



-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier.
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
Applied
#5 lore raw
In reply to a message not in the archive
Quoted 10 lines · Joerg Roedel

From: Joerg Roedel <[email protected]>

This patch fixes a bug detected with 32 bit Linux guests. There the second try to reboot hangs the guest machine. It seems to be necessary to fix all dataseg registers for 32 bit guests. This time with a patch attached.

Applied, thanks.

Signature · 8 lines
Do not meddle in the internals of kernels, for they are subtle and quick to panic.


-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier.
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642