Skip to contentSkip to conversation

sunrpc: remove dead variable 'rpciod_running'

PATCH In review Christoph Hellwig 3 participants 4 messages Feb 9, 2007 – May 13, 2007

Subsystems (3)
Networking NFS client NFS server
lore
Share & tools
lore

Christoph Hellwig

author
#0 lore raw

PATCH 1/1 sunrpc: remove dead variable 'rpciod_running'

rpciod_running is not used at all, but due to the way DECLARE_MUTEX_LOCKED works we don't get a warning for it.

Signed-off-by Christoph Hellwig <[email protected]>
net/sunrpc/sched.c +0 -2
Index: linux-2.6/net/sunrpc/sched.c
===================================================================
@@ -973,8 +973,6 @@
 	spin_unlock(&rpc_sched_lock);
 }
 
-static DECLARE_MUTEX_LOCKED(rpciod_running);
-
 static void rpciod_killall(void)
 {
 	unsigned long flags;

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier. Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
NFS maillist - [email protected]
https://lists.sourceforge.net/lists/listinfo/nfs

#1 lore raw

At a glance, this looks reasonable.

Quoted 11 lines · Christoph Hellwig

rpciod_running is not used at all, but due to the way DECLARE_MUTEX_LOCKED works we don't get a warning for it.

Signed-off-by Christoph Hellwig <[email protected]>

Index: linux-2.6/net/sunrpc/sched.c
===================================================================

net/sunrpc/sched.c line 978

Quoted 8 lines
net/sunrpc/sched.c +0 -2
@@ -973,8 +973,6 @@
 	spin_unlock(&rpc_sched_lock);
 }
 
-static DECLARE_MUTEX_LOCKED(rpciod_running);
-
 static void rpciod_killall(void)
 {
 	unsigned long flags;

begin:vcard
fn:Chuck Lever
n:Lever;Chuck
org:Oracle Corporation;Corporate Architecture Linux Projects Group email;internet:chuck dot lever at nospam oracle dot com title:Principal Member of Staff
tel;work:+1 248 614 5091
x-mozilla-html:FALSE
version:2.1
end:vcard

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier. Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642

_______________________________________________
NFS maillist - [email protected]
https://lists.sourceforge.net/lists/listinfo/nfs

author
#2 lore raw
In reply to Christoph Hellwig
Quoted 2 lines · Christoph Hellwig

rpciod_running is not used at all, but due to the way DECLARE_MUTEX_LOCKED works we don't get a warning for it.

Looks like this one is still not in. Any chance to send it to Linus in this merge cycle?

Quoted 7 lines
Signed-off-by Christoph Hellwig <[email protected]>

Index: linux-2.6/net/sunrpc/sched.c
===================================================================

net/sunrpc/sched.c line 978

Quoted 8 lines
net/sunrpc/sched.c +0 -2
@@ -973,8 +973,6 @@
 	spin_unlock(&rpc_sched_lock);
 }
 
-static DECLARE_MUTEX_LOCKED(rpciod_running);
-
 static void rpciod_killall(void)
 {
 	unsigned long flags;

---end quoted text---

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
NFS maillist - [email protected]
https://lists.sourceforge.net/lists/listinfo/nfs

#3 lore raw
Quoted 6 lines · Christoph Hellwig
Quoted 2 lines · Christoph Hellwig

rpciod_running is not used at all, but due to the way DECLARE_MUTEX_LOCKED works we don't get a warning for it.

Looks like this one is still not in. Any chance to send it to Linus in this merge cycle?

Oops. My bad. I must have dropped it by accident... I'll send it in.

Cheers
Trond

Quoted 18 lines
Quoted 8 lines
Signed-off-by Christoph Hellwig <[email protected]>

Index: linux-2.6/net/sunrpc/sched.c
===================================================================

net/sunrpc/sched.c line 978

Quoted 8 lines
net/sunrpc/sched.c +0 -2
@@ -973,8 +973,6 @@
 	spin_unlock(&rpc_sched_lock);
 }
 
-static DECLARE_MUTEX_LOCKED(rpciod_running);
-
 static void rpciod_killall(void)
 {
 	unsigned long flags;

---end quoted text---

Quoted 8 lines

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
NFS maillist - [email protected]
https://lists.sourceforge.net/lists/listinfo/nfs

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
NFS maillist - [email protected]
https://lists.sourceforge.net/lists/listinfo/nfs