What will be in the x86-64/x86 2.6.21 merge
Subsystems (3)
I will post the existing patches in batches for closer review.
Can be already all viewed at ftp://ftp.firstfloor.org/pub/ak/x86_64/quilt/patches/
Highlights:
- Using %fs instead of %gs for PDA register (Jeremy F.)
- Removed the old static rom probing on x86-64. We really trust e820 now. This is slightly experimental still. We'll see how it does.
- uncached copy user
Not a clear win, but also not a loss. Follow i386.
- Fix 32bit EFI with regparms.
- Fix boot slowdown as VT guest (Zach Amsden)
- VMI for paravirtualized VMware
* first paravirt ops client
* still some changes missing which need more work
- Various changes in APIC routing setup (Ingo Molnar)
- Various changes in mmconfig handling (Olivier Galibert, OGAWA Hirofumi, me)
* Share code between i386/x86-64
* Be more aggressive at ignoring bogus MCFG tables
* Now supports white lists for some chipsets (currently only Intel 945/915)
- Some patches for the upcomming AMD Family10 CPUs.
- More init section reference fixes from Vivek
- Some preparation patches for Perfmon
- New NUMA hash function for x86-64 and related changes (Amul Shah)
- Support a trigger on machine check events on x86-64
- NMI watchdog fixes for Core2 from Venkatesh
- Fix a HPET timer calibration issue on systems with long SMM events at boot (Jack Steiner)
- Fix compat a.out signals on x86-64
- Lots of small stuff
Not included yet. Might or might not make .21:
- Solution for Nvidia IOMMU corruptions. We could default to iommu=soft for nvidia, but I was still hoping for a workaround from the hardware vendors.
- vDSO support (still trouble with newer toolkits)
- Xen paravirt ops support from Jeremy/Chris
- Dynamic command line from Bernhard Walle
- Fast getcpu from Dean (requires vDSO)
- Rewritten RAID XOR functions
- Fixes for empty nodes from mm
- Fake node improvements for x86-64
- New dynamic IRQ 0 probing to work around all chipset issues
- lguest
* still seems heavily in development. Not sure it will be ready in time.
Not likely to make .21:
- PAT support (needs some more work and lot more testing)
- Early firewire support for firescope at early boot
Full list of patches:
Note I will do at least a second review pass before sending them to Linus, so there might be changes. No guarantee all patches will make it.
defconfig-update
i386-defconfig-update
Defconfig updates
copy-user-nocache
Support cache bypassing copy_from_user for file system workloads Wasn't a clear win, but also not a clear loss.
#io-apic-reuse
#vdso
Not yet
#last-branch
Private Debugging
make-the-numa-hash-function-nodemap-allocation
convert-i386-pda-code-to-use-%fs
kernel-mode-faults-pollute-current-thead
Fix for UML
revert-i386-fix-the-verify_quirk_intel_irqbalance revert-x86_64-mm-add-genapic_force revert-x86_64-mm-fix-the-irqbalance-quirk-for-e7320-e7520-e7525 optimize-fix-apic-mode-setup always-use-physical-delivery-mode-on-8-cpus remove-clustered-apic-mode default-to-physical-mode-on-hotplug-cpu-kernels
genapic changes from Ingo
x86_64-make-the-numa-hash-function-nodemap-allocation-fix-fix fix-a-typo-in-an-irq-handler-name
mmconfig-share only-call-unreachable_devices-when-type-1-is-available. detect-and-support-the-e7520-and-the-945g-gz-p-pl reserve-resources-but-only-when-were-sure-about-them. mmconfig-ioremap
mmconfig-reject-broken-table
mmconfig changes
get-rid-of-arch_have_xtime_lock
a-memcpy-that-tries-to-reduce-cache-pressure use-memcpy_uncached_read-in-rdma-interrupt-handler-to-reduce-packet-loss
Infiniband uncached copy support
improved-iommu-documentation
do-not-always-end-the-stack-trace-with-ulong_max
e820-include
Misc fixes
page-allocation-hooks-for-vmi-backend
paravirt-cpu-hypercall-batching-mode
iopl-handling-for-paravirt-guests
smp-boot-hook-for-paravirt
vmi-backend-for-paravirt-ops
vmi-timer
profile-pc-badness
kprobe-rpl-fix
vmi-timer-race
paravirt-debug-defaults-off
VMI
move-startup_32-in-text.head-section
break-init-in-two-parts-to-avoid-modpost-warnings
section warning fixes from Vivek
mcheck-include
add-idle-notifier
Idle notifier for perfmon
improve-sched_clock-on-i686 romsignature-checksum-cleanup fix-fake-numa-for-x86_64-machines-with-big-io-hole remove-fastcall-references-in-x86_64-code use-constant-instead-of-raw-number-in-x86_64-ioperm.c
handle-32-bit-perfmon-counter-writes-cleanly-in-x86_64-nmi_watchdog handle-32-bit-perfmon-counter-writes-cleanly-in-i386-nmi_watchdog handle-32-bit-perfmon-counter-writes-cleanly-in-oprofile
Core2 NMI watchdog fixes
config_physical_align-limited-to-4m
cleanup-doc-x86_64-files
list-x86_64-quilt-tree
simplify-notify_page_fault
Misc fixes
mce_amd-issues
mce-trigger
Machine check trigger support
remove-get_pmd
fix-tlbflush-comment
msr-on-cpu
kconfig-typos
msr-scf-single
mtrr-scf-single
fix-preprocessor-condition
mtrr-compat
MTRR support for 32bit compat clients
apm-seqfile
fix-size_or_mask-and-size_and_mask
48 bit MTRR support step 1.
ignore-long-smi-interrupts-in-clock-calibration-code-update-1
Fix HPET calibration problem when SMI interrupts
putreg-check
unexport-supported-pte
aout-no-vdso
Fix a.out
fs-gs-clear
VT boot performance fix
iommu-boundary
efi-regparms
Fix EFI on 32bit
remove-rom-reservation
Trust e820 completely. Muahaha!
define-dma-noncoherent-api-functions robustify-bad_dma_address-handling fix-laptop-bootup-hang-in-init_acpi all-transmeta-cpus-have-constant-tscs avoid-gcc-extension
support-classic-mediagxm
Support for older Cyrix CPUs
entrys-end-endproc-annotations clean-up-sparsemem-memory_present-call arch-i386-kernel-alternativec-should-include-asm-bugsh remove-unused-kernel-config-option-x86_xadd
Misc cleanups
update-io-apic-dest-field-to-8-bit-for-xapic
Fix kexec on es7000 with 8 bit APIC IDs
avoid-warning-message-livelock minor-patch-for-compilation-warning-in-x86_64-signal-code dont-include-bugsh add-option-to-show-more-code-in-oops-reports 32-bit-ptrace-mangles-sixth-system-call-argument geode-configuration-fixes survive-having-no-irq-mapping-for-a-vector fix-gcc-check
Misc changes
paravirt-remove-fastcall
Small cleanup
fam10-cpuid
fam10-l3cache
fam10-nmi-watchdog
AMD family10 support
fix-microcode-warning
i386-fix-transmeta-warning
fails-to-detect-mediagx
-Andi
Quoted 5 lines · Andi Kleen
I will post the existing patches in batches for closer review.
Can be already all viewed at ftp://ftp.firstfloor.org/pub/ak/x86_64/quilt/patches/
Andi, please make sure to also include this Calgary patch I sent on Feb 6th.
Thanks,
Muli
Subject: x86-64 Calgary: robustify bad_dma_address handling
From: Muli Ben-Yehuda <[email protected]>
- set bad_dma_address explicitly to 0x0
- reserve 32 pages from bad_dma_address and up
- WARN_ON() a driver feeding us bad_dma_address
Thanks to Leo Duran <[email protected]> for the suggestion.
--- arch/x86_64/kernel/pci-calgary.c | 17 +++++++++++++++-- 1 files changed, 15 insertions(+), 2 deletions(-)
arch/x86_64/kernel/pci-calgary.c +15 -2
@@ -138,6 +138,8 @@ static const unsigned long phb_debug_off#define PHB_DEBUG_STUFF_OFFSET 0x0020 +#define EMERGENCY_PAGES 32/* = 128KB */ +unsigned int specified_table_size =TCE_TABLE_SIZE_UNSPECIFIED ;static int translate_empty_slots__read_mostly =0 ;static int calgary_detected__read_mostly =0 ;
@@ -296,6 +298,16 @@ static void __iommu_free(struct iommu_ta {unsigned long entry;unsigned long badbit; +unsigned long badend; + +/* were we called with bad_dma_address? */ + badend = bad_dma_address + (EMERGENCY_PAGES *PAGE_SIZE ); +if (unlikely ((dma_addr >= bad_dma_address) && (dma_addr < badend))) { +printk (KERN_ERR "Calgary: driver tried unmapping bad DMA " +"address 0x%Lx\n" , dma_addr); +WARN_ON (1 ); +return ; + } entry = dma_addr >>PAGE_SHIFT ;
@@ -656,8 +668,8 @@ static void __init calgary_reserve_regiou64 start;struct iommu_table *tbl = dev->sysdata; -/* reserve bad_dma_address in case it's a legal address */ -iommu_range_reserve (tbl, bad_dma_address,1 ); +/* reserve EMERGENCY_PAGES from bad_dma_address and up */ +iommu_range_reserve (tbl, bad_dma_address,EMERGENCY_PAGES );/* avoid the BIOS/VGA first 640KB-1MB region */ start = (640 *1024 );
@@ -1176,6 +1188,7 @@ int __init calgary_iommu_init(void) } force_iommu =1 ; + bad_dma_address =0x0 ; dma_ops = &calgary_dma_ops;return 0 ;
Signature · 1 line
1.4.1
Quoted 9 lines · Muli Ben-Yehuda
Quoted 5 lines · Andi Kleen
I will post the existing patches in batches for closer review.
Can be already all viewed at ftp://ftp.firstfloor.org/pub/ak/x86_64/quilt/patches/
Andi, please make sure to also include this Calgary patch I sent on Feb 6th.
It's already included
ftp://ftp.firstfloor.org/pub/ak/x86_64/quilt/patches/robustify-bad_dma_address-handling
-Andi
Quoted 8 lines · Andi Kleen
Quoted 7 lines · Muli Ben-Yehuda
Quoted 5 lines · Andi Kleen
I will post the existing patches in batches for closer review.
Can be already all viewed at ftp://ftp.firstfloor.org/pub/ak/x86_64/quilt/patches/
Quoted 7 lines
Quoted 2 lines
Andi, please make sure to also include this Calgary patch I sent on Feb 6th.
It's already included
ftp://ftp.firstfloor.org/pub/ak/x86_64/quilt/patches/robustify-bad_dma_address-handling
Thanks, I scanned the list for 'calgary' and missed it. I'm guessing the Calgary got dropped because the Subject had 'x86-64 Calgary:' and your scripts trimmed the prefix?
Cheers,
Muli
Quoted 4 lines
Thanks, I scanned the list for 'calgary' and missed it. I'm guessing the Calgary got dropped because the Subject had 'x86-64 Calgary:' and your scripts trimmed the prefix?
Yes.
-Andi
remote debugging via FireWire (was What will be in the x86-64/x86 2.6.21 merge)
In reply to Andi KleenAndi Kleen wrote at LKML:
...
Quoted 1 line
Not likely to make .21:
...
Quoted 1 line
- Early firewire support for firescope at early boot
...
Was it seen in canonical patch format on a mailinglist before? Is it Bernhard Kaindl's ohci1394_early?
http://www.suse.de/~bk/firewire/
Would be good to put this on the usual patch-submission road in order to prep it for 2.6.22. Could be handled via linux1394-2.6.git, although a different channel where the actual users of this facility watch would IMO be more appropriate.
I also have suggestions, at least WRT Bernhard's code:
- The Kconfig option could go into the "Kernel hacking" submenu rather than the IEEE 1394 submenu. (The driver source should stay in drivers/ieee1394.)
- Leave a note in the Kconfig help how it is typically used, i.e. what is required on the remote terminal side, where to find firescope, fireproxy etc. and assorted HOWTOs.
- Indicate in the Kconfig help that only a 4GB address range is made visible this way.
A mostly unrelated note: A simple to set up remote-dmesg utility would be nice to have on the terminal side. Maybe a small ieee1394 high-level driver which gives hints on the location of the dmesg buffer via configuration ROM would be warranted. Or is it feasible to find the dmesg buffer by plain memory analysis?
Signature · 3 lines
Stefan Richter -=====-=-=== --=- -=-=- http://arcgraph.de/sr/
Re: remote debugging via FireWire (was What will be in the x86-64/x86 2.6.21 merge)
Quoted 8 lines · Stefan Richter
Andi Kleen wrote at LKML:
...Quoted 1 line
Not likely to make .21:
...
Quoted 1 line
- Early firewire support for firescope at early boot
...
Was it seen in canonical patch format on a mailinglist before?
Don't know.
Quoted 2 lines
Is it Bernhard Kaindl's
ohci1394_early?
http://www.suse.de/~bk/firewire/
Yes.
Quoted 5 lines
Would be good to put this on the usual patch-submission road in order to prep it for 2.6.22. Could be handled via linux1394-2.6.git, although a different channel where the actual users of this facility watch would IMO be more appropriate.
It's more related to arch code than firewire, so I thought i would handle it. But you can too if you want. It definitely needs much more review anyways.
Quoted 2 lines
A mostly unrelated note: A simple to set up remote-dmesg utility would be nice to have on the terminal side.
ftp://ftp.firstfloor.org/pub/ak/firescope/
-Andi
Re: remote debugging via FireWire
Quoted 8 lines · Andi Kleen
Quoted 3 lines · Stefan Richter
Could be handled via linux1394-2.6.git, although a different channel where the actual users of this facility watch would IMO be more appropriate.
It's more related to arch code than firewire, so I thought i would handle it. But you can too if you want. It definitely needs much more review anyways.
It's better you do it. I don't know anything about the specifics of early initialization. Just Cc linux1394-devel on submission so that we can have a look at the OHCI-1394 related bits.
Using linux1394-2.6.git could only be helpful if more code sharing between ohci1394.c and ohci1394_early.c would be desired. That's questionable though, given the rather small size of ohci1394_early.c.
Quoted 4 lines
Quoted 2 lines
A mostly unrelated note: A simple to set up remote-dmesg utility would be nice to have on the terminal side.
ftp://ftp.firstfloor.org/pub/ak/firescope/
Thanks, I wasn't aware that firescope actually does fill this gap.
Signature · 3 lines
Stefan Richter -=====-=-=== --=- -=-=- http://arcgraph.de/sr/
Re: remote debugging via FireWire
Quoted 6 lines · Stefan Richter
Quoted 5 lines · Andi Kleen
Quoted 3 lines · Stefan Richter
Could be handled via linux1394-2.6.git, although a different channel where the actual users of this facility watch would IMO be more appropriate.
Quoted 7 lines
Quoted 3 lines
It's more related to arch code than firewire, so I thought i would handle it. But you can too if you want. It definitely needs much more review anyways.
It's better you do it. I don't know anything about the specifics of early initialization. Just Cc linux1394-devel on submission so that we can have a look at the OHCI-1394 related bits.
Ok. I'm sure you know more about 1394 than me so I guess it will be shared review.
-Andi
Re: remote debugging via FireWire
[ohci1394_early]
Some remarks to the September 2006 version at
http://www.suse.de/~bk/firewire/ :
- Seems its .remove won't work properly if more than one OHCI-1394 controller is installed. And it's .probe isn't reentrant, but that might be less of a problem.
- Its functionality will be lost if there is a FireWire bus reset, e.g. when something is plugged in or out. To keep physical DMA alive, an interrupt handler had to be installed which writes ~0 to OHCI1394_PhyReqFilter{Hi,Lo}Set. Can interrupt handlers be registered in an early setup stage?
- There might be some register accesses in the setup which could be omitted; I'd have to look this up.
- Could be optimized to not use ohci1394.h::struct ti_ohci.
- PCI_CLASS_FIREWIRE_OHCI can be replaced by
include/linux/pci_ids.h::PCI_CLASS_SERIAL_FIREWIRE_OHCI which
was newly added in 2.6.20-git#. - I suppose .probe should check for PCI_CLASS_SERIAL_FIREWIRE_OHCI instead of PCI_CLASS_SERIAL_FIREWIRE.
- How about dropping support for configuring this as module, to simplify the code? Unless this would interfere with ohci1394; and it probably would if there was an interrupt handler...
- "depends on X86_64" is missing in Kconfig.
- Maybe put it into arch/x86_64/drivers/ instead of drivers/ieee1394?
- Plus what I mentioned earlier in the thread.
I could send code to address some of this at next weekend or later.
Signature · 3 lines
Stefan Richter -=====-=-=== --=- -=-=- http://arcgraph.de/sr/
Re: remote debugging via FireWire
Quoted 28 lines · Stefan Richter
[
ohci1394_early]Some remarks to the September 2006 version at
http://www.suse.de/~bk/firewire/ :- Seems its .remove won't work properly if more than one OHCI-1394 controller is installed. And it's .probe isn't reentrant, but that might be less of a problem.
- Its functionality will be lost if there is a FireWire bus reset, e.g. when something is plugged in or out. To keep physical DMA alive, an interrupt handler had to be installed which writes ~0 to OHCI1394_PhyReqFilter{Hi,Lo}Set. Can interrupt handlers be registered in an early setup stage?
- There might be some register accesses in the setup which could be omitted; I'd have to look this up.
- Could be optimized to not useohci1394.h::structti_ohci.
-PCI_CLASS_FIREWIRE_OHCIcan be replaced byinclude/linux/pci_ids.h::PCI_CLASS_SERIAL_FIREWIRE_OHCI which was newly added in 2.6.20-git#.- I suppose .probe should check for
PCI_CLASS_SERIAL_FIREWIRE_OHCIinstead ofPCI_CLASS_SERIAL_FIREWIRE.
- How about dropping support for configuring this as module, to simplify the code? Unless this would interfere with ohci1394; and it probably would if there was an interrupt handler...
- "depends onX86_64" is missing inKconfig.
- Maybe put it intoarch/x86_64/drivers/instead ofdrivers/ieee1394?
- Plus what I mentioned earlier in the thread.
Quoted 1 line
I could send code to address some of this at next weekend or later.
I'd like to have that on ppc as well, so I'd rather keep it in drivers/
I agree that it doesn't need to be a module. If you can load modules, then you can load the full ohci driver. Thus, if it's an early thingy initialized by arch, it can export a special "takeover" hook that the proper ohci module can then call to override it (important if we start having an irq handler).
Andi, also, how do you deal with iommu ? Not at all ? :-)
Ben.
Re: remote debugging via FireWire
Quoted 1 line · Benjamin Herrenschmidt
I'd like to have that on ppc as well, so I'd rather keep it in
drivers/
This will need some abstraction at least -- there are some early mapping hacks that are x86 specific right now.
Quoted 7 lines
I agree that it doesn't need to be a module. If you can load modules, then you can load the full ohci driver. Thus, if it's an early thingy initialized by arch, it can export a special "takeover" hook that the proper ohci module can then call to override it (important if we start having an irq handler).
Andi, also, how do you deal with iommu ? Not at all ? :-)
Yes -- it's really early debugging hack mostly. It's reasonable to let the iommu be disabled (or later a special bypass can be added for this)
-Andi
Re: remote debugging via FireWire
Quoted 6 lines · Andi Kleen
Quoted 1 line · Benjamin Herrenschmidt
I'd like to have that on ppc as well, so I'd rather keep it in
drivers/This will need some abstraction at least -- there are some early mapping hacks that are x86 specific right now.
Either abstraction or ifdef's .. we have ioremap working very early on ppc :-)
Quoted 10 lines
Quoted 7 lines
I agree that it doesn't need to be a module. If you can load modules, then you can load the full ohci driver. Thus, if it's an early thingy initialized by arch, it can export a special "takeover" hook that the proper ohci module can then call to override it (important if we start having an irq handler).
Andi, also, how do you deal with iommu ? Not at all ? :-)
Yes -- it's really early debugging hack mostly. It's reasonable to let the iommu be disabled (or later a special bypass can be added for this)
Ok.
Ben.
Re: remote debugging via FireWire * __fast__ firedump!
In reply to Stefan RichterHi,
I just wanted to let you know that I'll have picked up the early
firewire patch again and cleaned it up very much so that it should be ready to submit it and but it on the patch-submission road.
What's left to do is to write some HOWTO like Stefan describes below, but I'll try to get that done soon.
I've also started working on the userspace tools and got firescope to work across the 32/64-bit machines (both directions), there is one hack (which I should do in a clean way insteat) in that patch of which I do not know if that works in ppc/ppc64 but I could look at it if needed or send the patch to Benjamin for adding support for ppc64, to do it properly, we'll probably need an target architecture option in firescope and as I do not know if it's needed by Benjamin, I left out ppc64 for now.
I have just had the guts to explore __fast__ memory dumping over firewire for full-system dumps (reading quadlets is __painfully__ show if you want to read 2GB of memory over the bus, you only get about some some kilobytes each second) using raw1394_start_read() to allow also block reads instead of just quatlet reads.
The biggest block size that worked here was 2048 bytes, which was enough to get nearly 10MB/s of data transfer rate from the remote memory to disk. Dumping 2GB of remote memory was just a matter of about 3 few short minutes which quickly ran by.
Afterwards, the victim was dead (I excluded the low MB of memory, so something else must have caused this), at least the start of the dump looked well, but I haven't tested the error handling yet, but I'll send you the tool (I called it firedump) soon.
Bernhard
Quoted 46 lines · Stefan Richter
Andi Kleen wrote at LKML:
...Quoted 1 line
Not likely to make .21:
...
Quoted 1 line
- Early firewire support for firescope at early boot
...
Was it seen in canonical patch format on a mailinglist before? Is it Bernhard Kaindl's
ohci1394_early?
http://www.suse.de/~bk/firewire/Would be good to put this on the usual patch-submission road in order to prep it for 2.6.22. Could be handled via linux1394-2.6.git, although a different channel where the actual users of this facility watch would IMO be more appropriate.
I also have suggestions, at least WRT Bernhard's code:
- TheKconfigoption could go into the "Kernel hacking" submenu rather than the IEEE 1394 submenu. (The driver source should stay indrivers/ieee1394.)
- Leave a note in theKconfighelp how it is typically used, i.e. what is required on the remote terminal side, where to find firescope, fireproxy etc. and assorted HOWTOs.
- Indicate in theKconfighelp that only a 4GB address range is made visible this way.A mostly unrelated note: A simple to set up remote-dmesg utility would be nice to have on the terminal side. Maybe a small ieee1394 high-level driver which gives hints on the location of the dmesg buffer via configuration ROM would be warranted. Or is it feasible to find the dmesg buffer by plain memory analysis?
--
Stefan Richter
-=====-=-=== --=- -=-=-
http://arcgraph.de/sr/-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier. Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
mailing list [email protected]
https://lists.sourceforge.net/lists/listinfo/linux1394-devel
Re: remote debugging via FireWire * __fast__ firedump!
Quoted 3 lines · Bernhard Kaindl
I just wanted to let you know that I'll have picked up the early
firewire patch again and cleaned it up very much so that it should be ready to submit it and but it on the patch-submission road.
Nice.
Quoted 5 lines
I have just had the guts to explore
__fast__memory dumping over firewire for full-system dumps (reading quadlets is__painfully__show if you want to read 2GB of memory over the bus, you only get about some some kilobytes each second) usingraw1394_start_read()to allow also block reads instead of just quatlet reads.
Unfortunately it won't work for >3GB or so AFAIK.
Quoted 7 lines
The biggest block size that worked here was 2048 bytes, which was enough to get nearly 10MB/s of data transfer rate from the remote memory to disk. Dumping 2GB of remote memory was just a matter of about 3 few short minutes which quickly ran by.
Afterwards, the victim was dead (I excluded the low MB of memory, so something else must have caused this), at least the start of
Did you run into the PCI memory hole below 4GB?
I suppose the best way would be to require a System.map and then read e820.nr_map/e820.map[] and only dump real memory.
-Andi
Re: remote debugging via FireWire * __fast__ firedump!
Quoted 5 lines · Andi Kleen
Quoted 3 lines
I have just had the guts to explore
__fast__memory dumping over firewire for full-system dumps [...]Unfortunately it won't work for >3GB or so AFAIK.
Yes we seem to be limited to 4GB mostly, with 3G mem hole, it's 3GB.
Quoted 4 lines
Quoted 2 lines
Afterwards, the victim was dead (I excluded the low MB of memory, so something else must have caused this), at least the start of
Did you run into the PCI memory hole below 4GB?
Thanks, that was it most likely. I checked and haw that I did read a 32MB reserved area just below 2GB.
Quoted 2 lines
I suppose the best way would be to require a System.map and then read e820.nr_map/e820.map[] and only dump real memory.
Yes, good idea!
Bernhard
Re: remote debugging via FireWire * __fast__ firedump!
In reply to Bernhard KaindlQuoted 3 lines · Bernhard Kaindl
The biggest block size that worked here was 2048 bytes, which was enough to get nearly 10MB/s of data transfer rate from the remote memory to disk.
The maximum payload size of block requests depends on three things:
1. speed of the connection between the two nodes (debugged machine and debugging machine), 2. link layer controllers of the two nodes, 3. software on the debugging machine.
1.) S100: 512 bytes, S200: 1024 bytes, S400: 2048 bytes, S800 and more:
4096 bytes.
2.) Controllers on CardBus cards are limited to 1024 bytes payload of asynchronous packets, for reasons I don't know. The other available controllers only have the above mentioned speed-dependent limit.
3.) The ohci1394 driver has an implementation limitation which requires that all packets including headers don't exceed PAGE_SIZE. This does not affect the packets which go through the physical response unit (which they do on the debugged machine) but it affects the debugging machine.
A quick note to this text from
http://www.suse.de/~bk/firewire/ohci1394_dma_early.diff :
Review
Quoted 4 lines
(quoted diff) +4
-0+ As all changes to the FireWire bus such as enabling and disabling + devices cause a bus reset and thereby disable remote DMA for all + devices, be sure to have FireWire enabled on the debug host (and + the cable plugged) before booting the debug target for debugging.
Bus resets are also caused by bus managing software, which Linux' old and new FireWire stacks and the stacks of all other FireWire capable desktop OSs are to varying degrees. I wonder if the following could
happen: The two PCs are directly connected, only the PHY of the debugging PC is active, then the PHY of the debugged PC is activated, becomes root node, debugging PC examines the bus, then resets the bus to force its own PHY to become root node in order to get a working isochronous resource manager. This bus reset would switch remote DMA on the debugged PC off.
Signature · 3 lines
Stefan Richter -=====-=-=== ==-- --=-- http://arcgraph.de/sr/
Re: remote debugging via FireWire * __fast__ firedump!
Quoted 5 lines · Stefan Richter
Quoted 3 lines · Bernhard Kaindl
The biggest block size that worked here was 2048 bytes, which was enough to get nearly 10MB/s of data transfer rate from the remote memory to disk.
Quoted 7 lines
The maximum payload size of block requests depends on three things:
1. speed of the connection between the two nodes (debugged machine and debugging machine), 2. link layer controllers of the two nodes, 3. software on the debugging machine.1.) S100: 512 bytes, S200: 1024 bytes, S400: 2048 bytes, S800 and more:
4096 bytes.
PS:
If there are only 1394a nodes, you can read the connection speed from the speed map registers on the debugging machine. It becomes difficult for 1394b nodes and some mixtures of 1394a and b nodes. But consumer 1394b hardware is always S800 capable. Consumer 1394a hardware is always S400 capable. Except consumer camcorders which are AFAIK typically limited to S100, but they have only one port and will therefore never sit between debugging and debugged PC. So it's not as difficult in 99.9% of the cases: You can expect S400, some people might get S800. But you can't use the bigger S800 block size if the debugging machine runs ohci1394.
Quoted 3 lines
2.) Controllers on CardBus cards are limited to 1024 bytes payload of asynchronous packets, for reasons I don't know. The other available controllers only have the above mentioned speed-dependent limit.
This is relevant if the debugging or the debugged PC have a CardBus card. Actually this is the limit of all 1394a CardBus card I have seen; I don't know about 1394b CardBus cards, or Express cards. (I suppose Express cards have no limits of this kind, as they are just PCIe cards in a different formfactor.)
This payload limitation of the link can be read from the bus info blocks of the debugged and the debugging machine. Though I am not entirely sure right now if the ohci1394_earlyinit driven machine will have its bus info block properly set up.
Signature · 3 lines
Stefan Richter -=====-=-=== ==-- --=-- http://arcgraph.de/sr/
Re: remote debugging via FireWire * __fast__ firedump!
PPS: Today I had a brief look through your current sources. Look good so far, except for a curious hunk which patches drivers/Makefile. And I can't say anything to the x86 platform related and PCI related aspects of the driver.
Signature · 3 lines
Stefan Richter -=====-=-=== ==-- --=-- http://arcgraph.de/sr/
[feedback discussion] Early boot debugging via FireWire (ohci1394_dma=early)
Hi,
this mail sums up some discussion about special code for early initialisation of OHCI-1394 controllers to enable their use for remote debugging over FireWire using physical DMA. The thread started on linux-kernel and Stefan Richter asked to Cc also linux1394-devel for the review of ieee1394-related parts.
Quoted 5 lines · Stefan Richter
PPS: Today I had a brief look through your current sources. Look good so far, except for a curious hunk which patches
drivers/Makefile. And I can't say anything to the x86 platform related and PCI related aspects of the driver.
Thanks, good catch. The I fixed that hunk now
ftp://ftp.suse.de/private/bk/firewire/kernel/ohci1394_dma_early-v2.diff
to read like this:
linux-2.6.24-rc4/drivers/Makefile:
obj-$(CONFIG_ATA) += ata/
obj-$(CONFIG_FUSION) += message/
obj-$(CONFIG_FIREWIRE) += firewire/
-obj-$(CONFIG_IEEE1394) += ieee1394/
+obj-y += ieee1394/
obj-$(CONFIG_UIO) += uio/
obj-y += cdrom/
obj-y += auxdisplay/
The reason for adding it was that drivers/ieee1394/init_ohci1394_dma.c does not get compiled if CONFIG_IEEE1394 is not set, but it's not really depeding on CONFIG_IEEE1394 being set.
The only effect this hunk has (and only when CONFIG_IEEE1394 is not set) is that an empty object file is created in drivers/ieee1394 for linking into vmlinux, but as it does not contain any code or data, it does not change vmlinux at all.
If you do not approve that change, I'd have to add a "depends IEEE1394" to the new config entry. I adopted way to have the early firewire debugging option showing up all times, not only when CONFIG_IEEE1394 is set.
I tried to add "selects IEEE1394", but that causes IEEE1394 to be compiled into the kernel even if you do not intend that, so I saw the hunk above as the best way to deal with it.
==========================================================================
I'm commenting on suggestions made in the early part of this thread, it can be found at http://lkml.org/lkml/2007/2/10/96 :
Quoted 3 lines
- The
Kconfigoption could go into the "Kernel hacking" submenu rather than the IEEE 1394 submenu. (The driver source should stay indrivers/ieee1394.)
done.
Quoted 3 lines
- Leave a note in the
Kconfighelp how it is typically used, i.e. what is required on the remote terminal side, where to find firescope, fireproxy etc. and assorted HOWTOs.
I have put that to Documentation/debugging-via-ohci1394.txt in the new patch.
Quoted 2 lines
- Indicate in the
Kconfighelp that only a 4GB address range is made visible this way.
done.
Andi Kleen said that he would handle to patch-submission process:
Quoted 3 lines
It's more related to arch code than firewire, so I thought i would handle it. But you can too if you want. It definitely needs much more review anyways.
To which Stefan Richter agreed:
Quoted 3 lines
It's better you do it. I don't know anything about the specifics of early initialization. Just Cc linux1394-devel on submission so that we can have a look at the OHCI-1394 related bits.
doing that now, Stefan also remarked:
Quoted 3 lines
Using linux1394-2.6.git could only be helpful if more code sharing between
ohci1394.candohci1394_early.cwould be desired. That's questionable though, given the rather small size ofohci1394_early.c.
Andi agreed:
Quoted 2 lines
Ok. I'm sure you know more about 1394 than me so I guess it will be shared review.
Stefan then did a code review and came back with:
Quoted 5 lines
- Its functionality will be lost if there is a FireWire bus reset, e.g. when something is plugged in or out. To keep physical DMA alive, an interrupt handler had to be installed which writes ~0 to OHCI1394_PhyReqFilter{Hi,Lo}Set. Can interrupt handlers be registered in an early setup stage?
We didn't go into this further, and while I have further ideas on that, like polling for bus resets in the Oops and Panic handlers, I now resorted to documenting that carefully as especially if the issue to be debugged crashed the machine bady or one wants to run a kernel debugger over firewire using physical DMA, interrupts would be disabled anyways.
Quoted 2 lines
- There might be some register accesses in the setup which could be omitted; I'd have to look this up.
Migth be possible. I didn't give this a major priority because at least in this version, all code is tagged with __init, so everything is freed after boot, and even if we keep the init routine, there is not a awful lot to remove. When linked into vmlinux, I saw about 1k size increase for the whole initialisation routine.
Quoted 1 line
- Could be optimized to not use
ohci1394.h::structti_ohci.
Indeed, but I didn't see it a big gain to have my own copy of it. As nothing (except a fixmap per controller) is allocated permanently, it wouldn't change the compiled code. In a future step, it may share some source code with fw-ohci to make the source even smaller, the source code which could be shared is about 84 lines, not very much.
Quoted 3 lines
-
PCI_CLASS_FIREWIRE_OHCIcan be replaced byinclude/linux/pci_ids.h::PCI_CLASS_SERIAL_FIREWIRE_OHCI which was newly added in 2.6.20-git#.
done.
Quoted 3 lines
- How about dropping support for configuring this as module, to simplify the code? Unless this would interfere with ohci1394; and it probably would if there was an interrupt handler...
done, no interrupt handler.
Quoted 1 line
- "depends on
X86_64" is missing inKconfig.
Added support for X86_32 too, so it has a depends X86 now. It uses a fixmap currenlty which means that it's X86-only for now, for ppc see below.
Quoted 1 line
- Maybe put it into
arch/x86_64/drivers/instead ofdrivers/ieee1394?
Ben replied to that:
Quoted 1 line
I'd like to have that on ppc as well, so I'd rather keep it in
drivers/
He asked:
Quoted 1 line
Quoted 1 line
Quoted 1 line
Andi, also, how do you deal with iommu ? Not at all ? :-)
Andi:
Quoted 2 lines
Quoted 2 lines
Yes -- it's really early debugging hack mostly. It's reasonable to let the iommu be disabled (or later a special bypass can be added for this)
Ben:
Quoted 1 line
Ok.
On support for PowerPC and other archtectures:
Quoted 4 lines
Quoted 2 lines
This will need some abstraction at least -- there are some early mapping hacks that are x86 specific right now.
Either abstraction or ifdef's .. we have ioremap working very early on ppc :-)
Either way would be fine with me. I'd like to put it this way:
Everyone is free to extend the code to execute also early on more archtectures, and I could even look at that myself in January but not now as I'm on vacation from next week on. I think that support for more architectures can be added with incremental patches.
I'll submit the patch now in the formal way (next mail) for full review, Bernhard
Re: [feedback discussion] Early boot debugging via FireWire (ohci1394_dma=early)
Quoted 1 line · Bernhard Kaindl
linux-2.6.24-rc4/drivers/Makefile:
...
Quoted 2 lines
(quoted diff) +1
-1-obj-$(CONFIG_IEEE1394) += ieee1394/ +obj-y += ieee1394/
...
Quoted 5 lines
The reason for adding it was that
drivers/ieee1394/init_ohci1394_dma.cdoes not get compiled ifCONFIG_IEEE1394is not set, but it's not really depeding onCONFIG_IEEE1394being set.From what I gather from e.g.
drivers/usb/Makefile, you could do it also
this way:
obj-$(CONFIG_IEEE1394) += ieee1394/
+obj-$(CONFIG_PROVIDE_OHCI1394_DMA_INIT) += ieee1394/
Signature · 3 lines
Stefan Richter -=====-=-=== ==-- --==- http://arcgraph.de/sr/
PATCH 1/1 Early boot debugging via FireWire (ohci1394_dma=early)
In reply to Bernhard KaindlHi,
after summing up the discussion on previous patches, I'm now submitting the
patch below for formal review and adoption on branches for mainline inclusion.
As this patch is X86-only for now (might be extended for more architectures in incremental patches tough), initially (that was in February 2007) Andi Kleen offered to handle the patch submission.
Subject of this patch:
This patch adds a new configuration option, which adds support for a new early_param which gets checked in arch/x86/kernel/setup_{32,64}.c:setup_arch() to decide wether OHCI-1394 FireWire controllers should be initialized and enabled for physical DMA access to allow remote debugging of early problems like issues ACPI or other subsystems which are executed very early.
If the config option is not enabled, no code is changed, and if the boot paramenter is not given, no new code is executed, and independent of that, all new code is freed after boot, so the config option can be even enabled in standard, non-debug kernels.
With specialized tools, it is then possible to get debugging information from machines which have no serial ports (notebooks) such as the printk buffer contents, or any data which can be referenced from global pointers, if it is stored below the 4GB limit and even memory dumps of of the physical RAM region below the 4GB limit can be taken without any cooperation from the CPU of the host, so the machine can be crashed early, it does not matter.
In the extreme, even kernel debuggers can be accessed in this way. I wrote a small kgdb module and an accompanying gdb stub for FireWire which allows to gdb to talk to kgdb using remote remory reads and writes over FireWire.
An version of the gdb stub fore FireWire is able to read all global data from a system which is running a a normal kernel without any kernel debugger, without any interruption or support of the system's CPU. That way, e.g. the task struct and so on can be read and even manipulated when the physical DMA access is granted.
A HOWTO is included in this patch, in Documentation/debugging-via-ohci1394.txt and I've put a copy online at ftp://ftp.suse.de/private/bk/firewire/docs/debugging-via-ohci1394.txt
It also has links to all the tools which are available to make use of it another copy of it is online at:
ftp://ftp.suse.de/private/bk/firewire/kernel/ohci1394_dma_early-v2.diff
Cheers,
Bernhard
PS: This code can be extended to allow to debug panics, suspend and resume by enabling physical DMA especially on these events, so in incremental patches, we could add support e.g. for ohci1394_dma={suspend,resume,panic}
arch/x86/kernel/setup_32.c +11 -0
@@ -44,6 +44,7 @@#include <linux/crash_dump.h> #include <linux/dmi.h> #include <linux/pfn.h> +#include <linux/init_ohci1394_dma.h> #include <video/edid.h>
@@ -636,6 +637,16 @@smp_alloc_memory ();/* AP processor realmode stacks in low memory*/ #endif paging_init (); + +/* +* NOTE: On x86-32, only from this point on, fixmaps are ready for use. +*/ + +#ifdef CONFIG_PROVIDE_OHCI1394_DMA_INIT +if (init_ohci1394_dma_early) +init_ohci1394_dma_on_all_controllers (); +#endif +remapped_pgdat_init ();sparse_init ();zone_sizes_init ();
arch/x86/kernel/setup_64.c +11 -0
@@ -39,6 +39,7 @@#include <linux/dmi.h> #include <linux/dma-mapping.h> #include <linux/ctype.h> +#include <linux/init_ohci1394_dma.h> #include <asm/mtrr.h> #include <asm/uaccess.h>
@@ -254,6 +255,11 @@ ebda_size =64 *1024 ; } +/* +* setup_arch - architecture-specific boot-time initializations +* +* Note: On x86_64, fixmaps are ready for use even before this is called. +*/ void __init setup_arch (char **cmdline_p) {printk (KERN_INFO "Command line: %s\n" , boot_command_line);
@@ -293,6 +299,11 @@parse_early_param (); +#ifdef CONFIG_PROVIDE_OHCI1394_DMA_INIT +if (init_ohci1394_dma_early) +init_ohci1394_dma_on_all_controllers (); +#endif +finish_e820_parsing ();e820_register_active_regions (0 ,0 ,-1UL );
drivers/Makefile +1 -1
@@ -38,7 +38,7 @@ obj-$(CONFIG_ATA) += ata/ obj-$(CONFIG_FUSION) += message/ obj-$(CONFIG_FIREWIRE) += firewire/ -obj-$(CONFIG_IEEE1394) += ieee1394/ +obj-y += ieee1394/ obj-$(CONFIG_UIO) += uio/ obj-y += cdrom/ obj-y += auxdisplay/
drivers/ieee1394/Makefile +1 -0
@@ -15,3 +15,4 @@ obj-$(CONFIG_IEEE1394_DV1394) += dv1394.o obj-$(CONFIG_IEEE1394_ETH1394) += eth1394.o +obj-$(CONFIG_PROVIDE_OHCI1394_DMA_INIT) += init_ohci1394_dma.o
drivers/ieee1394/init_ohci1394_dma.c +285 -0
285 lines not on this page · raw message
include/asm-x86/fixmap_32.h +3 -0
@@ -95,6 +95,9 @@FIX_BTMAP_END = __end_of_permanent_fixed_addresses,FIX_BTMAP_BEGIN =FIX_BTMAP_END +NR_FIX_BTMAPS -1 ,FIX_WP_TEST , +#ifdef CONFIG_PROVIDE_OHCI1394_DMA_INIT +FIX_OHCI1394_BASE , +#endif __end_of_fixed_addresses };
include/asm-x86/fixmap_64.h +3 -0
@@ -41,6 +41,9 @@FIX_APIC_BASE ,/* local (CPU) APIC) -- required for SMP or not */ FIX_IO_APIC_BASE_0 ,FIX_IO_APIC_BASE_END =FIX_IO_APIC_BASE_0 +MAX_IO_APICS -1 , +#ifdef CONFIG_PROVIDE_OHCI1394_DMA_INIT +FIX_OHCI1394_BASE , +#endif __end_of_fixed_addresses };
include/linux/init_ohci1394_dma.h +4 -0
@@ -0,0 +1,4 @@ +#ifdef CONFIG_PROVIDE_OHCI1394_DMA_INIT +extern int __initdata init_ohci1394_dma_early; +extern void __init init_ohci1394_dma_on_all_controllers (void ); +#endif
lib/Kconfig.debug +29 -0
@@ -517,4 +517,33 @@ help Provide stacktrace filter for fault-injection capabilities +config PROVIDE_OHCI1394_DMA_INIT + bool "Provide code for enabling DMA over FireWire early on boot" + depends on PCI && X86 + help + If you want to debug problems which hang or crash the kernel early + on boot and the crashing machine has a FireWire port, you can use + this feature to remotely access the memory of the crashed machine + over FireWire. This employs remote DMA as part of the OHCI1394 + specification which is now the standard for FireWire controllers. + + With remote DMA, you can monitor the printk buffer remotely using + firescope and access all memory below 4GB using fireproxy from gdb. + Even controlling a kernel debugger is possible using remote DMA. + + Usage: + + If ohci1394_dma=early is used as boot parameter, it will initialize + all OHCI1394 controllers which are found in the PCI config space. + + As all changes to the FireWire bus such as enabling and disabling + devices cause a bus reset and thereby disable remote DMA for all + devices, be sure to have the cable plugged and FireWire enabled on + the debugging host before booting the debug target for debugging. + + This code (~1k) is freed after boot. By then, the firewire stack + in charge of the OHCI-1394 controllers should be used instead. + + See Documentation/debugging-via-ohci1394.txt for more information. + source "samples/Kconfig"
Documentation/debugging-via-ohci1394.txt +179 -0
179 lines not on this page · raw message
Re: [PATCH] Early boot debugging via FireWire (ohci1394_dma=early)
Quoted 2 lines · Bernhard Kaindl
after summing up the discussion on previous patches, I'm now submitting the
patch below for formal review and adoption on branches for mainline inclusion.
I will look a bit more into the details later; for now I have just a quick comment on the documentation.
Documentation/debugging-via-ohci1394.txt line 6
Quoted 9 lines
Documentation/debugging-via-ohci1394.txt +6
-0@@ -0,0 +1,179 @@ + + Using physical DMA provided by OHCI-1394 FireWire controllers for debugging + --------------------------------------------------------------------------- + +Introduction +------------
There are some really long sentences in it.
Try to use the "." character more often. :-)
Documentation/debugging-via-ohci1394.txt line 17
Quoted 10 lines
Documentation/debugging-via-ohci1394.txt +10
-0+Basically all FireWire controllers which are in use today are compliant +to the OHCI-1394 specification which defines the controller to be a PCI +bus master which uses DMA to offload data transfers from the CPU and has +a "Physical Response Unit" which executes specific requests by employing +PCI-Bus master DMA after applying filters defined by the OHCI-1394 driver. + +Once properly configured, remote machines can send these requests to +ask the OHCI-1394 controller to perform read and write requests on +physical system memory and, for read requests, send the result of +the physical memory read back to the requester.
In other words, the FireWire controller can be configured to work as a bus bridge between FireWire bus and local bus (PCI or PCIe).
And yes, there are security implications.
[...]
Documentation/debugging-via-ohci1394.txt line 43
Quoted 5 lines
Documentation/debugging-via-ohci1394.txt +5
-0+The OHCI-1394 drivers in drivers/firewire and drivers/ieee1394 initialize +the OHCI-1394 controllers to a working state and can be used to enable +physical DMA. By default you only have to load the driver, and physical +DMA access will be granted to all remote nodes, but it can be turned off +when using the ohci1394 driver.
This is correct for ohci1394, and it's a bug.
http://bugzilla.kernel.org/show_bug.cgi?id=7794
firewire-ohci however implements filtered physical DMA. The only user of that is the firewire-sbp2 driver which grants SBP-2 targets access through the physical response unit. firewire-ohci has at the moment no option for either unfiltered physical DMA (as needed by firescope at al, tracked at http://wiki.linux1394.org/ToDo) nor to completely disable physical DMA.
Signature · 3 lines
Stefan Richter -=====-=-=== ==-- --==- http://arcgraph.de/sr/
Re: [PATCH] Early boot debugging via FireWire (ohci1394_dma=early)
In reply to Bernhard KaindlQuoted 14 lines · Bernhard Kaindl
Subject of this patch:
This patch adds a new configuration option, which adds support for a new
early_paramwhich gets checked in arch/x86/kernel/setup_{32,64}.c:setup_arch() to decide wether OHCI-1394 FireWire controllers should be initialized and enabled for physical DMA access to allow remote debugging of early problems like issues ACPI or other subsystems which are executed very early.If the config option is not enabled, no code is changed, and if the boot paramenter is not given, no new code is executed, and independent of that, all new code is freed after boot, so the config option can be even enabled in standard, non-debug kernels.
Quoted 7 lines
With specialized tools, it is then possible to get debugging information from machines which have no serial ports (notebooks) such as the printk buffer contents, or any data which can be referenced from global pointers, if it is stored below the 4GB limit and even memory dumps of of the physical RAM region below the 4GB limit can be taken without any cooperation from the CPU of the host, so the machine can be crashed early, it does not matter.
cool stuff! I've tentatively added your patch to x86.git (pending more review feedback from others), but it already looks quite nice to me.
Ingo
Re: remote debugging via FireWire * __fast__ firedump!
In reply to Stefan RichterQuoted 11 lines · Stefan Richter
A quick note to this text from
http://www.suse.de/~bk/firewire/ohci1394_dma_early.diff :Review
Quoted 4 lines
(quoted diff) +4
-0+ As all changes to the FireWire bus such as enabling and disabling + devices cause a bus reset and thereby disable remote DMA for all + devices, be sure to have FireWire enabled on the debug host (and + the cable plugged) before booting the debug target for debugging.Bus resets are also caused by bus managing software, which Linux' old and new FireWire stacks and the stacks of all other FireWire capable desktop OSs are to varying degrees.
Yes, I can also trigger it raw1394_reset_bus() from libraw1394.
Quoted 7 lines
I wonder if the following could
happen: The two PCs are directly connected, only the PHY of the debugging PC is active, then the PHY of the debugged PC is activated, becomes root node, debugging PC examines the bus, then resets the bus to force its own PHY to become root node in order to get a working isochronous resource manager. This bus reset would switch remote DMA on the debugged PC off.
Yes, that's the case. The PHY of the debugging PC must be active before the booting a kernel with the early OHCI-1394 initialisation on the debugged machine.
I tried to to instruct users to do exactly that in that part of the help text, but changed the wording now in to hope to make it clearer:
+ [...] be sure to have the cable plugged and FireWire enabled on
+ the debugging host before booting the debug target for debugging.
and I added new file, installed as Documentation/debugging-via-ohci1394.txt to give a more detailed HOWTO with links to all available tools and a step by step guide on how to create a setup for using firescope.
ftp://ftp.suse.de/private/bk/firewire/kernel/ohci1394_dma_early-v2.diff
I'll submit that patch for full review in my next mail.
Bernhard
Quoted 2 lines · Andi Kleen
- lguest
* still seems heavily in development. Not sure it will be ready in time.
How would you define ready?
It's currently useful and stable, and features a lack of enterprise-class complexity.
- James
Signature · 2 lines
James Morris <[email protected]>
Quoted 6 lines · James Morris
Quoted 2 lines · Andi Kleen
- lguest
* still seems heavily in development. Not sure it will be ready in time.How would you define ready?
Used by at least some people for something, got some real world testing, more review.
Quoted 1 line
It's currently useful and stable,
How do you know?
-Andi
Quoted 3 lines · Andi Kleen
Quoted 1 line
It's currently useful and stable,
How do you know?
I've been working on it for some weeks. At this stage, it's also useful for some simple kernel hacking.
- James
Signature · 2 lines
James Morris <[email protected]>
Quoted 9 lines · Andi Kleen
Quoted 6 lines · James Morris
Quoted 2 lines · Andi Kleen
- lguest
* still seems heavily in development. Not sure it will be ready in time.How would you define ready?
Used by at least some people for something, got some real world testing, more review.
Well, I only have bug reports from around half a dozen people, so I'm not sure what that says about my userbase (for most people it should simply work).
lguest.ozlabs.org got 3000 hits in the last 12 hours, and they can't all be bots 8) Mind you, in that time only 26 unique IP addresses visited the patches/ repository, so maybe they are...
As to "insufficient review", the reviews so far have cleaned up some code (great!) and found 3 actual bugs, none real showstoppers and all now fixed:
(1) race of initialization code vs. cpu hotplug.
(2) block driver being suboptimal
(3) network driver sending crap for inter-guest sendfile.
In addition, you counted not handling TSC change as a bug, so I tore that code out, instead of leaving a FIXME. During the cleanup patches I did introduce (and then fix) another bug, it is true.
I would not describe it as "heavily in development"; I really think it's at the stage where it can benefit from being in-tree.
Quoted 3 lines
Quoted 1 line
It's currently useful and stable,
How do you know?
Please don't harass my users. That's my job!
Cheers!
Rusty.