gigaset build broken on current linux-2.6.git
Fedora Core 6, x86-64, make allyesconfig:
[jgarzik@pretzel linux-2.6]$ make -sj4
CHK include/linux/version.h CHK include/linux/utsrelease.h CHK include/linux/compile.h
drivers/isdn/gigaset/bas-gigaset.c: In function ‘dump_urb’:drivers/isdn/gigaset/bas-gigaset.c:258: error: ‘struct urb’ has no member named ‘bandwidth’ make[3]: *** [drivers/isdn/gigaset/bas-gigaset.o] Error 1
make[2]: *** [drivers/isdn/gigaset] Error 2
make[1]: *** [drivers/isdn] Error 2
Quoted 7 lines · Jeff Garzik
[jgarzik@pretzel linux-2.6]$ make -sj4
CHK include/linux/version.h CHK include/linux/utsrelease.h CHK include/linux/compile.h
drivers/isdn/gigaset/bas-gigaset.c: In function 'dump_urb':drivers/isdn/gigaset/bas-gigaset.c:258: error: 'struct urb' has no member named 'bandwidth'
ISDN: gigaset - remove forgotten urb->bandwidth reference
Recent changes in usbcore removed the bandwidth field from struct urb. Remove the forgotten occurence in bas-gigaset.c
---
drivers/isdn/gigaset/bas-gigaset.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
drivers/isdn/gigaset/bas-gigaset.c +2 -2
@@ -257,10 +257,10 @@ static inline void dump_urb(enum debuglevel level, const char *tag, urb->transfer_flags);gig_dbg (level," transfer_buffer=0x%08lx[%d], actual_length=%d, " -"bandwidth=%d, setup_packet=0x%08lx," , +"setup_packet=0x%08lx," , (unsigned long ) urb->transfer_buffer, urb->transfer_buffer_length, urb->actual_length, - urb->bandwidth, (unsigned long ) urb->setup_packet); + (unsigned long ) urb->setup_packet); gig_dbg(level, " start_frame=%d, number_of_packets=%d, interval=%d, " "error_count=%d,",
Signature · 1 line
Jiri Kosina
Quoted 10 lines · Jiri Kosina
Quoted 7 lines · Jeff Garzik
[jgarzik@pretzel linux-2.6]$ make -sj4
CHK include/linux/version.h CHK include/linux/utsrelease.h CHK include/linux/compile.h
drivers/isdn/gigaset/bas-gigaset.c: In function 'dump_urb':drivers/isdn/gigaset/bas-gigaset.c:258: error: 'struct urb' has no member named 'bandwidth'
Quoted 6 lines
ISDN: gigaset - remove forgotten
urb->bandwidthreferenceRecent changes in usbcore removed the bandwidth field from struct urb. Remove the forgotten occurence in
bas-gigaset.cSigned-off-by Jiri Kosina <[email protected]>
Use this or one of the two identical patches I already submitted for that.
Quoted 23 lines
---
drivers/isdn/gigaset/bas-gigaset.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)drivers/isdn/gigaset/bas-gigaset.c +2
-2@@ -257,10 +257,10 @@ static inline void dump_urb(enum debuglevel level, const char *tag, urb->transfer_flags);gig_dbg (level," transfer_buffer=0x%08lx[%d], actual_length=%d, " -"bandwidth=%d, setup_packet=0x%08lx," , +"setup_packet=0x%08lx," , (unsigned long ) urb->transfer_buffer, urb->transfer_buffer_length, urb->actual_length, - urb->bandwidth, (unsigned long ) urb->setup_packet); + (unsigned long ) urb->setup_packet); gig_dbg(level, " start_frame=%d, number_of_packets=%d, interval=%d, " "error_count=%d,",
Signature · 4 lines
Tilman Schmidt E-Mail: [email protected] Bonn, Germany Diese Nachricht besteht zu 100% aus wiederverwerteten Bits. Ungeöffnet mindestens haltbar bis: (siehe Rückseite)
Quoted 8 lines · On Thu, 08 Feb 2007 14:02:31 +0100 I wrote:
Subject: Re: [linux-usb-devel] [PATCH 41/70] usbcore: remove unused bandwith-related code
This breaks compilation of
drivers/isdn/gigaset/bas-gigaset.c. If you pass on this patch, please pass on Andrew'sfix-gregkh-usb-usbcore-remove-unused-bandwith-related-code.patch
along with it.
Quoted 8 lines · On Fri, 09 Feb 2007 09:30:01 +0100, I wrote:
Quoted 6 lines · Jiri Kosina
ISDN: gigaset - remove forgotten
urb->bandwidthreferenceRecent changes in usbcore removed the bandwidth field from struct urb. Remove the forgotten occurence in
bas-gigaset.cSigned-off-by Jiri Kosina <[email protected]>Signed-off-by Tilman Schmidt <[email protected]>
I notice that 2.6.20-git6 still doesn't include either of these fixes. Is there anything I need to do in order to push it?
Thanks,
Tilman
Signature · 4 lines
Tilman Schmidt E-Mail: [email protected] Bonn, Germany - In theory, there is no difference between theory and practice. In practice, there is.
Quoted 14 lines · Tilman Schmidt
Quoted 8 lines · On Thu, 08 Feb 2007 14:02:31 +0100 I wrote:
Subject: Re: [linux-usb-devel] [PATCH 41/70] usbcore: remove unused bandwith-related code
This breaks compilation of
drivers/isdn/gigaset/bas-gigaset.c. If you pass on this patch, please pass on Andrew'sfix-gregkh-usb-usbcore-remove-unused-bandwith-related-code.patch
along with it.
Quoted 3 lines · On Fri, 09 Feb 2007 09:30:01 +0100, I wrote:
Quoted 2 lines · Jiri Kosina
ISDN: gigaset - remove forgotten
urb->bandwidthreference
Quoted 8 lines
Quoted 5 lines
Quoted 4 lines
Recent changes in usbcore removed the bandwidth field from struct urb. Remove the forgotten occurence in
bas-gigaset.cSigned-off-by Jiri Kosina <[email protected]>Signed-off-by Tilman Schmidt <[email protected]>I notice that 2.6.20-git6 still doesn't include either of these fixes. Is there anything I need to do in order to push it?
It's in my queue and is on track to get in before 2.6.21-rc1 is out.
thanks,
greg k-h
Quoted 1 line · Greg KH
It's in my queue and is on track to get in before 2.6.21-rc1 is out.
It breaks the build for everyone, please fast-forward the merging of this.
Jeff
Quoted 5 lines · Jeff Garzik
Quoted 1 line · Greg KH
It's in my queue and is on track to get in before 2.6.21-rc1 is out.
It breaks the build for everyone, please fast-forward the merging of this.
It's now in Linus's tree thanks to Andrew.