Skip to contentSkip to conversation

git-gui: fix typo in GIT-VERSION-GEN, "/dev/null" not "/devnull"

PATCH In review Andy Parkins 2 participants 2 messages Jun 15, 2016

lore
Share & tools
lore

Andy Parkins

author
#0 lore raw

PATCH 1/1 git-gui: fix typo in GIT-VERSION-GEN, "/dev/null" not "/devnull"

Signed-off-by Andy Parkins <[email protected]>

---
I think this would make git-gui get the wrong version number as the script wouldn't complete successfully.

 git-gui/GIT-VERSION-GEN |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
git-gui/GIT-VERSION-GEN +1 -1
index 8fac8cb..9966126 100755
@@ -10,7 +10,7 @@ tree_search ()
 {
 	head=$1
 	tree=$2
-	for p in $(git rev-list --parents --max-count=1 $head 2>/devnull)
+	for p in $(git rev-list --parents --max-count=1 $head 2>/dev/null)
 	do
 		test $tree = $(git rev-parse $p^{tree} 2>/dev/null) &&
 		vn=$(git describe --abbrev=4 $p 2>/dev/null) &&
Signature · 1 line
1.5.0.rc4.365.g5eff6
#1 lore raw

git-gui/GIT-VERSION-GEN tree_search () · line 13

Quoted 2 lines · Andy Parkins
git-gui/GIT-VERSION-GEN +1 -1
-	for p in $(git rev-list --parents --max-count=1 $head 2>/devnull)
+	for p in $(git rev-list --parents --max-count=1 $head 2>/dev/null)

[git (sp/gitgui)]$ ls /devnull
/devnull

Gaaaaah. Damn Mac. Thanks for the patch, I'm applying it now.

Signature · 1 line
Shawn.