Skip to contentSkip to conversation

HIL: fix improper call of release_region v2

PATCH In review Cyrill V. Gorcunov 3 participants 3 messages Feb 15, 2007 Input drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 HIL: fix improper call of release_region v2

Thist patch prevents from improper call of release_region if the code has been compiled without CONFIG_HP300 support.

---

An improved version (v2). Helge, please check it and Ack then.

 drivers/input/keyboard/hilkbd.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
drivers/input/keyboard/hilkbd.c +2 -0
index 255a6ec..4de4dc2 100644
@@ -294,8 +294,10 @@ err3:
 	disable_irq(HIL_IRQ);
 	free_irq(HIL_IRQ, hil_dev.dev_id);
 err2:
+#if defined(CONFIG_HP300)
 	release_region(HILBASE + HIL_DATA, 2);
 err1:
+#endif
 	input_free_device(hil_dev.dev);
 	hil_dev.dev = NULL;
 	return err;
Acked-by on v1 1/1
#1 lore raw
Quoted 4 lines · Cyrill V. Gorcunov

Thist patch prevents from improper call of release_region if the code has been compiled without CONFIG_HP300 support.

Quoted 23 lines

---

An improved version (v2). Helge, please check it and Ack then.

 drivers/input/keyboard/hilkbd.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
drivers/input/keyboard/hilkbd.c +2 -0
index 255a6ec..4de4dc2 100644
@@ -294,8 +294,10 @@ err3:
 	disable_irq(HIL_IRQ);
 	free_irq(HIL_IRQ, hil_dev.dev_id);
 err2:
+#if defined(CONFIG_HP300)
 	release_region(HILBASE + HIL_DATA, 2);
 err1:
+#endif
 	input_free_device(hil_dev.dev);
 	hil_dev.dev = NULL;
 	return err;