HIL: fix improper call of release_region v2
PATCH 1/1 HIL: fix improper call of release_region v2
Thist patch prevents from improper call of release_region if the code has been compiled without CONFIG_HP300 support.
Signed-off-by Cyrill V. Gorcunov <[email protected]>
---
An improved version (v2). Helge, please check it and Ack then.
drivers/input/keyboard/hilkbd.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)
drivers/input/keyboard/hilkbd.c +2 -0
@@ -294,8 +294,10 @@ err3:disable_irq (HIL_IRQ );free_irq (HIL_IRQ , hil_dev.dev_id); err2: +#if defined(CONFIG_HP300 )release_region (HILBASE +HIL_DATA ,2 ); err1: +#endif input_free_device (hil_dev.dev); hil_dev.dev =NULL ;return err;
Quoted 4 lines · Cyrill V. Gorcunov
Thist patch prevents from improper call of
release_regionif the code has been compiled withoutCONFIG_HP300support.Signed-off-by Cyrill V. Gorcunov <[email protected]>
Acked-by Helge Deller <[email protected]>
Quoted 23 lines
---
An improved version (v2). Helge, please check it and Ack then.
drivers/input/keyboard/hilkbd.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)drivers/input/keyboard/hilkbd.c +2
-0@@ -294,8 +294,10 @@ err3:disable_irq (HIL_IRQ );free_irq (HIL_IRQ , hil_dev.dev_id); err2: +#if defined(CONFIG_HP300 )release_region (HILBASE +HIL_DATA ,2 ); err1: +#endif input_free_device (hil_dev.dev); hil_dev.dev =NULL ;return err;
Dmitry Torokhov
maintainerQuoted 8 lines · Helge Deller
Quoted 4 lines · Cyrill V. Gorcunov
Thist patch prevents from improper call of
release_regionif the code has been compiled withoutCONFIG_HP300support.Signed-off-by Cyrill V. Gorcunov <[email protected]>Acked-by Helge Deller <[email protected]>
Will apply, thanks.
Signature · 1 line
Dmitry