Skip to contentSkip to conversation

lp486e.c: cleanup not needed casts

PATCH In review Douglas Landgraf 2 participants 3 messages Feb 15, 2007 – Feb 16, 2007

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 lp486e.c: cleanup not needed casts

Removed all unnecessary casts.

drivers/net/lp486e.c +9 -9
@@ -392,7 +392,7 @@
 	struct i596_private *lp;
 	int boguscnt = ct;
 
-	lp = (struct i596_private *) dev->priv;
+	lp = dev->priv;
 	while (lp->scb.command) {
 		if (--boguscnt == 0) {
 			printk("%s: %s timed out - stat %4.4x, cmd %4.4x\n",
@@ -413,7 +413,7 @@
 	int i;
 	// struct i596_rbd *rbd;
 
-	lp = (struct i596_private *) dev->priv;
+	lp = dev->priv;
 	lp->scb.pa_rfd = I596_NULL;
 
 	for (i = 0; i < num; i++) {
@@ -470,7 +470,7 @@
 	struct i596_private *lp;
 	struct i596_rfd *rfd;
 
-	lp = (struct i596_private *) dev->priv;
+	lp = dev->priv;
 	lp->rx_tail->pa_next = I596_NULL;
 
 	do {
@@ -626,7 +626,7 @@
 	if (i596_scp_setup(dev))
 		return 1;
 
-	lp = (struct i596_private *) dev->priv;
+	lp = dev->priv;
 	lp->scb.command = 0;
 
 	memcpy ((void *)lp->i596_config, init_setup, 14);
@@ -743,9 +743,9 @@
 	struct i596_private *lp;
 	struct i596_cmd *cmd;
 
-	lp = (struct i596_private *) dev->priv;
+	lp = dev->priv;
 	while (lp->cmd_head) {
-		cmd = (struct i596_cmd *)lp->cmd_head;
+		cmd = lp->cmd_head;
 
 		lp->cmd_head = pa_to_va(lp->cmd_head->pa_next);
 		lp->cmd_backlog--;
@@ -976,7 +976,7 @@
 		return -EBUSY;
 	}
 
-	lp = (struct i596_private *) dev->priv;
+	lp = dev->priv;
 	spin_lock_init(&lp->cmd_lock);
 
 	/*
@@ -1073,7 +1073,7 @@
 			struct tx_cmd *tx_cmd;
 			struct i596_tbd *tx_cmd_tbd;
 
-			tx_cmd = (struct tx_cmd *) cmd;
+			tx_cmd = cmd;
 			tx_cmd_tbd = pa_to_va(tx_cmd->pa_tbd);
 
 			frames_out++;
@@ -1157,7 +1157,7 @@
 	unsigned short status, ack_cmd = 0;
 	int frames_in = 0;
 
-	lp = (struct i596_private *) dev->priv;
+	lp = dev->priv;
 
 	/*
 	 * The 82596 examines the command, performs the required action,

_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.osdl.org/mailman/listinfo/kernel-janitors

author
#2 lore raw

PATCH 1/1 lp486e.c: cleanup not needed casts

In reply to Douglas Landgraf

Removed all unnecessary casts.

drivers/net/lp486e.c +9 -9
@@ -392,7 +392,7 @@
 	struct i596_private *lp;
 	int boguscnt = ct;
 
-	lp = (struct i596_private *) dev->priv;
+	lp = dev->priv;
 	while (lp->scb.command) {
 		if (--boguscnt = 0) {
 			printk("%s: %s timed out - stat %4.4x, cmd %4.4x\n",
@@ -413,7 +413,7 @@
 	int i;
 	// struct i596_rbd *rbd;
 
-	lp = (struct i596_private *) dev->priv;
+	lp = dev->priv;
 	lp->scb.pa_rfd = I596_NULL;
 
 	for (i = 0; i < num; i++) {
@@ -470,7 +470,7 @@
 	struct i596_private *lp;
 	struct i596_rfd *rfd;
 
-	lp = (struct i596_private *) dev->priv;
+	lp = dev->priv;
 	lp->rx_tail->pa_next = I596_NULL;
 
 	do {
@@ -626,7 +626,7 @@
 	if (i596_scp_setup(dev))
 		return 1;
 
-	lp = (struct i596_private *) dev->priv;
+	lp = dev->priv;
 	lp->scb.command = 0;
 
 	memcpy ((void *)lp->i596_config, init_setup, 14);
@@ -743,9 +743,9 @@
 	struct i596_private *lp;
 	struct i596_cmd *cmd;
 
-	lp = (struct i596_private *) dev->priv;
+	lp = dev->priv;
 	while (lp->cmd_head) {
-		cmd = (struct i596_cmd *)lp->cmd_head;
+		cmd = lp->cmd_head;
 
 		lp->cmd_head = pa_to_va(lp->cmd_head->pa_next);
 		lp->cmd_backlog--;
@@ -976,7 +976,7 @@
 		return -EBUSY;
 	}
 
-	lp = (struct i596_private *) dev->priv;
+	lp = dev->priv;
 	spin_lock_init(&lp->cmd_lock);
 
 	/*
@@ -1073,7 +1073,7 @@
 			struct tx_cmd *tx_cmd;
 			struct i596_tbd *tx_cmd_tbd;
 
-			tx_cmd = (struct tx_cmd *) cmd;
+			tx_cmd = cmd;
 			tx_cmd_tbd = pa_to_va(tx_cmd->pa_tbd);
 
 			frames_out++;
@@ -1157,7 +1157,7 @@
 	unsigned short status, ack_cmd = 0;
 	int frames_in = 0;
 
-	lp = (struct i596_private *) dev->priv;
+	lp = dev->priv;
 
 	/*
 	 * The 82596 examines the command, performs the required action,

_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.osdl.org/mailman/listinfo/kernel-janitors