Skip to contentSkip to conversation

Clean up serial console support on Sibyte 1250 duart

PATCH Applied Andrew Sharp 2 participants 4 messages Feb 19, 2007 – Feb 20, 2007 MIPS

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Clean up serial console support on Sibyte 1250 duart

Clean up the serial console support on the Sibyte 1250's built in duart.

#1 lore raw

On Mon, Feb 19, 2007 at 03:48:24PM -0800, Andrew Sharp wrote:

Patch looks reasonable at a quick glance. I'll review it for real later, just wanted to mention that the drivers/char/ Sibyte serial driver is really a dead end of the evolution. The driver should be replaced with a new driver based on the the new drivers/serial/ infrastructure.

Ralf

#2 lore raw
Quoted 11 lines · Ralf Baechle

On Mon, Feb 19, 2007 at 03:48:24PM -0800, Andrew Sharp wrote:

Patch looks reasonable at a quick glance. I'll review it for real later, just wanted to mention that the drivers/char/ Sibyte serial driver is really a dead end of the evolution. The driver should be replaced with a new driver based on the the new drivers/serial/ infrastructure.

Ralf

That explains the "shouldn't there be a general frame work for all this?" itch in the back of my neck the whole time I was hacking on it.

a

Applied
#3 lore raw
In reply to Andrew Sharp
Quoted 1 line · Andrew Sharp

Clean up the serial console support on the Sibyte 1250's built in duart.

Thanks, applied with some additional formatting fixes.

Ralf