Skip to contentSkip to conversation

net/irda/: proper prototypes

PATCH Applied [email protected] 3 participants 4 messages Feb 6, 2007 – Feb 20, 2007

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 2/11 net/irda/: proper prototypes

From: Adrian Bunk <[email protected]>

Add proper prototypes for some functions in include/net/irda/irda.h

---

 include/net/irda/irda.h |   15 +++++++++++++++
 net/irda/irmod.c        |   13 -------------
 2 files changed, 15 insertions(+), 13 deletions(-)
include/net/irda/irda.h renamed from include/net/irda/irda.h~net-irda-proper-prototypes +15 -0
diff -puN include/net/irda/irda.h~net-irda-proper-prototypes include/net/irda/irda.h
@@ -113,4 +113,19 @@ do { if(!(expr)) { \
 #define IAS_IRCOMM_ID 0x2343
 #define IAS_IRLPT_ID  0x9876
 
+struct net_device;
+struct packet_type;
+
+void irda_proc_register(void);
+void irda_proc_unregister(void);
+
+int irda_sysctl_register(void);
+void irda_sysctl_unregister(void);
+
+int irsock_init(void);
+void irsock_cleanup(void);
+
+int irlap_driver_rcv(struct sk_buff *skb, struct net_device *dev,
+		     struct packet_type *ptype, struct net_device *orig_dev);
+
 #endif /* NET_IRDA_H */
net/irda/irmod.c renamed from net/irda/irmod.c~net-irda-proper-prototypes +0 -13
diff -puN net/irda/irmod.c~net-irda-proper-prototypes net/irda/irmod.c
@@ -42,19 +42,6 @@
 #include <net/irda/irttp.h>		/* irttp_init */
 #include <net/irda/irda_device.h>	/* irda_device_init */
 
-/* irproc.c */
-extern void irda_proc_register(void);
-extern void irda_proc_unregister(void);
-/* irsysctl.c */
-extern int  irda_sysctl_register(void);
-extern void irda_sysctl_unregister(void);
-/* af_irda.c */
-extern int  irsock_init(void);
-extern void irsock_cleanup(void);
-/* irlap_frame.c */
-extern int  irlap_driver_rcv(struct sk_buff *, struct net_device *, 
-			     struct packet_type *, struct net_device *);
-
 /*
  * Module parameters
  */

_

maintainer
#1 lore raw

From: [email protected]
Date: Mon, 05 Feb 2007 16:30:53 -0800

Quoted 7 lines

From: Adrian Bunk <[email protected]>

Add proper prototypes for some functions in include/net/irda/irda.h

I NAK'd this so that Adrian would go add "extern" to the function declarations in the header file.

Please drop this, Adrian will resend once he fixes it up.

#2 lore raw

PATCH 1/1 net/irda/: proper prototypes

Quoted 7 lines · David Miller

From: [email protected]
Date: Mon, 05 Feb 2007 16:30:53 -0800

Quoted 4 lines

From: Adrian Bunk <[email protected]>

Add proper prototypes for some functions in include/net/irda/irda.h

Quoted 8 lines
Quoted 3 lines

I NAK'd this so that Adrian would go add "extern" to the function declarations in the header file.

Please drop this, Adrian will resend once he fixes it up.

Sorry, I should have sent this earlier.
Updated patch below.

cu
Adrian

<-- snip -->

This patch adds proper prototypes for some functions in include/net/irda/irda.h

---

 include/net/irda/irda.h |   16 ++++++++++++++++
 net/irda/irmod.c        |   13 -------------
 2 files changed, 16 insertions(+), 13 deletions(-)
include/net/irda/irda.h renamed from include/net/irda/irda.h.old +16 -0
@@ -113,4 +113,20 @@
 #define IAS_IRCOMM_ID 0x2343
 #define IAS_IRLPT_ID  0x9876
 
+struct net_device;
+struct packet_type;
+
+extern void irda_proc_register(void);
+extern void irda_proc_unregister(void);
+
+extern int irda_sysctl_register(void);
+extern void irda_sysctl_unregister(void);
+
+extern int irsock_init(void);
+extern void irsock_cleanup(void);
+
+extern int irlap_driver_rcv(struct sk_buff *skb, struct net_device *dev,
+			    struct packet_type *ptype,
+			    struct net_device *orig_dev);
+
 #endif /* NET_IRDA_H */
net/irda/irmod.c renamed from net/irda/irmod.c.old +0 -13
@@ -42,19 +42,6 @@
 #include <net/irda/irttp.h>		/* irttp_init */
 #include <net/irda/irda_device.h>	/* irda_device_init */
 
-/* irproc.c */
-extern void irda_proc_register(void);
-extern void irda_proc_unregister(void);
-/* irsysctl.c */
-extern int  irda_sysctl_register(void);
-extern void irda_sysctl_unregister(void);
-/* af_irda.c */
-extern int  irsock_init(void);
-extern void irsock_cleanup(void);
-/* irlap_frame.c */
-extern int  irlap_driver_rcv(struct sk_buff *, struct net_device *,
-			     struct packet_type *, struct net_device *);
-
 /*
  * Module parameters
  */
maintainer
#3 lore raw

From: Adrian Bunk <[email protected]>
Date: Tue, 20 Feb 2007 01:07:21 +0100

Quoted 19 lines · David Miller
Quoted 7 lines

From: [email protected]
Date: Mon, 05 Feb 2007 16:30:53 -0800

Quoted 4 lines

From: Adrian Bunk <[email protected]>

Add proper prototypes for some functions in include/net/irda/irda.h

Quoted 8 lines
Quoted 3 lines

I NAK'd this so that Adrian would go add "extern" to the function declarations in the header file.

Please drop this, Adrian will resend once he fixes it up.

Sorry, I should have sent this earlier.
Updated patch below.

...

Quoted 4 lines

This patch adds proper prototypes for some functions in include/net/irda/irda.h

Thanks Adrian, applied.