Skip to contentSkip to conversation

make remove_inode_dquot_ref() static

PATCH In review Adrian Bunk 2 participants 2 messages Feb 20, 2007

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 make remove_inode_dquot_ref() static

remove_inode_dquot_ref() can now become static.

---

 fs/dquot.c               |    3 ++-
 include/linux/quotaops.h |    3 ---
 2 files changed, 2 insertions(+), 4 deletions(-)
include/linux/quotaops.h renamed from include/linux/quotaops.h.old +0 -3
@@ -37,9 +37,6 @@
 extern int dquot_commit_info(struct super_block *sb, int type);
 extern int dquot_mark_dquot_dirty(struct dquot *dquot);
 
-int remove_inode_dquot_ref(struct inode *inode, int type,
-			   struct list_head *tofree_head);
-
 extern int vfs_quota_on(struct super_block *sb, int type, int format_id, char *path);
 extern int vfs_quota_on_mount(struct super_block *sb, char *qf_name,
 		int format_id, int type);
fs/dquot.c renamed from fs/dquot.c.old +2 -1
@@ -721,7 +721,8 @@
 
 /* Remove references to dquots from inode - add dquot to list for freeing if needed */
 /* We can't race with anybody because we hold dqptr_sem for writing... */
-int remove_inode_dquot_ref(struct inode *inode, int type, struct list_head *tofree_head)
+static int remove_inode_dquot_ref(struct inode *inode, int type,
+				  struct list_head *tofree_head)
 {
 	struct dquot *dquot = inode->i_dquot[type];
 
reviewer
#1 lore raw
Quoted 1 line · Adrian Bunk

remove_inode_dquot_ref() can now become static.

ACK. I should have noticed it when acking Christophs patch...

Quoted 1 line

Honza

Quoted 31 lines

---

 fs/dquot.c               |    3 ++-
 include/linux/quotaops.h |    3 ---
 2 files changed, 2 insertions(+), 4 deletions(-)
include/linux/quotaops.h renamed from include/linux/quotaops.h.old +0 -3
@@ -37,9 +37,6 @@
 extern int dquot_commit_info(struct super_block *sb, int type);
 extern int dquot_mark_dquot_dirty(struct dquot *dquot);
 
-int remove_inode_dquot_ref(struct inode *inode, int type,
-			   struct list_head *tofree_head);
-
 extern int vfs_quota_on(struct super_block *sb, int type, int format_id, char *path);
 extern int vfs_quota_on_mount(struct super_block *sb, char *qf_name,
 		int format_id, int type);
fs/dquot.c renamed from fs/dquot.c.old +2 -1
@@ -721,7 +721,8 @@
 
 /* Remove references to dquots from inode - add dquot to list for freeing if needed */
 /* We can't race with anybody because we hold dqptr_sem for writing... */
-int remove_inode_dquot_ref(struct inode *inode, int type, struct list_head *tofree_head)
+static int remove_inode_dquot_ref(struct inode *inode, int type,
+				  struct list_head *tofree_head)
 {
 	struct dquot *dquot = inode->i_dquot[type];
 
Signature · 2 lines
Jan Kara <[email protected]>
SuSE CR Labs