Skip to contentSkip to conversation

pata_oldpiix: Call both PIO and DMA setup functions on switch as they are called on set up

PATCH Applied Alan 2 participants 2 messages Feb 20, 2007 libata

lore
Share & tools
lore

Alan

author
#0 lore raw

PATCH 1/1 pata_oldpiix: Call both PIO and DMA setup functions on switch as they are called on set up

Keeps the behaviour consistent and easier to understand.

drivers/ata/pata_oldpiix.c +2 -3
diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.20-mm2/drivers/ata/pata_oldpiix.c linux-2.6.20-mm2/drivers/ata/pata_oldpiix.c
@@ -25,7 +25,7 @@
 #include <linux/ata.h>
 
 #define DRV_NAME	"pata_oldpiix"
-#define DRV_VERSION	"0.5.3"
+#define DRV_VERSION	"0.5.4"
 
 /**
  *	oldpiix_pre_reset		-	probe begin
@@ -209,10 +209,9 @@
 	struct ata_device *adev = qc->dev;
 
 	if (adev != ap->private_data) {
+		oldpiix_set_piomode(ap, adev);
 		if (adev->dma_mode)
 			oldpiix_set_dmamode(ap, adev);
-		else if (adev->pio_mode)
-			oldpiix_set_piomode(ap, adev);
 	}
 	return ata_qc_issue_prot(qc);
 }
Applied
#1 lore raw

drivers/ata/pata_oldpiix.c line 28

Quoted 13 lines · Alan

Keeps the behaviour consistent and easier to understand.

diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.20-mm2/drivers/ata/pata_oldpiix.c linux-2.6.20-mm2/drivers/ata/pata_oldpiix.c

drivers/ata/pata_oldpiix.c +1 -1
@@ -25,7 +25,7 @@
 #include <linux/ata.h>
 
 #define DRV_NAME	"pata_oldpiix"
-#define DRV_VERSION	"0.5.3"
+#define DRV_VERSION	"0.5.4"

applied