mpc83xx: add command line editing by default
PATCH 1/1 mpc83xx: add command line editing by default
--- include/configs/MPC832XEMDS.h | 1 + include/configs/MPC8349EMDS.h | 1 + include/configs/MPC8360EMDS.h | 1 + include/configs/sbc8349.h | 1 + 4 files changed, 4 insertions(+), 0 deletions(-)
include/configs/MPC832XEMDS.h +1 -0
@@ -307,6 +307,7 @@ #define CFG_BAUDRATE_TABLE \#define CFG_NS16550_COM1 (CFG_IMMR+0x4500)#define CFG_NS16550_COM2 (CFG_IMMR+0x4600) +#define CONFIG_CMDLINE_EDITING /* Command-line editing */ /* Use the HUSH parser */ #define CFG_HUSH_PARSER #ifdef CFG_HUSH_PARSER
include/configs/MPC8349EMDS.h +1 -0
@@ -314,6 +314,7 @@ #define CFG_BAUDRATE_TABLE \#define CFG_NS16550_COM1 (CFG_IMMR+0x4500)#define CFG_NS16550_COM2 (CFG_IMMR+0x4600) +#define CONFIG_CMDLINE_EDITING /* Command-line editing */ /* Use the HUSH parser */ #define CFG_HUSH_PARSER #ifdef CFG_HUSH_PARSER
include/configs/MPC8360EMDS.h +1 -0
@@ -309,6 +309,7 @@ #define CFG_BAUDRATE_TABLE \#define CFG_NS16550_COM1 (CFG_IMMR+0x4500)#define CFG_NS16550_COM2 (CFG_IMMR+0x4600) +#define CONFIG_CMDLINE_EDITING /* Command-line editing */ /* Use the HUSH parser */ #define CFG_HUSH_PARSER #ifdef CFG_HUSH_PARSER
include/configs/sbc8349.h +1 -0
@@ -313,6 +313,7 @@ #define CFG_BAUDRATE_TABLE \#define CFG_NS16550_COM1 (CFG_IMMR+0x4500)#define CFG_NS16550_COM2 (CFG_IMMR+0x4600) +#define CONFIG_CMDLINE_EDITING /* Command-line editing */ /* Use the HUSH parser */ #define CFG_HUSH_PARSER #ifdef CFG_HUSH_PARSER
Signature · 1 line
1.4.2.3
PATCH 1/1 mpc83xx: add command line editing by default
Quoted 6 lines · In message <[email protected]> you wrote:
--- include/configs/MPC832XEMDS.h | 1 + include/configs/MPC8349EMDS.h | 1 + include/configs/MPC8360EMDS.h | 1 + include/configs/sbc8349.h | 1 +
Are you the maintainer of the sbc8349 baord?
Did you discuss such a change with the maintainer?
Best regards,
Wolfgang Denk
Signature · 4 lines
DENX Software Engineering GmbH, HRB 165235 Munich, CEO: Wolfgang Denk Office: Kirchenstr. 5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de This is an unauthorized cybernetic announcement.
PATCH 1/1 mpc83xx: add command line editing by default
Quoted 11 lines · Wolfgang Denk
Quoted 6 lines · In message <[email protected]> you wrote:
--- include/configs/MPC832XEMDS.h | 1 + include/configs/MPC8349EMDS.h | 1 + include/configs/MPC8360EMDS.h | 1 + include/configs/sbc8349.h | 1 +Are you the maintainer of the sbc8349 baord?
Did you discuss such a change with the maintainer?
Ummm... Isn't that what this mailing list is for? To discuss changes?
g.
Signature · 4 lines
Grant Likely, B.Sc. P.Eng. Secret Lab Technologies Ltd. grant.likely at secretlab.ca (403) 399-0195
PATCH 1/1 mpc83xx: add command line editing by default
Quoted 6 lines · In message <[email protected]> you…
Quoted 4 lines
Are you the maintainer of the sbc8349 baord?
Did you discuss such a change with the maintainer?
Ummm... Isn't that what this mailing list is for? To discuss changes?
Yes, but there is different types of changes.
There is no need to discuss a bug fix - it should always be applied to all affected boards, of course.
But this is not a bug fix - it is a change of the board configura- tion, i. e. of the board customization. I think it is NOT a good idea if anybody meddles with the configuration of someone elses board
without discussing this explicitely with the respective board
maintainer. In the current case, it was totally unclear to me if "foreign" boards would be changed, or not.
As a complication there is the problem that this patch does not even apply to the current U-Boot tree, which does not contain such files like include/configs/MPC832XEMDS.h or include/configs/sbc8349.h; and the patch did not contain any indication which tree it was against and/or which previous patches it requires.
Best regards,
Wolfgang Denk
Signature · 5 lines
DENX Software Engineering GmbH, HRB 165235 Munich, CEO: Wolfgang Denk Office: Kirchenstr. 5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de I can't understand it. I can't even understand the people who can understand it. - Queen Juliana of the Netherlands.
PATCH 1/1 mpc83xx: add command line editing by default
Quoted 13 lines · On Fri, 16 Feb 2007 12:23:06 +0100 Wolfgang Denk <[email protected]> wrote:
Quoted 6 lines · In message <[email protected]> you…
Quoted 4 lines
Are you the maintainer of the sbc8349 baord?
Did you discuss such a change with the maintainer?
Ummm... Isn't that what this mailing list is for? To discuss changes?
Yes, but there is different types of changes.
There is no need to discuss a bug fix - it should always be applied to all affected boards, of course.
Quoted 6 lines
But this is not a bug fix - it is a change of the board configura- tion, i. e. of the board customization. I think it is NOT a good idea if anybody meddles with the configuration of someone elses board
without discussing this explicitely with the respective board
maintainer. In the current case, it was totally unclear to me if "foreign" boards would be changed, or not.
I tried communicating with Paul Gortmaker without success, so I removed the sbc8349 board config from the patch. The mpc83xx branch on:
http://opensource.freescale.com/pub/scm/u-boot-83xx.git
contains the revised patch:
PATCH 1/1 mpc83xx: add command line editing by default
Quoted 7 lines · Kim Phillips
I tried communicating with Paul Gortmaker without success, so I removed the sbc8349 board config from the patch. The mpc83xx branch on:
http://opensource.freescale.com/pub/scm/u-boot-83xx.git
contains the revised patch:
Sorry for not jumping in sooner. I'm fine with the sbc8349 having command line editing support enabled. In fact I explicitly tried to make the sbc8349.h track the MPC8349MDS as much as possible to ease maintenance on behalf of the 83xx maintainer(s) and myself.
Paul.