Skip to contentSkip to conversation

EXPORT_SYMBOL() time functions

PATCH In review Rolf Eike Beer 3 participants 6 messages Feb 21, 2007 – Feb 22, 2007

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 EXPORT_SYMBOL() time functions

These functions were inlines before 8b9365d753d9870bb6451504c13570b81923228f. Now EXPORT_SYMBOL() them to allow them to be used in modules again.

---
commit 0a543599f4a9ea02b587bda26e0e11ae94774f61
tree aa815eab413d2575925b0964a1fa01d41439b26b
parent 6b8afc66b9d6893d3fa292b75769b58539836ff3
author Rolf Eike Beer <[email protected]> Wed, 21 Feb 2007 14:10:12 +0100 committer Rolf Eike Beer <[email protected]> Wed, 21 Feb 2007 14:10:12 +0100

 kernel/time.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)
kernel/time.c +3 -0
index c6c80ea..0b351b2 100644
@@ -635,6 +635,7 @@ timeval_to_jiffies(const struct timeval *value)
 		(((u64)usec * USEC_CONVERSION + USEC_ROUND) >>
 		 (USEC_JIFFIE_SC - SEC_JIFFIE_SC))) >> SEC_JIFFIE_SC;
 }
+EXPORT_SYMBOL(timeval_to_jiffies);
 
 void jiffies_to_timeval(const unsigned long jiffies, struct timeval *value)
 {
@@ -649,6 +650,7 @@ void jiffies_to_timeval(const unsigned long jiffies, struct timeval *value)
 	tv_usec /= NSEC_PER_USEC;
 	value->tv_usec = tv_usec;
 }
+EXPORT_SYMBOL(jiffies_to_timeval);
 
 /*
  * Convert jiffies/jiffies_64 to clock_t and back.
@@ -723,6 +725,7 @@ u64 nsec_to_clock_t(u64 x)
 #endif
 	return x;
 }
+EXPORT_SYMBOL(nsec_to_clock_t);
 
 #if (BITS_PER_LONG < 64)
 u64 get_jiffies_64(void)
#1 lore raw

PATCH 1/1 EXPORT_SYMBOL() time functions

These functions were inlines before 8b9365d753d9870bb6451504c13570b81923228f. Now EXPORT_SYMBOL() them to allow them to be used in modules again.

---

Sent once again, this time without PGP signature so importing into git is easier.

commit 0a543599f4a9ea02b587bda26e0e11ae94774f61
tree aa815eab413d2575925b0964a1fa01d41439b26b
parent 6b8afc66b9d6893d3fa292b75769b58539836ff3
author Rolf Eike Beer <[email protected]> Wed, 21 Feb 2007 14:10:12 +0100 committer Rolf Eike Beer <[email protected]> Wed, 21 Feb 2007 14:10:12 +0100

 kernel/time.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)
kernel/time.c +3 -0
index c6c80ea..0b351b2 100644
@@ -635,6 +635,7 @@ timeval_to_jiffies(const struct timeval *value)
 		(((u64)usec * USEC_CONVERSION + USEC_ROUND) >>
 		 (USEC_JIFFIE_SC - SEC_JIFFIE_SC))) >> SEC_JIFFIE_SC;
 }
+EXPORT_SYMBOL(timeval_to_jiffies);
 
 void jiffies_to_timeval(const unsigned long jiffies, struct timeval *value)
 {
@@ -649,6 +650,7 @@ void jiffies_to_timeval(const unsigned long jiffies, struct timeval *value)
 	tv_usec /= NSEC_PER_USEC;
 	value->tv_usec = tv_usec;
 }
+EXPORT_SYMBOL(jiffies_to_timeval);
 
 /*
  * Convert jiffies/jiffies_64 to clock_t and back.
@@ -723,6 +725,7 @@ u64 nsec_to_clock_t(u64 x)
 #endif
 	return x;
 }
+EXPORT_SYMBOL(nsec_to_clock_t);
 
 #if (BITS_PER_LONG < 64)
 u64 get_jiffies_64(void)
#2 lore raw
Quoted 2 lines · Rolf Eike Beer

These functions were inlines before 8b9365d753d9870bb6451504c13570b81923228f. Now EXPORT_SYMBOL() them to allow them to be used in modules again.

Just because they happened to be inlined that doesn't mean modules should be using them. In fact no intree module uses them exactly because they're not intended to be used by this kind of code. Please show the code you want to use this for so we can see what you're really trying to do.

#3 lore raw
Quoted 9 lines · Christoph Hellwig
Quoted 3 lines · Rolf Eike Beer

These functions were inlines before 8b9365d753d9870bb6451504c13570b81923228f. Now EXPORT_SYMBOL() them to allow them to be used in modules again.

Just because they happened to be inlined that doesn't mean modules should be using them. In fact no intree module uses them exactly because they're not intended to be used by this kind of code. Please show the code you want to use this for so we can see what you're really trying to do.

Trying to convert a given user value (in milliseconds) to a timeout. No problem doing this with struct timespec.

Eike

#4 lore raw
In reply to Rolf Eike Beer
Quoted 2 lines · Rolf Eike Beer

These functions were inlines before 8b9365d753d9870bb6451504c13570b81923228f. Now EXPORT_SYMBOL() them to allow them to be used in modules again.

please do not add random exports without users; exports eat up kernel size and memory. At minimum specify which mainline modules use the exports..

#5 lore raw
Quoted 8 lines · Arjan van de Ven
Quoted 3 lines · Rolf Eike Beer

These functions were inlines before 8b9365d753d9870bb6451504c13570b81923228f. Now EXPORT_SYMBOL() them to allow them to be used in modules again.

please do not add random exports without users; exports eat up kernel size and memory. At minimum specify which mainline modules use the exports..

Nothing in mainline now. I just found out that the module I'm writing doesn't work anymore as timeval_to_jiffies() disappeared. If this is planned to go away from modules I should consider switching to timespec.

Eike