Skip to contentSkip to conversation

bug in gdth.c crashing machine

PATCH In review Joerg Dorchain 2 participants 2 messages Feb 23, 2007

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 bug in gdth.c crashing machine

Hello Achim,

wrt to your mail to the lkml from 13 Oct 2006 Message-ID:
<[email protected]>, I'd be pleased if you could integrate the derived patch into a bugfix release of the driver asap.

This bug kept me busy for three days, endangering backup to tapes.

Patch is against vanilla 2.6.20.

Kind regards,

Joerg

gdth.c renamed from gdth.c.orig +2 -0
@@ -3092,6 +3092,7 @@
             cmdp->u.raw64.direction  = 
                 gdth_direction_tab[scp->cmnd[0]]==DOU ? GDTH_DATA_OUT:GDTH_DATA_IN;
             memcpy(cmdp->u.raw64.cmd,scp->cmnd,16);
+            cmdp->u.raw64.sg_ranz    = 0;
         } else {
             cmdp->u.raw.reserved   = 0;
             cmdp->u.raw.mdisc_time = 0;
@@ -3108,6 +3109,7 @@
             cmdp->u.raw.direction  = 
                 gdth_direction_tab[scp->cmnd[0]]==DOU ? GDTH_DATA_OUT:GDTH_DATA_IN;
             memcpy(cmdp->u.raw.cmd,scp->cmnd,12);
+            cmdp->u.raw.sg_ranz    = 0;
         }
 
         if (scp->use_sg) {
#1 lore raw

Hi Joerg,

You are right, this patch should be added to a bugfix release as soon as possible.

Thanks,
Achim

=======================
Achim Leubner
Software Engineer / RAID drivers
ICP vortex GmbH / Adaptec Inc.
Phone: +49-351-8718291

-----Original Message-----
From: Joerg Dorchain [mailto:[email protected]]
Sent: Freitag, 23. Februar 2007 14:30
To: Leubner, Achim
Cc: [email protected]
Subject: [Patch] bug in gdth.c crashing machine

Hello Achim,

wrt to your mail to the lkml from 13 Oct 2006 Message-ID:
<[email protected]>, I'd be pleased if you could integrate the derived patch into a bugfix release of the driver asap.

This bug kept me busy for three days, endangering backup to tapes.

Patch is against vanilla 2.6.20.

Kind regards,

Joerg

gdth.c renamed from gdth.c.orig +0 -0
@@ -3092,6 +3092,7 @@
             cmdp->u.raw64.direction  = 
                 gdth_direction_tab[scp->cmnd[0]]==DOU ?
GDTH_DATA_OUT:GDTH_DATA_IN;
             memcpy(cmdp->u.raw64.cmd,scp->cmnd,16);
+            cmdp->u.raw64.sg_ranz    = 0;
         } else {
             cmdp->u.raw.reserved   = 0;
             cmdp->u.raw.mdisc_time = 0;
@@ -3108,6 +3109,7 @@
             cmdp->u.raw.direction  = 
                 gdth_direction_tab[scp->cmnd[0]]==DOU ?
GDTH_DATA_OUT:GDTH_DATA_IN;
             memcpy(cmdp->u.raw.cmd,scp->cmnd,12);
+            cmdp->u.raw.sg_ranz    = 0;
         }
 
         if (scp->use_sg) {