Skip to contentSkip to conversation

kconfig: abort configuration with recursive dependencies

PATCH New Adrian Bunk 1 participant 1 message Feb 25, 2007 Kconfig

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 kconfig: abort configuration with recursive dependencies

A recursive kconfig dependency is a bug that has to be fixed, and that might currently not be noted until booting the built kernel.

Currently, the warning that a recursive dependency was detected scrolls away during "make oldconfig", and often people don't notice until they booted the kernel and note something like "Why is there no IPV6 support?".

This patch therefore lets the configuration fail if kconfig found a recursive dependency.

scripts/kconfig/symbol.c renamed from scripts/kconfig/symbol.c.old +2 -2
@@ -792,7 +792,7 @@
 	struct property *prop;
 
 	if (sym->flags & SYMBOL_CHECK) {
-		printf("Warning! Found recursive dependency: %s", sym->name);
+		printf("Error: Found recursive dependency: %s", sym->name);
 		return sym;
 	}
 	if (sym->flags & SYMBOL_CHECKED)
@@ -820,7 +820,7 @@
 		printf(" %s", sym->name);
 		if (sym2 == sym) {
 			printf("\n");
-			sym2 = NULL;
+			exit(1);
 		}
 	}
 	sym->flags &= ~SYMBOL_CHECK;