wireless: rename d80211 -> mac80211
PATCH 1/1 wireless: rename d80211 -> mac80211
I've been threatening to do this for a while. Since I've recently pulled from everyone, the incoming patch rate is slow this week, and we are getting close to being in -mm, now seems as good a time as any to do it...
I've changed all references in wireless-dev from d80211 to mac80211 and from D80211 to MAC80211, including renaming files and directories appropriately. If you have outstanding patches, please account for this change. Filtering them through sed should do the job nicely:
cat old.patch | sed -e 's/d80211/mac80211/g' \ -e 's/D80211/MAC80211/g' > new.patch
I don't think it would have been appropriate to keep the old name, with its veiled reference to its origin but no real meaning to the uninitiated. I think the mac80211 name is more indicative of the component's function, and it matches the naming motif we are using for cfg80211 and nl80211.
I apologize if this seems sudden, but I don't really think doing it with a lot of warning would have been any better. So, I made the decision and did it. Please don't complain unless it is just unbearable for you. :-)
The patch has been pushed to wireless-dev, and hopefully will be available by the time you read this.
Thanks,
John
P.S. The actual patch is too large to post here. It is available on www.kernel.org:
http://www.kernel.org/pub/linux/kernel/people/linville/wireless-dev/master/0738-wireless-rename-d80211-mac80211.patch
Signature · 2 lines
John W. Linville [email protected]
Quoted 4 lines · John W. Linville
I apologize if this seems sudden, but I don't really think doing it with a lot of warning would have been any better. So, I made the decision and did it. Please don't complain unless it is just unbearable for you. :-)
I think it's indeed a good time for such change now. Thanks for doing that!
When we are at it, I think the module name should be 'mac80211.ko' and not '80211.ko'. This means renaming of mac80211.c (I suggest mac80211_proto.c or mac80211_main.c). Does it sounds reasonable? Should I make a patch?
Thanks,
Jiri
Signature · 2 lines
Jiri Benc SUSE Labs
Quoted 3 lines · Jiri Benc
When we are at it, I think the module name should be 'mac80211.ko' and not '80211.ko'. This means renaming of
mac80211.c(I suggestmac80211_proto.cormac80211_main.c). Does it sounds reasonable? Should I make a patch?
This has bothered me for long. Can't we just call it main.c? I mean, it's in mac80211/main.c so there's no chance of confusion... What's the point in having mac80211/mac80211_something.c?
johannes
Quoted 3 lines · Johannes Berg
This has bothered me for long. Can't we just call it
main.c? I mean, it's inmac80211/main.cso there's no chance of confusion... What's the point in havingmac80211/mac80211_something.c?
Fine with me.
Jiri
Signature · 2 lines
Jiri Benc SUSE Labs
Quoted 2 lines · John W. Linville
I've changed all references in wireless-dev from d80211 to mac80211 and from D80211 to MAC80211,
And I notice that by "all references", you really mean it:
-T: git kernel.org:/pub/scm/linux/kernel/git/mwu/d80211-drivers.git
+T: git kernel.org:/pub/scm/linux/kernel/git/mwu/mac80211-drivers.git
johannes
Review
Quoted 9 lines · Johannes Berg
Quoted 2 lines · John W. Linville
I've changed all references in wireless-dev from d80211 to mac80211 and from D80211 to MAC80211,
And I notice that by "all references", you really mean it:
(quoted diff) +1
-1-T: git kernel.org:/pub/scm/linux/kernel/git/mwu/d80211-drivers.git +T: git kernel.org:/pub/scm/linux/kernel/git/mwu/mac80211-drivers.git
Well, that may have been a bit unintentional. Still, it might be appropriate...
Michael, any chance you'd like to rename your tree so as to preserve my infallibility? :-)
John
Signature · 2 lines
John W. Linville [email protected]
Quoted 3 lines · John W. Linville
Michael, any chance you'd like to rename your tree so as to preserve my infallibility? :-)
Done.
-Michael Wu