____call_usermodehelper: don't flush_signals()
PATCH 1/1 ____call_usermodehelper: don't flush_signals()
____call_usermodehelper() has no reason for flush_signals(). It is a fresh forked process which is going to exec a user-space application or exit on failure.
kernel/kmod.c renamed from kernel/kmod.c~ +0 -1
@@ -256,7 +256,6 @@ static int ____call_usermodehelper(void/* Unblock all signals and set the session keyring. */ new_session =key_get (sub_info->ring); -flush_signals (current);spin_lock_irq (¤t->sighand->siglock); old_session =__install_session_keyring (current, new_session);flush_signal_handlers (current,1 );
Quoted 3 lines · Oleg Nesterov
____call_usermodehelper()has no reason forflush_signals(). It is a fresh forked process which is going to exec a user-space application or exit on failure.
And the flush_signal_handlers() call?
Your patch looks correct; this code was presumably lying around from before someone (I?) adapted this code to use kthread.
Thanks,
Rusty.
Quoted 7 lines · Rusty Russell
Quoted 3 lines · Oleg Nesterov
____call_usermodehelper()has no reason forflush_signals(). It is a fresh forked process which is going to exec a user-space application or exit on failure.And the
flush_signal_handlers()call?
Well... flush_old_exec() calls flush_signal_handlers(force_default = 0), this is not enough. We don't want to start user-space application with SIGKILL ignored (yes, parent doesn't ignores it currently).
Quoted 2 lines
Your patch looks correct; this code was presumably lying around from before someone (I?) adapted this code to use kthread.
Thanks! What I can't understand is why kthread/daemonize block all signals. This doesn't look good to me. This can't prevent signal delivery, this only blocks signal_wake_up(). We can even set SIGNAL_GROUP_EXIT for the kernel thread. Of course, only root can do that, but isn't it better to just ignore all signals instead of blocking them?
Note that we can't free the memory if we send a signal to (for example) khelper.
Oleg.