- platform_kernel_launch_event is noop on generic kernel
PATCH 1/1 - platform_kernel_launch_event is noop on generic kernel
Add a missing #define for the platform_kernel_launch_event. Without this fix, a call to platform_kernel_launch_event() becomes a noop on generic kernels. SN systems require this fix to successfully kdump/kexec from certain hardware errors.
---
Index: linux-2.6/include/asm-ia64/machvec.h
=================================--- linux-2.6.orig/include/asm-ia64/machvec.h 2007-02-28 08:39:45.764537727 -0600
+++ linux-2.6/include/asm-ia64/machvec.h 2007-02-28 08:40:01.254467899 -0600
@@ -168,6 +168,7 @@ extern void machvec_tlb_migrate_finish (
# define platform_setup_msi_irq ia64_mv.setup_msi_irq # define platform_teardown_msi_irq ia64_mv.teardown_msi_irq # define platform_pci_fixup_bus ia64_mv.pci_fixup_bus +# define platform_kernel_launch_event ia64_mv.kernel_launch_event # endif
/* __attribute__((__aligned__(16))) is required to make size of the
Quoted 6 lines · John Keller
Add a missing #define for the
platform_kernel_launch_event. Without this fix, a call toplatform_kernel_launch_event()becomes a noop on generic kernels. SN systems require this fix to successfully kdump/kexec from certain hardware errors.Signed-off-by John Keller <[email protected]>
I made a similar change when porting to xen, but I hadn't thought to see if mainline linux needs it to.
Signature · 3 lines
Horms H: http://www.vergenet.net/~horms/ W: http://www.valinux.co.jp/en/
Quoted 6 lines · Horms
Quoted 5 lines · John Keller
Add a missing #define for the
platform_kernel_launch_event. Without this fix, a call toplatform_kernel_launch_event()becomes a noop on generic kernels. SN systems require this fix to successfully kdump/kexec from certain hardware errors.
Quoted 6 lines
Quoted 1 line
Signed-off-by John Keller <[email protected]>I made a similar change when porting to xen, but I hadn't thought to see if mainline linux needs it to.
Acked-by Simon Horman <[email protected]>
I think there's an additional change needed. Without that, it leads to a NULL pointer dereference.
--- include/asm-ia64/machvec.h | 2 ++ 1 file changed, 2 insertions(+)
Index: b/include/asm-ia64/machvec.h =================================--- a/include/asm-ia64/machvec.h +++ b/include/asm-ia64/machvec.h
@@ -168,6 +168,7 @@ extern void machvec_tlb_migrate_finish (
# define platform_setup_msi_irq ia64_mv.setup_msi_irq # define platform_teardown_msi_irq ia64_mv.teardown_msi_irq # define platform_pci_fixup_bus ia64_mv.pci_fixup_bus +# define platform_kernel_launch_event ia64_mv.kernel_launch_event # endif
/* __attribute__((__aligned__(16))) is required to make size of the
@@ -269,6 +270,7 @@ struct ia64_machine_vector {
platform_setup_msi_irq, \
platform_teardown_msi_irq, \
platform_pci_fixup_bus, \
+ platform_kernel_launch_event \
}
extern struct ia64_machine_vector ia64_mv;
Quoted 9 lines · Bernhard Walle
Quoted 8 lines · Horms
Quoted 6 lines · John Keller
Add a missing #define for the
platform_kernel_launch_event. Without this fix, a call toplatform_kernel_launch_event()becomes a noop on generic kernels. SN systems require this fix to successfully kdump/kexec from certain hardware errors.Signed-off-by John Keller <[email protected]>
Quoted 7 lines
Quoted 4 lines
I made a similar change when porting to xen, but I hadn't thought to see if mainline linux needs it to.
Acked-by Simon Horman <[email protected]>I think there's an additional change needed. Without that, it leads to a NULL pointer dereference.
Maybe I should also get my editor right ... ;):
--- include/asm-ia64/machvec.h | 2 ++ 1 file changed, 2 insertions(+)
Index: b/include/asm-ia64/machvec.h =================================--- a/include/asm-ia64/machvec.h +++ b/include/asm-ia64/machvec.h
@@ -168,6 +168,7 @@ extern void machvec_tlb_migrate_finish (
# define platform_setup_msi_irq ia64_mv.setup_msi_irq # define platform_teardown_msi_irq ia64_mv.teardown_msi_irq # define platform_pci_fixup_bus ia64_mv.pci_fixup_bus +# define platform_kernel_launch_event ia64_mv.kernel_launch_event # endif
/* __attribute__((__aligned__(16))) is required to make size of the
@@ -269,6 +270,7 @@ struct ia64_machine_vector {
platform_setup_msi_irq, \
platform_teardown_msi_irq, \
platform_pci_fixup_bus, \
+ platform_kernel_launch_event \
}
extern struct ia64_machine_vector ia64_mv;
Jay Lan
Acked-byQuoted 8 lines · Bernhard Walle
Quoted 7 lines · Bernhard Walle
Quoted 6 lines · Horms
Quoted 5 lines · John Keller
Add a missing #define for the
platform_kernel_launch_event. Without this fix, a call toplatform_kernel_launch_event()becomes a noop on generic kernels. SN systems require this fix to successfully kdump/kexec from certain hardware errors.
Quoted 7 lines
Quoted 7 lines
Quoted 5 lines
Quoted 1 line
Signed-off-by John Keller <[email protected]>I made a similar change when porting to xen, but I hadn't thought to see if mainline linux needs it to.
Acked-by Simon Horman <[email protected]>I think there's an additional change needed. Without that, it leads to a NULL pointer dereference.
Yep, it is needed. The missing line was in Jack's original patch but was lost somehow in 2.6.20.
Quoted 30 lines
Maybe I should also get my editor right ... ;):
--- include/asm-ia64/machvec.h | 2 ++ 1 file changed, 2 insertions(+)Index:
b/include/asm-ia64/machvec.h=================================> ---a/include/asm-ia64/machvec.h+++b/include/asm-ia64/machvec.h(quoted diff) +2
-1@@ -168,6 +168,7 @@ extern void machvec_tlb_migrate_finish ( # define platform_setup_msi_irq ia64_mv.setup_msi_irq # define platform_teardown_msi_irq ia64_mv.teardown_msi_irq # define platform_pci_fixup_bus ia64_mv.pci_fixup_bus +# define platform_kernel_launch_event ia64_mv.kernel_launch_event # endif /* __attribute__((__aligned__(16))) is required to make size of the@@ -269,6 +270,7 @@ struct ia64_machine_vector { platform_setup_msi_irq, \ platform_teardown_msi_irq, \ platform_pci_fixup_bus, \ + platform_kernel_launch_event \ } extern struct ia64_machine_vector ia64_mv; -To unsubscribe from this list: send the line "unsubscribe linux-ia64" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html