Skip to contentSkip to conversation

i2c-mpc: add support for arch/powerpc/ tree

PATCH New Domen Puncer 3 participants 7 messages Mar 2, 2007 – Mar 5, 2007

Subsystems (4)
Device tree bindings PowerPC I2C subsystem host drivers Freescale mpc I2C driver
lore
Share & tools
lore

Domen Puncer

author
#0 lore raw

PATCH 1/1 i2c-mpc: add support for arch/powerpc/ tree

Add I2C support for mpc5200 powerpc tree.
Tested to work on eeprom on lite5200b.

Signed-off-by Domen Puncer <[email protected]>

---
I'm not sure how this relates to FSL_SOC config option and fsl_i2c_of_init. Comments?

Domen

 arch/powerpc/boot/dts/lite5200b.dts |    2 
 drivers/i2c/busses/i2c-mpc.c        |   80 +++++++++++++++++++++++++++++++++++-
 2 files changed, 80 insertions(+), 2 deletions(-)
arch/powerpc/boot/dts/lite5200b.dts +2 -0
Index: grant.git/arch/powerpc/boot/dts/lite5200b.dts
===================================================================
@@ -328,6 +328,7 @@
 			reg = <3d00 40>;
 			interrupts = <2 f 0>;
 			interrupt-parent = <500>;
+			fsl5200-clocking;
 		};
 
 		i2c@3d40 {

@@ -337,6 +338,7 @@
 			reg = <3d40 40>;
 			interrupts = <2 10 0>;
 			interrupt-parent = <500>;
+			fsl5200-clocking;
 		};
 		sram@8000 {
 			device_type = "sram";
drivers/i2c/busses/i2c-mpc.c +78 -2

156 lines not on this page · raw message

author
#1 lore raw

PATCH 1/1 lite5200(b) support for i2c

Add fsl-i2c to lite5200 i2c nodes in device tree, and enable FSL_SOC.

Tested to work with built-in eeprom on lite5200b.

Signed-off-by Domen Puncer <[email protected]>

---
This patch obsoletes the previous one, and is shorter too :-)

 arch/powerpc/Kconfig                |    1 +
 arch/powerpc/boot/dts/lite5200.dts  |    6 ++++--
 arch/powerpc/boot/dts/lite5200b.dts |    6 ++++--
 3 files changed, 9 insertions(+), 4 deletions(-)
arch/powerpc/Kconfig +1 -0
Index: grant.git/arch/powerpc/Kconfig
===================================================================
@@ -128,6 +128,7 @@ config CLASSIC32
 	bool "52xx/6xx/7xx/74xx"
 	select PPC_FPU
 	select 6xx
+	select FSL_SOC
 	help
 	  There are four families of PowerPC chips supported.  The more common
 	  types (601, 603, 604, 740, 750, 7400), the Motorola embedded
arch/powerpc/boot/dts/lite5200b.dts +4 -2
Index: grant.git/arch/powerpc/boot/dts/lite5200b.dts
===================================================================
@@ -323,20 +323,22 @@
 
 		i2c@3d00 {
 			device_type = "i2c";
-			compatible = "mpc5200b-i2c\0mpc5200-i2c";
+			compatible = "mpc5200b-i2c\0mpc5200-i2c\0fsl-i2c";
 			cell-index = <0>;
 			reg = <3d00 40>;
 			interrupts = <2 f 0>;
 			interrupt-parent = <500>;
+			fsl5200-clocking;
 		};
 
 		i2c@3d40 {
 			device_type = "i2c";
-			compatible = "mpc5200b-i2c\0mpc5200-i2c";
+			compatible = "mpc5200b-i2c\0mpc5200-i2c\0fsl-i2c";
 			cell-index = <1>;
 			reg = <3d40 40>;
 			interrupts = <2 10 0>;
 			interrupt-parent = <500>;
+			fsl5200-clocking;
 		};
 		sram@8000 {
 			device_type = "sram";
arch/powerpc/boot/dts/lite5200.dts +4 -2
Index: grant.git/arch/powerpc/boot/dts/lite5200.dts
===================================================================
@@ -318,20 +318,22 @@
 
 		i2c@3d00 {
 			device_type = "i2c";
-			compatible = "mpc5200-i2c";
+			compatible = "mpc5200-i2c\0fsl-i2c";
 			cell-index = <0>;
 			reg = <3d00 40>;
 			interrupts = <2 f 0>;
 			interrupt-parent = <500>;
+			fsl5200-clocking;
 		};
 
 		i2c@3d40 {
 			device_type = "i2c";
-			compatible = "mpc5200-i2c";
+			compatible = "mpc5200-i2c\0fsl-i2c";
 			cell-index = <1>;
 			reg = <3d40 40>;
 			interrupts = <2 10 0>;
 			interrupt-parent = <500>;
+			fsl5200-clocking;
 		};
 		sram@8000 {
 			device_type = "sram";
#2 lore raw

Re: [PATCH alternative] lite5200(b) support for i2c

Quoted 23 lines · Domen Puncer

Add fsl-i2c to lite5200 i2c nodes in device tree, and enable FSL_SOC.

Tested to work with built-in eeprom on lite5200b.

Signed-off-by Domen Puncer <[email protected]>

---
This patch obsoletes the previous one, and is shorter too :-)

 arch/powerpc/Kconfig                |    1 +
 arch/powerpc/boot/dts/lite5200.dts  |    6 ++++--
 arch/powerpc/boot/dts/lite5200b.dts |    6 ++++--
 3 files changed, 9 insertions(+), 4 deletions(-)

Index: grant.git/arch/powerpc/Kconfig
===================================================================

arch/powerpc/Kconfig config CLASSIC32 · line 134

Quoted 7 lines
arch/powerpc/Kconfig +1 -0
@@ -128,6 +128,7 @@ config CLASSIC32
 	bool "52xx/6xx/7xx/74xx"
 	select PPC_FPU
 	select 6xx
+	select FSL_SOC
 	help
 	  There are four families of PowerPC chips supported.  The more common
 	  types (601, 603, 604, 740, 750, 7400), the Motorola embedded

I would put the select FSL_SOC under the PPC_MPC52xx symbol and not the CLASSIC32 one.
Otherwise, looks good.

Sylvain

author
#3 lore raw

PATCH 1/1 lite5200(b) support for i2c

Add fsl-i2c to mpc5200 i2c node in device tree, and enable FSL_SOC.

Tested to work with built-in eeprom on lite5200b.

Signed-off-by Domen Puncer <[email protected]>

---
D'oh, of course it makes more sense under PPC_MPC52xx.

 arch/powerpc/Kconfig                |    1 +
 arch/powerpc/boot/dts/lite5200.dts  |    6 ++++--
 arch/powerpc/boot/dts/lite5200b.dts |    6 ++++--
 3 files changed, 9 insertions(+), 4 deletions(-)
arch/powerpc/Kconfig +1 -0
Index: grant.git/arch/powerpc/Kconfig
===================================================================
@@ -434,6 +434,7 @@ config PPC_CHRP
 
 config PPC_MPC52xx
 	bool
+	select FSL_SOC
 	default n
 
 config PPC_MPC5200
arch/powerpc/boot/dts/lite5200b.dts +4 -2
Index: grant.git/arch/powerpc/boot/dts/lite5200b.dts
===================================================================
@@ -323,20 +323,22 @@
 
 		i2c@3d00 {
 			device_type = "i2c";
-			compatible = "mpc5200b-i2c\0mpc5200-i2c";
+			compatible = "mpc5200b-i2c\0mpc5200-i2c\0fsl-i2c";
 			cell-index = <0>;
 			reg = <3d00 40>;
 			interrupts = <2 f 0>;
 			interrupt-parent = <500>;
+			fsl5200-clocking;
 		};
 
 		i2c@3d40 {
 			device_type = "i2c";
-			compatible = "mpc5200b-i2c\0mpc5200-i2c";
+			compatible = "mpc5200b-i2c\0mpc5200-i2c\0fsl-i2c";
 			cell-index = <1>;
 			reg = <3d40 40>;
 			interrupts = <2 10 0>;
 			interrupt-parent = <500>;
+			fsl5200-clocking;
 		};
 		sram@8000 {
 			device_type = "sram";
arch/powerpc/boot/dts/lite5200.dts +4 -2
Index: grant.git/arch/powerpc/boot/dts/lite5200.dts
===================================================================
@@ -318,20 +318,22 @@
 
 		i2c@3d00 {
 			device_type = "i2c";
-			compatible = "mpc5200-i2c";
+			compatible = "mpc5200-i2c\0fsl-i2c";
 			cell-index = <0>;
 			reg = <3d00 40>;
 			interrupts = <2 f 0>;
 			interrupt-parent = <500>;
+			fsl5200-clocking;
 		};
 
 		i2c@3d40 {
 			device_type = "i2c";
-			compatible = "mpc5200-i2c";
+			compatible = "mpc5200-i2c\0fsl-i2c";
 			cell-index = <1>;
 			reg = <3d40 40>;
 			interrupts = <2 10 0>;
 			interrupt-parent = <500>;
+			fsl5200-clocking;
 		};
 		sram@8000 {
 			device_type = "sram";
Acked-by on v1 1/1
#4 lore raw

Re: [PATCH try3] lite5200(b) support for i2c

Quoted 7 lines · Domen Puncer

Add fsl-i2c to mpc5200 i2c node in device tree, and enable FSL_SOC.

Tested to work with built-in eeprom on lite5200b.

Signed-off-by Domen Puncer <[email protected]>
Acked-by Sylvain Munaut <[email protected]>

I'll make sure this is included in my next merge batch to Paul.

Sylvain

Quoted 80 lines

---
D'oh, of course it makes more sense under PPC_MPC52xx.

 arch/powerpc/Kconfig                |    1 +
 arch/powerpc/boot/dts/lite5200.dts  |    6 ++++--
 arch/powerpc/boot/dts/lite5200b.dts |    6 ++++--
 3 files changed, 9 insertions(+), 4 deletions(-)

Index: grant.git/arch/powerpc/Kconfig
===================================================================

arch/powerpc/Kconfig +1 -0
@@ -434,6 +434,7 @@ config PPC_CHRP
 
 config PPC_MPC52xx
 	bool
+	select FSL_SOC
 	default n
 
 config PPC_MPC5200

Index: grant.git/arch/powerpc/boot/dts/lite5200b.dts
===================================================================

arch/powerpc/boot/dts/lite5200b.dts +4 -2
@@ -323,20 +323,22 @@
 
 		i2c@3d00 {
 			device_type = "i2c";
-			compatible = "mpc5200b-i2c\0mpc5200-i2c";
+			compatible = "mpc5200b-i2c\0mpc5200-i2c\0fsl-i2c";
 			cell-index = <0>;
 			reg = <3d00 40>;
 			interrupts = <2 f 0>;
 			interrupt-parent = <500>;
+			fsl5200-clocking;
 		};
 
 		i2c@3d40 {
 			device_type = "i2c";
-			compatible = "mpc5200b-i2c\0mpc5200-i2c";
+			compatible = "mpc5200b-i2c\0mpc5200-i2c\0fsl-i2c";
 			cell-index = <1>;
 			reg = <3d40 40>;
 			interrupts = <2 10 0>;
 			interrupt-parent = <500>;
+			fsl5200-clocking;
 		};
 		sram@8000 {
 			device_type = "sram";

Index: grant.git/arch/powerpc/boot/dts/lite5200.dts
===================================================================

arch/powerpc/boot/dts/lite5200.dts +4 -2
@@ -318,20 +318,22 @@
 
 		i2c@3d00 {
 			device_type = "i2c";
-			compatible = "mpc5200-i2c";
+			compatible = "mpc5200-i2c\0fsl-i2c";
 			cell-index = <0>;
 			reg = <3d00 40>;
 			interrupts = <2 f 0>;
 			interrupt-parent = <500>;
+			fsl5200-clocking;
 		};
 
 		i2c@3d40 {
 			device_type = "i2c";
-			compatible = "mpc5200-i2c";
+			compatible = "mpc5200-i2c\0fsl-i2c";
 			cell-index = <1>;
 			reg = <3d40 40>;
 			interrupts = <2 10 0>;
 			interrupt-parent = <500>;
+			fsl5200-clocking;
 		};
 		sram@8000 {
 			device_type = "sram";
#5 lore raw

Re: [PATCH try3] lite5200(b) support for i2c

Quoted 6 lines · Sylvain Munaut
Quoted 5 lines · Domen Puncer

Add fsl-i2c to mpc5200 i2c node in device tree, and enable FSL_SOC.

Tested to work with built-in eeprom on lite5200b.

Quoted 6 lines
Quoted 2 lines
Signed-off-by Domen Puncer <[email protected]>
Acked-by Sylvain Munaut <[email protected]>

I'll make sure this is included in my next merge batch to Paul.

Driver patches should go via the driver subsystem maintainers and not Paul.

- k

#6 lore raw

Re: [PATCH try3] lite5200(b) support for i2c

Quoted 11 lines · Kumar Gala
Quoted 8 lines · Sylvain Munaut
Quoted 7 lines · Domen Puncer

Add fsl-i2c to mpc5200 i2c node in device tree, and enable FSL_SOC.

Tested to work with built-in eeprom on lite5200b.

Signed-off-by Domen Puncer <[email protected]>
Quoted 7 lines
Quoted 4 lines
Acked-by Sylvain Munaut <[email protected]>

I'll make sure this is included in my next merge batch to Paul.

Driver patches should go via the driver subsystem maintainers and not Paul.

Sorry, ignore me. I was looking at Domen's initial patch which touched drivers/i2c/busses/i2c-mpc.c

- k